search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 405 forks source link

0.59.9 Discussion #127

Closed kelset closed 5 years ago

kelset commented 5 years ago

Conversation on this thread are limited to 0.59.9 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.59.9 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.59-stable branch yourself, in order to ensure that the process proceeds smoothly.

aldistel commented 5 years ago

Any chance we could cherry-pick https://github.com/facebook/react-native/pull/25150/commits/e787dd0ad614910497af05ade4f54831280ffbd6?

ImBeCiliC commented 5 years ago

Hello can the new Keyboard behaviour on Android come into the next release? https://github.com/facebook/react-native/commit/d88e4701fc46b028861ddcfa3e6ffb141b3ede3d It's from this old and long discussion https://github.com/facebook/react-native/issues/14045 Thanks

MoKhajavi75 commented 5 years ago

Hey

Can we have this one please? https://github.com/facebook/react-native/commit/d9a8ac5071d23275c5d4a8e9936f391b967416d7

Vyazovoy commented 5 years ago

Hi! Is it possible to upgrade Metro and it’s related deps to last compatible versions? As those contains useful features and fixes

SystemBlad commented 5 years ago

Him @kelset. I notice InteractionManager stop working in version 0.59.9.

kelset commented 5 years ago

@Vyazovoy can you point to a commit that does that please?

@SystemBlad can you open an issue for that?

Vyazovoy commented 5 years ago

@kelset nvm, it has to be done in CLI package, sorry

SystemBlad commented 5 years ago

@Vyazovoy can you point to a commit that does that please?

@SystemBlad can you open an issue for that?

@kelset the problem with InteractionManager.runAfterInteractions was fixed setting isInteraction = true in the react-navigation animation. Thanks

Salakar commented 5 years ago

👋 hey @kelset - would super appreciate https://github.com/facebook/react-native/commit/995b4d30491d2336fed4a975e965668d9c8d5b7c getting picked, would finally allow changing the debug port on Android, huge DX, at least for me anyway

erennyuksell commented 5 years ago

Could we cherry-pick this one https://github.com/facebook/react-native/pull/24793

cristianoccazinsp commented 5 years ago

@Vyazovoy can you point to a commit that does that please? @SystemBlad can you open an issue for that?

@kelset the problem with InteractionManager.runAfterInteractions was fixed setting isInteraction = true in the react-navigation animation. Thanks

Can you elaborate more on this? I'm having the same issue. Upgrading to 0.59.9 out of nowhere broke every call of runAfterInteractions. This function used to have some serious timeout/delay, but now seems to be instant all the time. So anything that relied on this delay is now broken.

radeno commented 5 years ago

Gradle plugin can be updated to https://github.com/facebook/react-native/commit/8d61a4e5f90893b3d7baec1d6a76603786ea7a1c to be compatible with 0.60 as much. But that commit depends on Kotlin based code what is available in 0.60. Should i make custom PR for that?

tido64 commented 5 years ago

Any chance we could cherry-pick facebook/react-native@e787dd0?

@kelset Looks like this got moved: https://github.com/facebook/react-native/commit/2dd7dd8e45f9d4a1086f84d5b70ea66406d98439. Can we get it into the next 0.59 please? 😄

cc @aldistel

derekstavis commented 5 years ago

Can we have this PR https://github.com/facebook/react-native/pull/21163 included in this release?

This issue can cause a big performance issue when refreshing data or when implementing live-updating search.

kelset commented 5 years ago

hey everyone - quick update on 0.59.x. We are currently working hard on the 0.60, and I had a few conversations with other people in the core that don't think that it's a good idea to keep supporting 0.59 after 0.60 is out.

If we end up doing a new 0.59.x I'll write an update here.

tido64 commented 5 years ago

@kelset Do you think it's feasible to get an updated JSC to address the crashes on 64-bit devices? Latest update seems to have addressed all issues: https://github.com/react-native-community/jsc-android-buildscripts/pull/114

kelset commented 5 years ago

I'm not sure sadly.

I'd like to do one more 0.59.x release also to bump the cli dep and make sure that everyone will use 1.9.x - since Xcode 11 affects the payload of the simulators json.

I'll write an update if we are going to do it.

kristerkari commented 5 years ago

Do you think it's feasible to get an updated JSC to address the crashes on 64-bit devices?

It would definitely be really nice to get a new 0.59.x patch version with the JSC fix after it gets released. Currently jsc-android causes a crash on Samsung Galaxy S7.

kelset commented 5 years ago

@kristerkari I think that you should be able to replace the version of jsc-android with the one published under @next (v245459.0.0) via yarn resolutions - AFAIK it should "be enough".

kristerkari commented 5 years ago

I think that you should be able to replace the version of jsc-android with the one published under @next (v245459.0.0) via yarn resolutions - AFAIK it should "be enough".

Yeah that's what I did already and it worked.

How is the JSC dependency defined in React Native? Is there any kind of automatic update for existing projects?

I'm just thinking that there might be a lot of 0.59.x users who don't know that their app is crashing on Galaxy S7. That's why I was thinking that it might be good to do a patch and make sure that the fix is included.

soh335 commented 5 years ago

If 0.59.x is still released, please cherry-pick https://github.com/facebook/react-native/commit/76c50c1db15a1040b185770072d960652e7974a3 .

Kudo commented 5 years ago

@kelset Just in case if you will plan to upgrade JSC for RN 0.59, the upgrade process is not like what we did in master or 0.60-stable. You should upgrade the version at https://github.com/facebook/react-native/blob/0.59-stable/ReactAndroid/gradle.properties#L23

levibuzolic commented 5 years ago

Hoping to see another 0.59.x release with a JSC update for the crashing Galaxy S7 issues.

If there is any plans for another release, would appreciate this to be cherry-picked: https://github.com/facebook/react-native/commit/df50eee8e14b51bfcea9bc90e68a2cb46e68db82 fixes an issue with animations not running when starting from a non-zero value.

kelset commented 5 years ago

👋 everyone.

As you may be aware, doing releases of React Native is a challenging task - but we know that this JSC problem was widespread and important, so we did one last 0.59.10 patch release to provide you with the new version of the JSC.

Huge thanks to @kudo for his work on back-porting this to 0.59.

We will not do new 0.59 releases (for the foreseeable future), but we are working really hard to ensure that 0.60 will be awesome and we hope that you'll all be able to upgrade swiftly with all the tools that have been working on to help you during it 🤗

levibuzolic commented 5 years ago

Thanks @kelset and @Kudo, really appreciate the hard work.

nekhaly commented 5 years ago

image I think it considers the 1 part of "10" is older than 3

kelset commented 5 years ago

@nekhaly what command did you pass to get that error? Given that it's a patch, you can simply change the number in the package.json, remove node_modules & clear caches and do a yarn to reinstall & you are good to go.

SaeedZhiany commented 5 years ago

@nekhaly it was a rn-diff-purge bug that fixed yesterday, follow the guide in here