search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 405 forks source link

0.60.6 Discussion #130

Closed kelset closed 4 years ago

kelset commented 5 years ago

Conversation on this thread are limited to 0.60.5 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.60.5 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.60-stable branch yourself, in order to ensure that the process proceeds smoothly.

maheshaarkenea commented 5 years ago

"react-native eject" command not working after this upgrade. i deleted ios and android folder. now i have no option to create those again. created new project and the new xcworkspace file came. cant open it with xcode 10.1. another issue.

kesha-antonov commented 5 years ago

Good job guys

erennyuksell commented 5 years ago

I think autolinking causing problems with react-native-navigation see here

gleydson commented 5 years ago

I had the same problem @Frekansapp!

erennyuksell commented 5 years ago

@gleydson did you solve it?

Ilphrin commented 5 years ago

Thank you all so much for your awesome work! =D Can't wait to have enough time to contribute myself fur future releases! I don't see any commit that should be merged in a hurry for next minor release (even though I'd love to see the new jsc-android update and this ScrollView sticky header ;) ), but I'll stay tuned

ImBeCiliC commented 5 years ago

Hello this was also posted to 0.59.x and sadly didn't made it into the 0.59.10 release. Can the new Keyboard behaviour on Android come into the next 0.60.x release? facebook/react-native@d88e470 It's from this old and long discussion facebook/react-native#14045 Thanks

sunnylqm commented 5 years ago

Please cherry pick https://github.com/facebook/react-native/commit/76c50c1db15a1040b185770072d960652e7974a3

matamicen commented 5 years ago

Thank you guys for the effort!

CocoaPod is included in this version, so any ideas how is the new procedure to install for example react-native-firebase for admob? in release 0.58 We had to follow this guide but now with cocoapod included is any other easier way to install it ? any help how to do it ?

Thanks!

thymikee commented 5 years ago
xzilja commented 5 years ago

@matamicen most packages will have something called a .podspec file, so to add them through CocoaPods, you just need to point to dir where that .podspec file lives. Here is example with react-native-firebase v5

# Firebase (note you need to include firebase pods as well for features that you use)
  pod 'Firebase', '~> 5.20.0'
  pod 'Firebase/Core', '~> 5.20.0'
  pod 'Firebase/Analytics', '~> 5.20.0'
  pod 'Firebase/DynamicLinks', '~> 5.20.0'
  pod 'Firebase/Messaging', '~> 5.20.0'

  # React-Native libraries (react-native-firebase)
  pod 'RNFirebase', :path => '../node_modules/react-native-firebase/iOS'

From here you just run pod update in your ios dir and it will install everything.

sunnylqm commented 5 years ago

@dulmandakh Do you mean this one? https://github.com/facebook/react-native/commit/7254bab0b3fa129cd238783ab993fbae1102d60a

AndrewJack commented 5 years ago

Can this iOS 13 fix get cherry picked? https://github.com/facebook/react-native/commit/46bdb4161c84b33f1d0612e9c7cdd824462a31fd

Related issue: https://github.com/facebook/react-native/issues/25181

matamicen commented 5 years ago

@matamicen most packages will have something called a .podspec file, so to add them through CocoaPods, you just need to point to dir where that .podspec file lives. Here is example with react-native-firebase v5

# Firebase (note you need to include firebase pods as well for features that you use)
  pod 'Firebase', '~> 5.20.0'
  pod 'Firebase/Core', '~> 5.20.0'
  pod 'Firebase/Analytics', '~> 5.20.0'
  pod 'Firebase/DynamicLinks', '~> 5.20.0'
  pod 'Firebase/Messaging', '~> 5.20.0'

  # React-Native libraries (react-native-firebase)
  pod 'RNFirebase', :path => '../node_modules/react-native-firebase/iOS'

From here you just run pod update in your ios dir and it will install everything.

@IljaDaderko thanks very clear!

kelset commented 5 years ago

quick update: I changed this conversation to about 0.60.3 aiming for 0.60.4 since Hermes was micdropped during ChainReact 😂

We'll likely do a new release soon-ish, as soon as this fix for the CLI is implemented so that we can cherry pick this https://github.com/facebook/react-native/commit/7254bab0b3fa129cd238783ab993fbae1102d60a

Also, because of Hermes landing in branch directly a few of the CI jobs we have set up in that branch are now failing, which lowers a bit my confidence on ensuring that the releases are as bug free as we can get them to be - so it's likely that patch releases will be small and limited while aiming for a quick rollout of 0.61 (more details about it will arrive in the next couple weeks, we are waiting for some things to land).

fungilation commented 5 years ago

To be clear of what you are saying. For CI fixes and larger changes in RN needed to accommodate Hermes, those are going to land in 0.61 instead? So it's reasonable that production apps should wait for 0.61 before using Hermes?

kelset commented 5 years ago

Oh no - sorry I meant that the Hermes commit broke some CI jobs that are set up in the 0.60 branch.

To clarify: you can use Hermes via 0.60.3 even in production (AFAIK - I haven't seen any major issues in the main repo), but simply since the CI is kinda broken in the 0.60-branch it means we have less ways to detect eventual issues that may be caused by some cherry picks.

But the CI on master branch is actually been improved a lot since 0.60-branch was cut, and it's green again from what I can see so 0.61-branch will have a more stable and reliable CI.

janicduplessis commented 5 years ago

https://github.com/facebook/react-native/commit/88e18b6c8d562a4571cc48c202dda944cacfd742 to fix blob memory leak on Android. Might also need https://github.com/janicduplessis/react-native/commit/6c2f4f52feefc71a15fe7df4731440da9bdfa5b7 (hermes has not landed on master so can't land this diff) which caused a crash for me when trying out hermes.

kelset commented 5 years ago

@janicduplessis I think that that diff will have to be done as PR against the 0.60-branch to see it happen in 0.60.x because Hermes was landed first in the branch so I don't think that the code will be precisely the same once it's on master (so yeah, I fear you may having to end up doing that PR twice 😓)

moonstruck commented 5 years ago

@Ivan-Stashak-CardinalPeak Please report the issue to https://github.com/react-native-community/react-native-webview or React Native repo. Purpose of this thread is not issue reporting.

Conversation on this thread are limited to 0.60.3 release's major issues and cherry-pick requests from commits that are already on master.

Kennytian commented 5 years ago

@Ivan-Stashak-CardinalPeak see https://github.com/react-native-community/react-native-webview/blob/master/docs/Getting-Started.md

mjmasn commented 5 years ago

https://github.com/facebook/react-native/commit/b432b8f13b4871dcafd690e57d37298662712b50 please @kelset!

matpaul commented 5 years ago

svg animation with nativeDriver https://github.com/facebook/react-native/commit/bdc530b9bbf6099563d64fb573c4e6cbc93f9c5d

thymikee commented 5 years ago

CLI bump: https://github.com/facebook/react-native/commit/fafe5ee0726061e3590b91d3b5cff04e33781f87

artdent commented 5 years ago

facebook/react-native@6ef9106 would be a useful cherrypick - it fixes use_native_modules! in certain projects that use Cocoapods. It's a fix spun out of facebook/react-native#25349, which is a broader umbrella issue.

janicduplessis commented 5 years ago

@kelset Actually the second commit doesn't depend on hermes landing on master so I created a PR for it https://github.com/facebook/react-native/pull/25720, when it lands we can cherry pick both commits.

kelset commented 5 years ago

Ok, thanks for the clarification @janicduplessis - I've subscribed to the new PR (thanks for doing it!) so I should be aware of when it lands.

@artdent as I have commented on the issue, that fix will only land on 0.61 - the commit you are referring to is only part 1 and it will involve breaking changes (as far as I am aware of).

Aside from all of this, couple of extra things:

artdent commented 5 years ago

@kelset The breaking changes are in part 2. Part 1 doesn't attempt to fix use_frameworks!; it just fixes the missing header file <double-conversion/double-conversion.h> as reported in facebook/react-native#25349. I've just verified locally that cherry-picking facebook/react-native@6ef9106 into RN 0.60.3 fixes the missing header file in my project without introducing any other problems.

thymikee commented 5 years ago

@kelset the 0.x is a special case in semver indicating unstable APIs and ^0.54.1 will resolve to 0.54.x. See: https://jubianchi.github.io/semver-check/#/^0.54.1/0.55.0. It seems like folks there have issues with their package manager (npm, why I'm not surprised). The issue is metro-source-map being explicitly set at 0.55.

kelset commented 5 years ago

@artdent oh ok awesome, thanks for the clarification!

@thymikee yeah what I meant up there with 0.54.x was simply "the latest version of 54 of which I can't remember the precise number" ;D

cihati commented 5 years ago

@kelset is there an ETA for the release?

OzzieOrca commented 5 years ago

https://github.com/facebook/react-native/commit/14b455f69a30d128db384749347f41b03b9a6000 - Set rounded rectangle mask on TouchableNativeFeedback's ripples

solonifer commented 5 years ago

error: bundling failed: Error: Unable to resolve module warnOnce from /Users/user/Documents/myapp/HB/node_modules/react-native/Libraries/react-native/react-native-implementation.js: Module warnOnce does not exist in the Haste module map

react-native 0.60.4

tryied everything from https://github.com/facebook/react-native/issues/23943 with no luck :(

HarshitMadhav commented 5 years ago

@kelset Please can you cherry pick this one issue https://github.com/facebook/react-native/issues/21801 ?

khat33b commented 5 years ago

When building a release APK in Android, I am getting error while bundling the JS. This is not happening while running a debug app.

Loading dependency graph, done.
info Writing bundle output to:, /home/react-native/test/android/app/build/generated/assets/react/release/index.android.bundle
info Writing sourcemap output to:, /home/react-native/test/android/app/build/intermediates/sourcemaps/react/release/index.android.bundle.packager.map
info Done writing bundle output
info Done writing sourcemap output
info Copying 64 asset files
info Done copying assets

Then many errors are thrown which say that some variables in the android/app/build/generated/assets/react/release/index.android.bundle are not declared.

Stack dump:
0.      Program arguments: ../../node_modules/hermesvm/linux64-bin/hermes -emit-binary -out /home/tivintis/react-native/contv/android/app/build/generated/assets/react/release/index.android.bundle /home/tivintis/react-native/contv/android/app/build/generated/assets/react/release/index.android.bundle -O -output-source-map 
1.      Program arguments: ../../node_modules/hermesvm/linux64-bin/hermes -emit-binary -out /home/tivintis/react-native/contv/android/app/build/generated/assets/react/release/index.android.bundle /home/tivintis/react-native/contv/android/app/build/generated/assets/react/release/index.android.bundle -O -output-source-map 

> Task :app:bundleReleaseJsAndAssets FAILED

FAILURE: Build failed with an exception.

* Where:
Script '/home/react-native/test/node_modules/react-native/react.gradle' line: 142

* What went wrong:
Execution failed for task ':app:bundleReleaseJsAndAssets'.
> Process 'command '../../node_modules/hermesvm/linux64-bin/hermes'' finished with non-zero exit value 135
mikehardy commented 5 years ago

@khat33b and @solonifer - 

Conversation on this thread are limited to 0.60.4 release's major issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.60.4 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.
chaitanyadeorukhkar commented 5 years ago

https://github.com/facebook/react-native/commit/c5ea18f7389fe821e7a9882e4b1b30b0a1b266f4

Fixes build failures for apps with App extension on iOS. Thanks!

mguay22 commented 5 years ago

Same as @solonifer - unable to use Jest right now.

@cpojer Are you able to provide the commit that fixes the issue you previously mentioned here on facebook/react-native#23943

This was fixed on master (we stopped using haste) and it will be part of 0.61. If you are using a previous version of RN, make sure you are using "jest": { "preset": "react-native" } in your setup properly, otherwise it will not work.

velvenkat commented 5 years ago

@kelset In version 0.60.4, error is getting while set enableHermes=true in build.gradle file Execution failed for task ':app:bundleReleaseJsAndAssets'.

A problem occurred starting process 'command '....\node_modules\hermesvm\win64-bin\hermes''

kdawgwilk commented 5 years ago

Seems like this should be renamed to 0.60.5 now that 0.60.4 was released? I would love to see facebook/react-native#25619 cherry picked along with facebook/react-native#25818 & facebook/react-native#25816 but I fear that won't happen because there are possibly breaking changes with header imports for 3rd party libraries. 😢 0.60.x switch to CocoaPods broke our CocoaPods setup we already were using due to those issues we are stuck on 0.59.x for now

diegolmello commented 5 years ago

@kelset Can you cherry pick https://github.com/facebook/react-native/commit/c5ea18f7389fe821e7a9882e4b1b30b0a1b266f4? Thank you!

thymikee commented 5 years ago

Fixes template build failed in release mode: https://github.com/facebook/react-native/commit/0fcaca8e26223e47cc101c76bb7a7b02e0fc7101

JuanJo4 commented 5 years ago

Adding the debug.keystore file back https://github.com/facebook/react-native/commit/d55025694be8b4ee5d09c8fdc910d42a5f144883

janicduplessis commented 5 years ago

Merged https://github.com/facebook/react-native/commit/ffdf3f22c68583fe77517f78dd97bd2e97ff1b9e. We had to make a new PR instead of cherry-picking since the hermes commit on 0.60 and master is slightly different.

HarshitMadhav commented 5 years ago

@janicduplessis Hi! this comment on the issue https://github.com/facebook/react-native/issues/21801#issuecomment-460833140 leading to a comment of yours regarding regression https://github.com/facebook/react-native/issues/15445#issuecomment-326680200 I want to know whether this small issue has been fixed? Can this issue be cherry-picked for next update?

spyshower commented 5 years ago

Not sure if this is the right place to ask but, do we have an estimate for the 0.61 release?

grabbou commented 5 years ago

@spyshower there's no estimation, but we are planning to ship it in the next two weeks. Updates will follow.

I am also back to the releases train and will be taking over the work on 0.60.5 as started by @kelset. It's been a while and I've been enjoying my OSS break, but back to duty.

I am going to cherry-pick the commits in this thread later today & tomorrow an update. I am hoping it will go through without major issues.

jinshin1013 commented 5 years ago

If not too late can we add this: [iOS] Fixes renderingMode not applied to GIF images: https://github.com/facebook/react-native/pull/24794#issue-277680176

Thanks!!

grabbou commented 5 years ago

@jinshin1013 I see this commit is already part of 0.60.4. Have you tried running your app with that version?

grabbou commented 5 years ago

I just ended up going through this thread and looking at the cherry-pick requests. I wanted to thank everyone for participation and discussing the changes.

Here's the list of the commits that I am going to cherry-pick: facebook/react-native@d88e470 facebook/react-native@76c50c1 facebook/react-native@5b448ec facebook/react-native@a162554 facebook/react-native@7254bab facebook/react-native@46bdb41 facebook/react-native@b432b8f facebook/react-native@fafe5ee facebook/react-native@fafe5ee (thanks for clarification later in the thread) facebook/react-native@14b455f facebook/react-native@c5ea18f

Here's some that need clarification: 

@janicduplessis: facebook/react-native@88e18b6 - what’s the status of your PR? Is there anything that I should cherry-pick now? I got lost in the thread

Here's some of the commits that we are not going to cherry-pick: @matpaul: facebook/react-native@bdc530b - this is pretty heavy diff and seems like a new feature too. I’d be more confident shipping that as a part of next release @HarshitMadhav: as per the main thread comment, you need to point to a merged PR instead of an issue/open PR. @kdawgwilk: yes. CocoaPods support to land in 0.61.