0.61.x Discussion

[grabbou]

Conversation on this thread are limited to 0.61.x issues and cherry-pick requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.x cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry-pick is a complicated port, you will be asked to create the PR to the 0.61-stable branch yourself, in order to ensure that the process proceeds smoothly

[TheSavior]

I know we aren't thinking about cherry picks yet, but it would be great if we are able to get this into 0.61 https://github.com/facebook/react-native/commit/b8d6ef372663fe6d467144abfc5d2c9352dc28d6

[kelset]

should we just wait until master is green and re-cut after that?

[grabbou]

I haven't been able to get any updates regarding CI failures for the past few days and it's not clear when they will be fixed.

After discussing it on the #releases channel, we have decided to ship it "as is" because it works locally and it's an RC.

It's a requirement to cherry-pick CI fixes before we go stable, but we want to ship some of the new features out the door.

[grabbou]

I have managed to dig deeper and fix a few tests. I am now working on fixing use_framework! tests to make sure we ship a release that works 100%.

I will get back with the update, once fixed, we are good to go.

[fkgozali]

The following should be picked:

• https://github.com/facebook/react-native/commit/947e71a922c0db5d3d3780d249d1a8d183534c22
• https://github.com/facebook/react-native/commit/59f84ca1fd4a5700d67cc7c68194dd845a1ecfd6

It should fix some OOM issue when having a lot of images (especially GIFs)

[grabbou]

I have picked them @fkgozali. The release is now being published. I have managed to resolve CircleCI issues by contacting their support team.

[grabbou]

That said, I have also unlocked this thread now that the release is going to be available really soon.

[gaodeng]

Since iOS 13 & Android 10 will be officially released soon, I really hope that this commit https://github.com/facebook/react-native/pull/26172 about Dark Mode can be merged quickly.

[brentvatne]

@gaodeng - i didn't add android support to it yet but https://github.com/expo/react-native-appearance is also something you can use right now. it's that PR extracted to a lib that works on react-native 0.59+ (and maybe earlier, at least the parts w/o hooks)

[owinter86]

Not sure if this is a bug, or the pro tip regarding the ios splash screen is no longer valid.

But if it is implemented, the splash screen is permanently rendered above the app and is never dismissed.

[kelset]

@owinter86 can you please open an issue for it?

[owinter86]

@owinter86 can you please open an issue for it?

No worries, I can do that, but this is directly related to the 0.61RC though and the releases page directs me to this issue for bug reports?

[kelset]

yes, but ideally we'd prefer to have here only the link to the issue; that way the conversation/investigation/debugging of that issue can happen over there and not here.

[TheSavior]

This commit which I believe is included in 0.61 made a breaking change to TouchableNativeFeedback and the revert will need to get picked once it lands. I'm leaving on vacation today before RN.EU and might not be able to flag the actual commit.

[BrendonSled]

Some weird namespace issue showed up in my tests. I have code similar to the following:

import { reducer as auth } from './auth';

function api(state) {
    const { auth } = state;
    ...
}

In this version I get the following error "auth" is read-only on line 4.

This worked fine in previous versions.

[kelset]

@BrendonSled can you open an issue for it & post the link here?

[BrendonSled]

@kelset https://github.com/facebook/react-native/issues/26258

[xzilja]

I believe I found an issue when Archiving iOS build https://github.com/facebook/react-native/issues/26259

There is a cli step that throws error: ios is invalid target?

Not sure if this is an issue, but there are 2 cli paths present in that error output: /node_modules/react-native/cli.js and /node_modules/@react-native-community/cli

[gaearon]

Redbox is broken: https://github.com/facebook/react-native/issues/26260. This is a release blocker. Don't have a fix yet.

[gaearon]

Once D17139310 and D17140543 land, we need to cherry pick them.

[sebqq]

This would be super nice to cherry pick facebook/react-native@51aacd5

[gaearon]

@grabbou

Please pick:

• https://github.com/facebook/react-native/commit/f107d3b78c95ed0313b39e55976cf6b6be36775e
• https://github.com/facebook/react-native/commit/42a385bddf895be5b00dd30f82396f0d8197cfc1

Thank you.

[owinter86]

Not sure if this is directly related to @TheSavior comment about the TouchableNativeFeedback issue.

This commit which I believe is included in 0.61 made a breaking change to TouchableNativeFeedback and the revert will need to get picked once it lands. I'm leaving on vacation today before RN.EU and might not be able to flag the actual commit.

But this release has caused some unusual behaviour when using TouchableNativeFeedback.SelectableBackgroundBorderless()

https://github.com/facebook/react-native/issues/26289

[TheSavior]

Here is a link to the TouchableNativeFeedback revert commit: https://github.com/facebook/react-native/commit/c526b3ff14c245ad6c853632c945e61c02eecffe

@owinter86, I’m not sure if that is related. I’d be surprised if it was, but I’m not sure anything else has touched the component than my commit, so maybe it is. :-) I’ll investigate when I try to reland my change.

[jamsch]

Looks like https://github.com/facebook/react-native/issues/26241 was introduced in the RC. Haven't tried iOS yet.

[estevaolucas]

Please pick https://github.com/facebook/react-native/commit/82a8080f0704e83079d0429e4e367f5131052e64 and https://github.com/facebook/react-native/commit/a58dd9683da6135bca119a8b0ae5d0ea5382cf4c.

Those commits will allow Flipper's Layout plugin to be used on iOS projects.

(more about it here: https://github.com/facebook/react-native/pull/26053 cc @janicduplessis @axe-fb)

[grabbou]

React Native 0.61.0-rc.2 is now on CircleCI and should hit npm soon.

@sinodko, unfortunately, it sounds like your cherry-pick request is a feature request, rather than a bug fix. We have decided to not cherry-pick it yet.

[tlupo]

I’m not sure if it’s still possible but it would be great to include facebook/react-native@88e18b6 (by @janicduplessis) to fix blob memory leak on Android (https://github.com/react-native-community/releases/issues/130#issuecomment-511917694). Thank you very much !

[fkgozali]

https://github.com/facebook/react-native/commit/241091d527ae7e1866c3f9bdf067cde146e377fa fixes iOS test with use_frameworks, would be good to pick to keep 0.61 RC branch green.

[mickmaccallum]

Please consider facebook/react-native@c9708fb9c4c8262b93b0f32755b1d5966808de4b and facebook/react-native@7f3a0e831c5953cacbd65d731d62747e07d8cf85 for the next RC. These fix building with use_frameworks! without requiring third party libraries to add s.static_framework = true to their Podspecs.

See PR with more information here: https://github.com/facebook/react-native/pull/26151

[gabrielfurini]

Hey guys, I was struggling with the same issue as on https://github.com/facebook/react-native/pull/26360. Machines with case sensitive disks are not able to find the podspec file for Yoga. Please consider merging it too.

[estevaolucas]

What about those other commits to make 0.61.0 and its template to support Flipper (including on RNTester):

• https://github.com/facebook/react-native/commit/0165489b8fc29423dfde958d23103e28cb523240
• https://github.com/facebook/react-native/commit/0a5c43fcc37640e1568f2d04563d232db2f532d8
• https://github.com/facebook/react-native/commit/70274f4e9166dbe9da2d04953a95c2909b455d1d
• https://github.com/facebook/react-native/commit/755ad3b33a40bfb901d8b943c46c429433945713
• https://github.com/facebook/react-native/commit/adac04601ec36d35eca42532ec824c5790dc71ed

[grabbou]

Going to cherry-pick commits and release a new version today. Thanks @gabrielfurini reporting that - I guess my Mac is case-insensitive then, since we were able to run it w/o problems while testing.

[MoOx]

@grabbou this very tiny (but important) fix in the flowconfig of the template would be nice to have https://github.com/facebook/react-native/commit/e6b2cf04188fc9647bae4bef4cca5d4dde22a657

[hassanbazzi]

Going to cherry-pick commits and release a new version today. Thanks @gabrielfurini reporting that - I guess my Mac is case-insensitive then, since we were able to run it w/o problems while testing.

I was gonna walk up to you in the callstack conf and office and tell you about this. haha. Let me know if you need help testing at all. I assume you had a loooooooooong week at the conf.

[grabbou]

@0x7fs I have cherry-picked these commits that fall under this PR. @fkgozali, this is exactly what you have discussed within the PR comments. Hopefully, static_framework's work without issues now.

@tlupo, please consider checking the commit you are pointing to whether it's already part of the release you are commenting on. Not really a deal-breaker, but Github UI shows this information right below the description of the commit and would save me a few minutes while doing this cherry-picking process. I hope that information helps while testing!

@estevaolucas, I am double-checking with Facebook whether releasing this under 0.61 is okay. Few people mentioned it being part of 0.62, so want to make sure we don't conflict in this process. Will report back and if that's not the case, will release another RC the day after.

@hassanbazzi, thank you! we're just getting started after the conference! The best way to help would be to install the RC and try to upgrade your project and tell us whether it's causing any major issues

[grabbou]

Update: all commits are already on the CI and I am testing it right now. The release should be out there in a bit. I will be back with the updates after I finish another round of the meetings.

[grabbou]

Update: 0.61.0-rc.3 is now on the CI and should be up on npm in a few minutes.

We will get back to Flipper in a matter of a few days, waiting for a response.

[a-c-sreedhar-reddy]

But ubuntu users cant user Flipper right?

[fkgozali]

I am double-checking with Facebook whether releasing this under 0.61 is okay. Few people mentioned it being part of 0.62, so want to make sure we don't conflict in this process. Will report back and if that's not the case, will release another RC the day after.

We chatted about this briefly. I think we should let 0.62 have the support naturally instead of picking to 0.61. This is aligned with what @grabbou mentioned up top:

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.x cut.

Picking Flipper support (more of a new feature) could delay the 0.61 RC stabilization and potentially more work for everyone here to fix the potential issues forward in the RC itself.

[axemclion]

@a-c-sreedhar-reddy - yes, Flipper does not current seem to have a build for Linux, but Flipper is an electron app, and is Open source. Would you be interested in adding linux builds ?

[Jarred-Sumner]

After upgrading from 0.60.5 to 0.61.0-rc.3, I am running into this error:

[fatal][tid:com.facebook.react.ExceptionsManagerQueue] Unhandled JS Exception: TypeError: hmrClient.send is not a function. (In 'hmrClient.send(JSON.stringify({
        type: 'log-opt-in'
      }))', 'hmrClient.send' is undefined)

I have updated my Podfile to rename these two pods: (they were React-RCTWebSocket and React-DevSupport before I think)

pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'

Is anyone else seeing this?

Adding a debugger here shows that hmrClient is defined but hmrClient.send is not a function (as the error says)

now I'm looking through where send should be defined and I will update this comment when I see it

Here: https://github.com/facebook/metro/blob/e675dc2104b6abc6c7bd6802865c4f9496edb913/packages/metro/src/lib/bundle-modules/HMRClient.js#L103

---

Solution: Upgrade metro to 0.56.0.

To do that, I ran:

yarn add metro@0.56.0

[a-c-sreedhar-reddy]

@axemclion I created PR updating docs regarding building for linux from source. Where can I add linux builds?

[gedeagas]

Hi guys, how about this commit ? https://github.com/facebook/react-native/commit/3915c0fa6178fbb8aa9b8bd54881cfdbde8fde70 this commit fix custom fontWeight numeric values for Text on Android

[kelset]

@gedeagas, as @grabbou mentioned above, you can check if a commit is already in a release in its page.

The one you are linking, in particular, seem to be already in:

[gedeagas]

ah... so sorry about that @kelset. i am not paying attention to the tagging. Thank you so much.

[jrwpatterson]

Any idea when this is going to go live... (I know all time scales are flexible) We just have something that for the life of me will not work in RN60 but works perfectly first time in RN61 and my managers want it stable (and I want to stop working on getting it to work on 60 that I'm fairly convinced at this stage isn't going to work!)

[gabrielfurini]

@grabbou, I was still not able to run a project in my machine with a case-sensitive disk in rc.3 due some Yoga misspelled imports. I've changed some files and now it's building properly. Not sure if it helps, but I've opened a PR too: https://github.com/facebook/react-native/pull/26416

[pierricklete]

here is an issue with 0.61.0-rc.3 when using use_frameworks!: https://github.com/facebook/react-native/issues/26333

[jrwpatterson]

anybody able to help me since upgrading to RN61 when I try to mock native modules in this way...

jest.mock('Alert', () => ({ alert: jest.fn() }))

it just tells me

Cannot find module 'Alert' from '.tsx'

I haven't changed the code...