0.61.1 Discussion

[grabbou]

Conversations on this thread are limited to 0.61 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.61.1 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

[radeno]

Somehow there is included incorrect React version (16.8.1) https://react-native-community.github.io/upgrade-helper/?from=0.61.0&to=0.61.1 Looks like master branch is unsynced also: https://github.com/facebook/react-native/blob/master/template/package.json

[Bardiamist]

@radeno that upgrade-helper's problem. Because the project created by react native init have react@16.9.0.

[talut]

I'm trying Fast Refresh right now but an error occurring every time: https://github.com/facebook/react-native/issues/26557

[mjmasn]

Heads up if you're thinking of upgrading - there's an elevation rendering bug on Android in 0.61.0+ when using TouchableNativeFeedback.SelectableBackgroundBorderless() on the same screen as the elevated element.

https://github.com/facebook/react-native/issues/26289

[lucasbento]

@radeno @Bardiamist: changes shown on upgrade-helper are correct now, you can check them here.

[pvinis]

https://github.com/facebook/react-native/pull/26566

I created this to bring back the workspace too.

[lafiosca]

I'm also seeing some funky visual behaviors with Android which might be directly related to @mjmasn's issue referenced above, but I don't know enough about them to say for sure. These behaviors only occur for me on a physical Android device, not in the emulator.

Edited to move bulk of this comment into issue facebook/react-native#26574 per @kelset

For now though, I think I am going to have to revert to 0.60 until these changes are reconciled.

[kelset]

if this would be better opened as a separate issue

if would be ideal to have an open issue on this in the main repo, and only the link referenced here. Thanks!

[ScreamZ]

@grabbou Serious Issue with background and superposition on Android :

https://github.com/facebook/react-native/issues/26544#issuecomment-535091158 Also linked to https://github.com/styled-components/css-to-react-native/issues/117

[xzilja]

When using hooks there seems to be an issue with AppState listeners

useEffect(() => {
    AppState.addEventListener('change', handleStateChange);

    return () => {
      AppState.removeEventListener('change', handleStateChange);
    };
  }, [dynamicValue]);

This now returns

Illegal callback invocation from native module. This callback type only permits a single invocation from native code.

Code wasn't changed on my end, if anyone can think of any commit that could have caused this, I'll be glad to dig in. Also let me know if I should open issue in rn repo for this instead.

[vshab]

Please cherry-pick https://github.com/facebook/react-native/commit/0a282c42b4d1c2316513cd5588a0a92b54db2991

This fixes FlatList in inverted mode on Android doesn't invert pull-to-refresh gesture which is essential for chat-like screens.

[felippepuhle]

Please cherry-pick https://github.com/facebook/react-native/commit/0cafa0f5d1e7fa5369b765f4b97f38bf1608230a

[grabbou]

@ScreamZ aware of that and I am investigating the status of this issue. My goal is to release the next minor release with a fix for this.

[ScreamZ]

@grabbou Awesome thanks :)

[vonovak]

https://github.com/facebook/react-native/commit/113c4e229c374232c46a89afd74df7117a3447c1 is not a bugfix but an improvement of an error message that might help people who are upgrading from 0.59. It might save both consumers and library maintainers some extra work.

[grabbou]

After two hours of playing around with it, I have managed to find out that the issue is caused by https://github.com/facebook/react-native/commit/14b455f69a30d128db384749347f41b03b9a6000

I can confirm it renders "just fine" when this commit is reverted. I will now reach out to the authors and other maintainers to see if we can quickly fix the issue or we should revert the commit. Your help is welcome!

I have found the root cause by performing a binary search for a commit that introduced the regression. I think it's a cool approach to debugging, so let me share this with you while we are at it. Update: You want git-bisect as pointed out by @tido64, thanks!

[tido64]

@grabbou: Git actually has this built in. Have a look at git-bisect 😉

[grabbou]

We will be reverting facebook/react-native@14b455f and doing another release today tomorrow (see for more). I will send appropriate PRs in a second.

[ScreamZ]

Champaign great job people

[BipinBhandari]

any update on the release?

[kristerkari]

Would be nice if this iOS13 "image inside text" rendering issue could be fixed and released as a patch for both 0.60 and 0.61: https://github.com/facebook/react-native/issues/26577

[grabbou]

Unfortunately, there was a React Native-wide permission issue which didn't let me push any commit upstream, making it impossible to make a release.

Apologies for those who have been waiting for a release, the issue is now fixed, PRs are being submitted, the release will be out in a matter of hours.

I will keep you updated.

[owinter86]

Can we get https://github.com/facebook/react-native/commit/796b3a1f8823c87c9a066ea9c51244710dc0b9b5 picked, this fixes the statusBar issues with iOS dark mode support, fixes issue https://github.com/facebook/react-native/issues/26619#issuecomment-536813690.

[grabbou]

All commits cherry-picked. Testing them now.

@kristerkari, as pointed out in the first comment in this issue - please point to commits, rather than issues. I do understand this may be causing you and many other people issues, but unless it's a regression, there's nothing we can do here without further debugging.

[grabbou]

Let's continue in #148. The release will be out on npm shortly.

[kristerkari]

as pointed out in the first comment in this issue - please point to commits, rather than issues.

Sorry about that @grabbou . It's just that there is no place where to report bugs that would need a fix + be included in a patch release. The bug reports in facebook/react-native get easily lost with people opening new issues all the time.

[grabbou]

It's all right! I just wanted to explain the fact there's nothing I can do about it "right now". Hoping it can be fixed in the nearest future