search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 404 forks source link

0.56.x Discussion #14

Closed grabbou closed 6 years ago

grabbou commented 6 years ago

Please report any major issues and commits to cherry-pick in this thread for discussion.

grabbou commented 6 years ago

Unlocked this thread as by definition, this one is meant to be the place where the community can suggest cherry-picks and notify us of the issues with the release.

Please keep in mind that all discussions not related to releasing the new version should be held in the react-native repository.

grabbou commented 6 years ago

Not sure about the first commit - it's not something critical or needed for the release (like React) update.

I cherry-picked two last commits and scheduled next release. Will update the other issue when the status is green.

EdwardDrapkin commented 6 years ago

There are a couple PRs opened in this thread, can it get looked into for this release? https://github.com/facebook/react-native/issues/18272

hramos commented 6 years ago

@EdwardDrapkin please keep the thread on topic. We're only cherry-picking commits that are already on master.

MarkOSullivan94 commented 6 years ago

@hramos is there an easy way to check what commits are in master but not latest 0.56.x release?

stianjensen commented 6 years ago

This shows all commits between the latest 0.56.x tag and master. You can find it by clicking on Releases, then the latest tag and "{x} commits to master since this tag"

https://github.com/facebook/react-native/compare/v0.56.0-rc.3...master

vonovak commented 6 years ago

can we get this small android permissions fix? https://github.com/facebook/react-native/commit/4e1abdd74dc4127a86d62e7750d01d39bb781c08

kelset commented 6 years ago

Since we are trying to support API 26 for Android in this release, I think we should cherry pick these two too:

MarkOSullivan94 commented 6 years ago

Couple of commits I'd like to see added

grabbou commented 6 years ago

Going to review the suggested cherry-picks today and will be releasing next release candidate tomorrow. That is most likely going to be one of the last RCs in preparations for the next month release candidate.

eshikerya commented 6 years ago

Does it mean the issue #19827 will go to production?

kelset commented 6 years ago

@eshikerya

one of the last RCs in preparations for the next month release

doesn't mean "will go in production". We hope that by the time 0.56.0 will be released a fix for that issue will have been found and merged.

eshikerya commented 6 years ago

got it. thank you

gastonmorixe commented 6 years ago

+1 Can't wait for #19827 to be fixed. Blocked by it since depending on babel 7.

hramos commented 6 years ago

Thanks @grabbou for cherry picking all of these. 0.56 is scheduled to hit stable next Monday (first business day in July). After this last RC is cut, I think we should focus our attention on release-blocking issues such as #19827. Please cc me on any PR that attempts to fix #19827.

grabbou commented 6 years ago

Sure, that sounds like a good idea.

On Tue, 26 Jun 2018 at 20:05 Héctor Ramos notifications@github.com wrote:

Thanks @grabbou https://github.com/grabbou for cherry picking all of these. 0.56 is scheduled to hit stable next Monday (first business day in July). After this last RC is cut, I think we should focus our attention on release-blocking issues such as #19827. Please cc me on any PR that attempts to fix #19827.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/react-native-community/react-native-releases/issues/14#issuecomment-400409603, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWcxnjAx_mp1UAf3xNaI21FZPvpqiddks5uAnfSgaJpZM4TFPgN .

gnprice commented 6 years ago

EXTRA: I think we should try to get this merged and cherry picked: facebook/react-native#19645

After some deeper debugging of the issue today, that's now a simple one-line bugfix, where the original was a revert of a previous commit that added a feature. So hopefully that now makes it easy to include!

dulmandakh commented 6 years ago

please cherry-pick https://github.com/facebook/react-native/commit/77a02c0d83dbfcd9a5397cf63e1ab2e6c94cfdde, so we can remove ReactFragmentActivity and do some code cleanup in 0.57.

kelset commented 6 years ago

Looks like we are getting really close to a stable release in time for the deadline :)

Aside from the commit proposed by @dulmandakh (that deserves mad props for all the PRs he submitted in order to improve the Android support!) I think we would need a couple more:

And I guess we need to keep an eye on #19827 hoping a fix is found soon.

hramos commented 6 years ago

Note to whoever cherry picks these, when adding https://github.com/facebook/react-native/commit/5017b86b525e3ef6023f0f8a88e6fd1cf98024e0 to the changelog, please use the updated description (see my comment there).

dulmandakh commented 6 years ago

Fix for FlatList with ListHeaderComponent https://github.com/facebook/react-native/commit/dbc23466b3ec63453ca57e6e24e1efd23c104b8f

ikesyo commented 6 years ago

I want https://github.com/facebook/react-native/commit/75a0273de21948b0b959263100f09111f738ec35 to be cherry-picked.

futuun commented 6 years ago

those 3 commits are fixing issues with Xcode 10, would be nice to have them: https://github.com/facebook/react-native/commit/75a0273de21948b0b959263100f09111f738ec35 (for fishhook import) https://github.com/facebook/react-native/commit/e131fffb37a545363daf11735a0243165b57f63f (for missing config.h in glog) https://github.com/facebook/react-native/commit/a1302392577789faab79dad0cb39b147464e0e42 (for opening invalid simulator (or no simulator at all if you have only xcode beta))

kelset commented 6 years ago

👋 everyone, sorry for keeping you wait; quick update regarding 0.56.0.

Since there are still a couple of open issues related to rc versions that may be "important" issues we are running some more tests updates on real world apps to make sure that it is possible to update to rc.4 and build both iOS/Android and Debug/Release.

Once we made sure that there are positive outcomes, we will release 0.56.0 with prob an extra line or two in both the changelog and the blogpost (that will be published after the npm publish) regarding these issues, in order to hopefully "increase the surface" of developers using the new version and eventually lead to a faster solution for them in 0.56.1.

SudoPlz commented 6 years ago

@kelset Any rough ETA ?? (are we hours, days or weeks away from release?)

kelset commented 6 years ago

Hopefully hours. I've tested tested with 3 different repos(debug/release, ios/Android), and the update worked on all these 3 scenarios :

and submitted a couple of PRs. Now other devs in the core will review and approve/discuss and hopefully we can release 0.56.0.

Sadly it won't be as perfect as we'd like, but we need to keep moving forward IMHO.

rozele commented 6 years ago

Can we cherry-pick https://github.com/facebook/react-native/commit/54942746d4037e1153e14fcfc95e4edc772d296a to allow react-native-windows to work with 0.56?

hramos commented 6 years ago

All of the cherry-picks requested above have been added to the 0.56-stable branch and should be released as part of 0.56.0-rc.5. This is the final RC and no further commits will be cherry-picked unless a regression was introduced between rc.4 and rc.5 - we need to promote to stable at some point so we can get moving along.

hramos commented 6 years ago

react-native@0.56.0-rc.5 is out, @rozele, @futuun, @ikesyo, @gnprice, @dulmandakh please take a look and let us know if we can promote rc.5 to become the final, stable 0.56 release 🚀🎉

dulmandakh commented 6 years ago

Upgraded 2 projects from 0.55.4 to 0.56.0-rc.5 just fine. On iOS, got React Native version mismatch error and had to open XCode, then run Product -> Clean to fix it. On Android, resolved few conflicts due to changes in gradle files.

lebedev commented 6 years ago

@dulmandakh How did you upgrade, btw? With react-native-git-upgrade? Or just by specifying newer version in package.json?

dulmandakh commented 6 years ago

@angly-cat react-native-git-upgrade next

kelset commented 6 years ago

0.56.0 has been released

Any future conversation on this thread will be limited to backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.56.0 cut. For new features that you would like to see implemented, refer to https://github.com/react-native-community/react-native-releases/issues/34

If you cannot point to a particular commit on master, then your "bug fix request" likely belongs as a new issue in http://github.com/facebook/react-native/issues.

kelset commented 6 years ago

For 0.56.1 we should aim (IMHO) to release as soon as this is fixed fully: https://github.com/facebook/react-native/issues/19953 (and https://github.com/facebook/metro/issues/181)

Currently it seems that a fix has been merged in master: https://github.com/facebook/react-native/commit/3ac86c366c91f8d62f0128057019b94a783b4249

but there has been a report that is actually still not fixed (sadly). So prob cherry picking that is a start but something else will be required.

janicduplessis commented 6 years ago

Would be nice to include https://github.com/facebook/react-native/commit/b4b594cec1d91c38faac11a90a787ae692e35296 if we do a patch release, it fixes a regression with TextInput.State.currentlyFocusedField.

hramos commented 6 years ago

It looks like that commit can be applied cleanly on top of 0.56. If you have push access, you can try cherry-picking it onto 0.56-stable and running the bump-version script to tag a new patch release.

grabbou commented 6 years ago

Just did that before we make 0.57 stable (for some reason it doesn't work properly when we release a patch to non-latest release).

Anyway, impressed we didn't have much to cherry-pick and release since then.

grabbou commented 6 years ago

Closing as 0.57.0 has just hit npm. No future cherry-picks will be accepted unless a security/critical issue arises in the meantime.