search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 405 forks source link

0.62.x RC Discussion #157

Closed kelset closed 4 years ago

kelset commented 4 years ago

EDIT by @alloy:

The current version is v0.62.0-rc.5 and appears to be the golden one ✨

TODOs:

jan-happy commented 4 years ago

Is this a bug? Or is Animated.Text.propTypes.style deprecated? TypeError: undefined is not an object (evaluating '_reactNative.Animated.Text.propTypes.style') Example project: RN062-undefined-style-propType.zip

elicwhite commented 4 years ago

Thanks @alloy for shipping RC4!

Looking at the upgrade-helper for 61.5 to RC4,

elicwhite commented 4 years ago

@jan-happy, that was intentionally removed in this commit: https://github.com/facebook/react-native/commit/86d90c03ebe39ebc4b2c6dcc0747b4f3a34f5f2f#diff-bba74f532799108778119f8c45105443

React Native is moving away from PropTypes. We recommend using TypeScript or Flow instead. To unblock yourself, use Text.propTypes.style, not Animated's Text.propTypes.style. That API will still exist for a few more releases.

pvinis commented 4 years ago

The gradlew file is again changed the line endings.

The xcode stuff I made some screenshots and guide on how to change them based on rc3. I haven't uploaded yet but it I'll do it probably Sunday.

alloy commented 4 years ago

I was able to pick all the Hermes fixes, plus other fixes that have landed in master, and published v0.62.0-rc.4 🎉 This may be the one, friends! 🤞

Alas, there were those that didn’t make the cut:

alloy commented 4 years ago

Turns out that https://github.com/facebook/react-native/commit/233fdfc014bb4b919c7624c90e5dac614479076f introduced a regression that already had been fixed in master with https://github.com/facebook/react-native/commit/26d5faf379c6fc13678f697ec22c1cc6e96a949d. I’ve picked that as well and immediately released v0.62.0-rc.5 so nobody wastes time testing and/or reporting.

bmbmjmdm commented 4 years ago

Hi alloy, has https://github.com/facebook/react-native/issues/28163 been solved in v0.62.0-rc.5?

darkbasic commented 4 years ago

It still insta-crashes on the emulator (with Android R), but it works for me on my real device.

bmbmjmdm commented 4 years ago

Thats good enough for me! I'll try it tonight

hsjoberg commented 4 years ago

Also getting release version instacrashes, Hermes or JSC doesn't matter. On emulated and device

bmbmjmdm commented 4 years ago

hsjoberg, is this with the newest version (v0.62.0-rc.5)?

hsjoberg commented 4 years ago

@bmbmjmdm Yes, not working on v0.62.0-rc.5.

darkbasic commented 4 years ago

Which version of Android? My working device has version 9.

owinter86 commented 4 years ago

For those having issues with android builds or experiencing crashes, it its worth invalidating caches in android studio, this solved these issues I was having, so it may (or may not) also help others.

owinter86 commented 4 years ago

Given 0.62 will be targeting Hermes engine 4.0.0, is there a way we can test or include the -Xes6-proxy flag, as I believe only a patch is required in the RN package? Or is this going to be part of the next release cycle?

https://github.com/facebook/hermes/releases/tag/v0.4.0

kelset commented 4 years ago

@darkbasic @hsjoberg can you please move the conversation about Android crashes in the dedicated issue @bmbmjmdm created for it -> https://github.com/facebook/react-native/issues/28163

It helps keeping this issue on track.

@owinter86 could you please post a detailed description of your solution

For those having issues with android builds or experiencing crashes, it its worth invalidating caches in android studio, this solved these issues I was having, so it may (or may not) also help others.

in the issue too? So that we can keep it all in the same place (atm my brain can't remember how to invalidate Android Studio's cache btw 😓)

mxmzb commented 4 years ago

in the issue too? So that we can keep it all in the same place (atm my brain can't remember how to invalidate Android Studio's cache btw 😓)

Delete all .iml files in ./android and ./android/app and the ./android/.idea directory. Then start Android Studio and it will treat it like a fresh project.

hsjoberg commented 4 years ago

From Android Studio File-menu, you also have Invalidate Caches / Restart...).

Image
hsjoberg commented 4 years ago

Release build of Hermes + ProGuard crashes on 0.62.0-rc.5. This is not related to the crash above.

About to load: libhermes.so
libhermes.so not found on /data/data/com.rn062/lib-main
libhermes.so found on /data/app/com.rn062-Fjs_ZyNxAT33Mc4PFvqS7Q==/lib/x86
Not resolving dependencies for libhermes.so

I can replicate this on the crna-template project;

  1. Create a new project npx react-native init RN062 --version 0.62.0-rc.5
  2. Enable Hermes and ProGuard in android/app/build.gradle
  3. Add Hermes exception in android/app/proguard-rules.pro: -keep class com.facebook.hermes.unicode.** { *; }.
  4. Run npx react-native run-android --variant release. The app will instacrash.
kelset commented 4 years ago

@hsjoberg can you please move that report for Hermes + ProGuard to a dedicated issue in the main repo and only put the link in the comments here instead?

hsjoberg commented 4 years ago

@kelset Sure thing. https://github.com/facebook/react-native/issues/28270

EDIT by @alloy: This is regarding an Android+ProGuard crash.

alloy commented 4 years ago

@owinter86 Re Hermes Proxy support, this is what I was told:

We aren't comfortable enabling Proxy right now as it will change the behavior of plugins which optionally use it, and that needs more testing. We plan to publish instructions for how to enable Proxy in 0.62+0.4.0, so people can test mobx, immer, etc, but this will happen outside the release.

In short, this is out of scope for this release.

eugene-nefedov commented 4 years ago

Hi. Is https://github.com/facebook/react-native/issues/25927 included in 0.62.0-rc.5?

kelset commented 4 years ago

@eugene-nefedov the link you posted doesn't lead do a PR or a cherry-pick so there's nothing that is per-se "included" in the RC about it. If there are some repro steps in that issue maybe try init'ing a fresh react native project in RC5 and see if it still happens & report in the issue the result of your testing?

pvinis commented 4 years ago

I saw that rc.5 fixed the gradle.bat file again, which is great. To make sure this doesn't happen again, I made https://github.com/facebook/react-native/pull/28274. If we end up making another rc, let's throw that in too. If we don't then it's totally fine to be just in master.

elicwhite commented 4 years ago

@alloy can you share an update on the current status? Are there currently issues we are waiting to get resolved? Are we just giving RC5 a couple days to soak? What else is blocking this from going stable that you know of (the changelog is one example).

Sixzero commented 4 years ago

We tried 0.62.0-rc.5 both on Android and iOS and our experience was:

As for iOS react-native-firebase and flipper causes duplicate symbol conflicts, which I think will be addressed soon, since I think a lots of project uses firebase. Already there was an issue about this problem on stackoverflow from 2019 july, which talks about the problem.

As for Android the new 6.0.1-all gradle causes an issue in the react-native-ble-plx library, since it uses "groovy" in their Android codes.

Apart from these 2 bugs(as for us) the upgrade went smooth and fast. Great work, keep it up!

P.s still haven't created issues about the two issues in their specific repos.

elicwhite commented 4 years ago

It would be very helpful to have issues for those that we can keep an eye on.

alloy commented 4 years ago

@alloy can you share an update on the current status? Are there currently issues we are waiting to get resolved? Are we just giving RC5 a couple days to soak? What else is blocking this from going stable that you know of (the changelog is one example).

@TheSavior Initially I was keeping an eye on those Android crashes, but by now it seems like those are addressable outside of any release changes. So now it was only a matter of letting it soak a bit more.

Work we need done to finalise the release are:

So perhaps we can aim for a stable release (not RC) by Monday?

@grabbou @kelset Are you available then to assist me?

SaeedZhiany commented 4 years ago

So perhaps we can aim for a release by Monday?

@alloy do you mean a stable release (not RC)?

alloy commented 4 years ago

@SaeedZhiany Yes 👍 I’ll update my comment to reflect that and then hide out comments to keep things tidy.

bmbmjmdm commented 4 years ago

@alloy not sure what you mean about the Android crashes being addressable. I still can't get a successful release launch (though as I said in my thread I still need to try on rc-5)

alloy commented 4 years ago

@bmbmjmdm From what limited judging I can do at this time, your issue seems like it may be an issue we can solve in user-land (see my comment on your issue https://github.com/facebook/react-native/issues/28163#issuecomment-597563008) and is currently not being reported by others. If it turns out to be an issue that needs fixing in RN after all, then we can release a fix in a subsequent patch release. For now, my personal opinion is that we should get this long overdue release out and then iterate faster in the future.

elicwhite commented 4 years ago

Do these flipper commits need to get picked? https://github.com/facebook/react-native/commit/db12255645204541b102300feaf3e640411a4596 https://github.com/facebook/react-native/commit/85a4b0f5bda71470a8323596ed5422982f4c7a03

mweststrate commented 4 years ago

@TheSavior preferably yes, otherwise people will have to bump manually if they want to use all features of the integration.

passy commented 4 years ago

The Android changes are optional-ish. The iOS fix includes the lowering of the SDK min version back to 9. Ultimately, it's probably better to keep the two in sync, though.

elicwhite commented 4 years ago

We just got an internal report about long press inconsistently firing on the touchables due to a refactor of the internal state machine that landed in 0.62 in a stack of commits starting with https://github.com/facebook/react-native/commit/ebf7d758164873169937321a4dccc3782359a0d3

@yungsters is able to repro and will investigate a fix tomorrow. I wanted to flag here as a known problem with 0.62 right now.

elicwhite commented 4 years ago

Long press fix landed here: https://github.com/facebook/react-native/commit/5ca1d8f260bfb64111a6ba39f76a0a935829c0f2.

We haven’t soaked this fix internally yet, we’ll let you know if we hear any additional issues from our internal users from this.

FWIW, I think this issue is a pretty minor edge case as we had been running with this bug in production for at least 6 months and hadn’t heard it surfaced until now.

sebqq commented 4 years ago

What is the status please?

kelset commented 4 years ago

Hey folks - given how the situation of CoVid-19 is spreading through the world, we are discussing if it's a sensible thing to proceed with 0.62.0 this week.

It's likely that we will still proceed but no ultimate decision out atm. We will keep you updated - we are just as eager as you to finally have it out in the wild, but we need to be considerate towards everyone and this new balance that is shaping up all over the world 🤗💗

dentuzhik commented 4 years ago

@kelset hopefully you guys are going to work this out 🙌 IMO there's certainly little need to rush out releases like this given what's happening around

robertying commented 4 years ago

Is there a plan to solve the increased apk size caused by gradle version bump? Or should we just stick to the workaround as https://github.com/react-native-community/releases/issues/157#issuecomment-593103576 suggested for the time being?

Thanks!

alloy commented 4 years ago

@robertying Afaik there’s no progress on that atm, so expect to use the workaround for the time being. Having said that, it doesn’t seem like there’s a ticket tracking this issue, at least I haven’t seen it mentioned, so perhaps you could create one that combines @willholen’s and @ArrayZoneYour’s comments.

robertying commented 4 years ago

I'll link the issue here.

Android APK size increases after Gradle version bump: https://github.com/facebook/react-native/issues/28330

kelset commented 4 years ago

(just FYI @alloy updated the top post of this issue with the checklist of things we are working on for 0.62.0)

grabbou commented 4 years ago

As discussed with @alloy, jumping on the commits to do the cherry-picks. Will report with the update.

nonewcode commented 4 years ago

Is a 0.62 release still being planned for the next couple of days?

kelset commented 4 years ago

@codecog if you check the original post at the top, you'll see that the checklist is not yet complete. At the moment we are focusing on completing those tasks, once they will be done we will be able to proceed.

As mentioned, just like everyone else all around the world, the CoVid-19 situation is also affecting the amount of time the developers involved in this phase are able to dedicate to the process. We will communicate once the release is going to be out... when it's going to be ready. No deadlines nor fixed dates atm - please be patient 💕

nonewcode commented 4 years ago

@kelset anything i can help with to get us there faster?

SergioEstevao commented 4 years ago

@kelset and @alloy do you think we can have this PR: https://github.com/facebook/react-native/pull/28332 cherry-picked for the release?