search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 407 forks source link

Document current release process #165

Closed alloy closed 4 years ago

alloy commented 4 years ago

To be clear, this iteration is meant to document the current process. Next iterations will:

TheSavior commented 4 years ago

What's the plan for this PR? It seems like this would be unlikely to be complete. Does it make sense to merge these as is and then iterate as you learn more things about the process? That way it will also be easier for people to review the new things you learn.

kelset commented 4 years ago

Does it make sense to merge these as is and then iterate as you learn more things about the process?

I don't think we should merge as it is, as the Readme still requires a bit of work/changes.

That said I agree that maybe it could be good to find a way to reduce its scope and increate the docs in follow up PRs (ex. maybe the upgrade-helper part could be its own PR?)

alloy commented 4 years ago

Agreed with @kelset; I’ll do a bit more work and leave docs on parts of the process outside of direct releasing for follow-up.

alloy commented 4 years ago

Alright, this should be ready to go 👍

alloy commented 4 years ago

Done 🙆‍♂

TheSavior commented 4 years ago

It's not pointless! Changes can be made in a follow up! :D

alloy commented 4 years ago

Hey, yeah, please do leave all the feedback!

And sorry for the ambiguity in when/who would merge, I’ll make sure to improve that next time.

TheSavior commented 4 years ago

For us at Facebook, typically once I get an approval, I address that feedback and merge. Iterating and making additional changes is easy and I prefer not to block people from making progress. That works as long as everyone feels comfortable giving feedback at any time, even on merged changes, trusting that they will still get addressed. 🙂

It is reasonable if you all would prefer a different style here. 👍

alloy commented 4 years ago

@kelset https://github.com/react-native-community/releases/pull/171