search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 405 forks source link

New 0.62.0 changelog #166

Closed kelset closed 4 years ago

kelset commented 4 years ago

Allright, this is the new version of https://github.com/react-native-community/releases/pull/156 that uses the new improved script (thanks @alloy!).

As we can clearly see, now the number of changes is quite more massive than the one we saw in the previous one... which means that in the ballpack number of 1.2k commits around 60-ish percent are not FB internals.

But there are still quite a big number of "unknowns" to put in the right place... I don't have time to do it atm but I'm starting to open this as a draft PR.

RELEVANT LOGS from the command:

Unable to find differential revisions for the following commits. If these were made on the release branch only, be sure to update the CHANGELOG entries to point to the commit on the master branch after back-porting.
    https://github.com/facebook/react-native/commit/be5088401fd8e19d57adda42d275cab437448064
    https://github.com/facebook/react-native/commit/26e7d6a06211412a079af746750c5dd9edbfecbb
    https://github.com/facebook/react-native/commit/cef001713fc6384353bbcb4d45645ceee44ed1a9
    https://github.com/facebook/react-native/commit/99ef72cad73da25d76bf8177272724cfe6cece61
    https://github.com/facebook/react-native/commit/55276a9b104781b49b66938d71aac385bdd236e5

and 

Unable to find differential revisions for the following commits. If these were made on the release branch only, be sure to update the CHANGELOG entries to point to the commit on the master branch after back-porting.
    https://github.com/facebook/react-native/commit/be5088401fd8e19d57adda42d275cab437448064
    https://github.com/facebook/react-native/commit/26e7d6a06211412a079af746750c5dd9edbfecbb
    https://github.com/facebook/react-native/commit/cef001713fc6384353bbcb4d45645ceee44ed1a9
    https://github.com/facebook/react-native/commit/99ef72cad73da25d76bf8177272724cfe6cece61
    https://github.com/facebook/react-native/commit/55276a9b104781b49b66938d71aac385bdd236e5
jeremy-deutsch commented 4 years ago

I'd like to help sort the "unknowns". @kelset, would it be possible for you to give someone trusted (like @alloy) edit access to this branch/PR, so that you don't have to be the only person who approves suggestions/moves around the "unknowns"?

elicwhite commented 4 years ago

Can we get the unknown ones grouped by user? Almost all of those are Facebook employees, so we can just ask them to write the changelog for those commits.

jeremy-deutsch commented 4 years ago

It looks like GitHub's having some issues (note the quoted section of the changelog): Screenshot from 2020-03-03 11-01-39

alloy commented 4 years ago

@TheSavior As a one-off, for just this version, we can sort those sections with sort -f -t @ -k 2. E.g. on macOS, copy the entries of an unknown section and then run:

pbpaste | sort -f -t @ -k 2 | pbcopy

…and paste it back.

EDIT: I’ll do this after figuring out the issues @TheSavior identified, because running it now would just lead to even weirder sort results.

alloy commented 4 years ago

Btw, we should probably only fix the unknown entries once we generate the changelog for the version we agree to release as stable version, right? Then people can just PR their fixed changelog entries onto this branch.

kelset commented 4 years ago

re: @jeremy-deutsch

I'd like to help sort the "unknowns". @kelset, would it be possible for you to give someone trusted (like @alloy) edit access to this branch/PR, so that you don't have to be the only person who approves suggestions/moves around the "unknowns"?

Eloy has write access to this repo so he can "take over" this branch when/if he wants :) As do all the members of the RNComm github org, since it's the default setting to have write access to all repos.

I don't think I will have time to work on the feedback here today - so if anyone is taking it over please just write a comment when they do and when they are done so that we are all aware 🤗

alloy commented 4 years ago

@TheSavior Updated based on RC4 and sorted the unknowns by author.

elicwhite commented 4 years ago

Yay! Thanks

Do you think this is likely to be the one and we should get our team to start annotating the uncategorized commits? Or should we hold off?

alloy commented 4 years ago

I’d like for this to be the one, so yeah ready to get started 👍

rickhanlonii commented 4 years ago

@kelset do you want to review the suggested changes and I'll take a pass after that?

elicwhite commented 4 years ago

@rickhanlonii, I think there was talk of someone just making changes and committing back to this branch. Do you have access?

I imagine that is easier than flagging 100 commits as internal for someone else to remove :-)

alloy commented 4 years ago

@jeremy-deutsch Hiya! You seem interested in helping out with the CHANGELOG, which is absolutely welcome 👌

I don’t believe anybody has started on this yet (correct me if I’m wrong @TheSavior), so please feel free to make a PR into this branch. It would probably be best for now to limit changes to moving around those that are in the unknown/wrong section and leave the internal ones to FB people to resolve.

As for the folding together of details about new features such as Flipper; I generally prefer that, but will defer to the people that have been doing these releases longer than I have.

jeremy-deutsch commented 4 years ago

@alloy Sounds good to me! I’ll take a look to see if anything might be better categorized, but hold off on marking anything else as internal or non-stable-RN. The big bucket of suggestion comments might not have been the perfect approach here 🙂

alloy commented 4 years ago

Ace, thanks 🙏

kelset commented 4 years ago

hey folks - I should have some time today so I'll tackle this in the next couple hours. @jeremy-deutsch I really want to thank you for all your feedback! And don't worry, leaving all those comments is ok - luckily now GH has some nice UX over hiding addressed comments.

I'll try to merge everything you proposed, then do another cleanup, then report back - so that you don't have to waste time re-addressing all the changes you have proposed as a PR 👍

kelset commented 4 years ago

Hey folks. I've taken a stab at improving the status of the PR and I'm done for the day; here's the breakdown:

That said, for this PR to be ready there is one major thing that still needs to be done: meaning, addressing the huge unknown section. I'm not sure who is the best person for that at this moment but we'll discuss it asap.

Aside from that, to address the only other comment left:

I realize the format of the changelog is to list by commit, but maybe all the Flipper-related commits should be one changelog item.

I personally prefer to have multiple commits regarding Flipper in here - having just one line for all the work being done around it may confuse some people around some details of how it has been addded/implemented. But I'm more than happy to consider alternative options such as creating a one-off dedicated section with all the Flipper related commits.

elicwhite commented 4 years ago

I believe @rickhanlonii said he would take point on addressing the unknown commits from the Facebook side

jeremy-deutsch commented 4 years ago

I personally prefer to have multiple commits regarding Flipper in here - having just one line for all the work being done around it may confuse some people around some details of how it has been addded/implemented. But I'm more than happy to consider alternative options such as creating a one-off dedicated section with all the Flipper related commits.

Yeah, with "one changelog item" I was thinking something more along the lines of

- Add Flipper support ([abcdef] by @this-person, [123456] by @that-person, ...)

so we still have all the commits for reference, but they're not spread around the changelog. There's a couple other examples of this in the changelog already, for example in v0.60->Added->New Intro screen.

rickhanlonii commented 4 years ago

Yeah I'm going to go over this and all the unknowns, was just waiting for @jeremy-deutsch's changes to be applied. Last night I improved the script to find commits that mention a changelog but were formatted incorrectly which will make it easier to go through the unknowns.

alloy commented 4 years ago

@jeremy-deutsch To follow up on my earlier comment, if you’d like to be more actively involved in work like this, please reach out to me at eloy.de.enige@gmail.com

rickhanlonii commented 4 years ago

Ok all the unknowns have been categorized or removed 👍

kelset commented 4 years ago

Thanks to everyone for their comments, it looks like we are (almost!) ready to merge this.

Only two things missing are the links to the blogpost (still not up) and to the dedicated issue (still not open).

Anything else that I may be forgetting?

jeremy-deutsch commented 4 years ago

@kelset I have some formatting/consistency nits, but nothing blocking (PR here)

kelset commented 4 years ago

thanks @jeremy-deutsch! Merged 👍