react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 405 forks source link

[changelog-generator] Make it possible to use without a GH API token. #167

Closed alloy closed 4 years ago

alloy commented 4 years ago

Feature Request

Make it possible to run the changelog-generator without the need for a GitHub API authentication token.

Why it is needed

Speaking with @kelset, I realized that e.g. the RNW people are wanting to be able to generate a changelog at any time and include internal changes. If they need that, there are probably others that need it too. These people most likely don’t need the GitHub handles of authors, so it could all be done locally.

@kmelmon Would you agree with this?

kmelmon commented 4 years ago

I see this as a nice-to-have. I don't think we'll see a large number of people needing to do this, so if this is difficult to implement, or exposes a real security issue, I think it would be fine to require the auth token.

alloy commented 4 years ago

Alright, not going to do this right now then.