search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 404 forks source link

Add failed section #173

Closed rickhanlonii closed 4 years ago

rickhanlonii commented 4 years ago

Summary

When going through the Unknowns in the 0.62 changelog, I noticed that there were a lot of commits that have some kind of "changelog" in it but fail to match up for various reasons.

This PR moves anything that is "unknown" but has the word "changelog" in it to a new Failed section so we can dig into why they failed and hopefully add regression tests.

Test Plan

Here's the Failed commits for 0.62:

What are the steps to reproduce (after prerequisites)?

N/A

Compatibility

N/A

Checklist

rickhanlonii commented 4 years ago

Looks like a lot of the failed commits used this format:

Changelog: Some commit message

There are some that do (@TheSavior we should check if we're allowing this still):

Changelog: internal

There's a few that use a heading for the changelog (one, two, three) as in:

## Changelog

[General] [Fix] - Add onSlidingComplete callbacks when sliders adjusted via a11y.

I'm not sure which of these if any are still possible.

alloy commented 4 years ago

Yup, nice one 👍