search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 407 forks source link

[CHANGELOG/v0.62.0] Note required ProGuard rule #182

Closed alloy closed 4 years ago

alloy commented 4 years ago

As noted in https://github.com/facebook/react-native/issues/28270

Related to https://github.com/react-native-community/upgrade-support/issues/19

The upgrade to Hermes 0.4.0 itself isn’t really breaking, but I thought that this was perhaps the most intuitive way for users to find their issue.

lucasbento commented 4 years ago

@alloy: just changed from Fixes to Related to as we still have to do some work on upgrade-helper for this.

alloy commented 4 years ago

Ah ok, let me fix the commit message then so GH doesn’t auto-close.

alloy commented 4 years ago

Done

lucasbento commented 4 years ago

Thanks @alloy 🙌

matt-oakes commented 4 years ago

Should this have gone into React Native's proguard-rules.pro file so users wouldn't need to add it to their own?

alloy commented 4 years ago

@matt-oakes Can you ask that on the original issue instead? https://github.com/facebook/react-native/issues/28270