Closed elicwhite closed 4 years ago
Can we cherry-pick this? https://github.com/facebook/react-native/pull/27885
It should have no negative impact. It offers new benchmarking opportunities.
@grabbou So when will we get the 0.63 stable?
@Gustash I have not cherry-picked this commit, but I have bumped CLI to even newer version, should be fixed! Along with that, the Podfile fix is also there.
@piashcse, as per the previous comment, I will let you know as soon as such date is set.
@emilisb, your request is not a critical bug fix which would qualify it as a good candidate to be cherry-picked. However, I understand the importance of it for you and have passed it for discussions internally. Will be back with the updates really soon.
"We want to step back and make space for more important voices to be heard"
Can I understand that the delay of v63.0 release may because support for BLM? If so, RN team is so political.
@owcc there is nothing political about human rights.
"We want to step back and make space for more important voices to be heard"
Can I understand that the delay of v63.0 release may because support for BLM? If so, RN team is so political.
This is just a bad excuse for procrastination. The last version release process took almost half a year
@gaodeng how'd you like that open source repository where you could just go ahead and take advantage of the code without waiting on anyone? Pretty cool right? Your cynicism is sad and contributions are zero https://github.com/react-native-community/releases/pulls/gaodeng, so...
Oh wait, I see one https://github.com/facebook/react-native/pulls?q=is%3Apr+author%3Agaodeng+is%3Aclosed well there ya go. Not the most terrible.
Still
[and yes, I marked my own comment as disruptive, truth]
Let's keep this on topic people. If you're looking for cherry picks for the next release, and it has a commit hash, post them here.
@gaodeng how'd you like that open source repository where you could just go ahead and take advantage of the code without waiting on anyone? Pretty cool right? Your cynicism is sad and contributions are zero https://github.com/react-native-community/releases/pulls/gaodeng, so...
@mikehardy your contributions https://github.com/react-native-community/releases/pulls/mikehardy ,so...
If the RN release process is really so difficult, then we should learn how competing products flutter are released regularly
@owcc there is nothing political about human rights.
It's true, but with wisdom and civilization. I just feel sad for what happened in past days in US, robbery, riot and killings, sometimes we may not see the truth, but life has to continue. I live in a worse country but I still believe god love everyone. Let me end this topic, I just want leave technology be pure and continue
I wholeheartedly support the BLM movement but I don't understand what's it got to do with React Native or how not making a release is supposed to help BLM. Is this some kind of protest?
I wholeheartedly support the BLM movement but I don't understand what's it got to do with React Native or how not making a release is supposed to help BLM. Is this some kind of protest?
“make space for more important voices to be heard” what is this "voices"? I'm sorry for a misunderstanding if it means "more tests or less bugs or constructive opinion for this release", but if it means "let's make some time to learn what's BLM and may join us to support ", that's the way "how not making a release is supposed to help BLM". Because "the BLM topic" is appeared here make me had to think the connection about this.
Again, I appreciate the great work of RN team.
Locking this issue to maintainers as the discussion went off topic and wasn't focused on the actual release any longer. We'll release 0.63.0 soon.
As per this https://github.com/react-native-community/releases/issues/199#issuecomment-652284341 comment, we have cherry-picked https://github.com/facebook/react-native/commit/33b3a1a1453ca51690e59b758eeb61a4fa8f35bc for compatibility with latest Apple requirements.
Changelog PR is ready and can be merged anytime the release is out.
The blog post PR is ready and can be merge anytime the release is out.
Before we finally push the release out, we need to make sure that https://github.com/facebook/react-native/pull/29204 is merged and cherry-picked to fix issues on Android.
As soon as this is resolved, we will push the release out.
The fix has landed in https://github.com/facebook/react-native/commit/8c42c01. I have already cherry-picked it. Because it's a bit late, I will postpone the final round of testing and the release till tomorrow. Meanwhile, I will let the CI process the changes and ensure the tests are still passing.
@grabbou What about this issue? https://github.com/facebook/react-native/issues/28551 The fix is to update flipper https://github.com/facebook/react-native/pull/29033
@sunnylqm While a good fix, it has not landed in master yet and does not appear to constitute a blocker for this release—as it only applies to some and can be worked around, whereas nobody being able to debug on Android is a deal-breaker. Once your fix lands, please ask it to be picked on the v0.63.1 issue instead.
0.63.0 is being released as we speak, closing this issue in the meantime. Let's move on to the 0.63.1 from now on.
Highlighted Changes
Work Required
Click to expand!
- [x] facebook/react-native#28776 - [x] Fix [`scrollResponderScrollNativeHandleToKeyboard` warnings](https://github.com/facebook/react-native/issues/28203#issuecomment-592973087). Fix [here](https://github.com/facebook/react-native/commit/3246f68952c8fe065367ef8d2cdf7da5dfff78e4) - [x] [A new Image Prop `analyticTag` was accidentally landed. This needs to get prefixed as `internal`](https://github.com/facebook/react-native/commit/1c10568967231cce2be01d2341f4edb79d57ec48) @dvacca. Fix [here](https://github.com/facebook/react-native/commit/8e48dc0555e0c3432a77d421b1e535d17f5933c8) - [x] [Android doesn't build due to missing `cliPath`](https://github.com/facebook/react-native/issues/28466) - [x] [Android doesn't build due to incorrect Kotlin version](https://github.com/facebook/react-native/pull/28626)Non-Blocking
Click to expand!
- [x] Bump Flipper to v0.41 - [x] Documentation for Pressable @kikisaints / @rachelnabors - [x] Rename Pressable `pressRectOffset` prop to `pressRetentionOffset`. @TheSavior - [x] [Make sure PlatformColor ESLint rule is enabled on new projects](https://github.com/facebook/react-native/commit/602070f44b02220aeb036a7b3c26dad5c611b636) (might require publishing a new package) - [x] [Remove ColorAndroid method](https://github.com/facebook/react-native-website/pull/1813#issuecomment-609962877) @tom-un - [x] [Documentation for PlatformColor](https://github.com/facebook/react-native-website/pull/1813) @kikisaints / @rachelnabors - [x] [Documentation for DynamicColorIOS](https://github.com/facebook/react-native-website/pull/1813) @kikisaints / @rachelnabors - [x] [Fix Pressable's Android ripple with `borderless`](https://github.com/facebook/react-native/pull/28526) @vonovak. Fix [here](https://github.com/facebook/react-native/commit/44ec762e41029bf43530b1ff9b36ca3512c526e2) - [x] [Fix Podfile paths to React Native in monorepos and non-standard structures](https://github.com/facebook/react-native/pull/28572) @grabbou - [x] Ensure Hermes is on 0.5.0 @willholen (https://github.com/facebook/react-native/commit/4305a291a94) - [x] Cherry-pick [Podfile cleanup](https://github.com/facebook/react-native/pull/28651#issuecomment-614663967) - [x] Allow iOS PlatformColor strings to be ObjC or Swift UIColor selectors https://github.com/facebook/react-native/commit/25793eab56217a9961620761ea65ec2fcb97dcb0 - [x] facebook/react-native@d06ee3dHopeful Dates
We can never commit to the dates involved in a release as many things are out of our control. However, we are thinking about these rough dates for this release.