v0.62.2 Discussion

[alloy]

Conversations on this thread should be limited to reporting issues that are new in this minor version or requests to cherry-pick bug fixes that have landed in master.

In all other cases, please report the issue to http://github.com/facebook/react-native/issues.

[Maskedman99]

Can we add that extra rule to proguard-rules.pro file that is needed while running Hermes in RN0.62 https://github.com/facebook/react-native/issues/28270

[SaeedZhiany]

Can we cherry-pick this? https://github.com/facebook/react-native/commit/7980615d371a7bf607a3787bca91cfde229c41dc

[alloy]

@Maskedman99 Care to create a PR for that?

[sunnylqm]

https://github.com/facebook/react-native/commit/449dc37720b24d9d88661314424c9f982e70ec3a

[guhungry]

Fix app crash due to flipper 0.33.1 in ios debug build when use base64 image https://github.com/facebook/react-native/commit/17f025bc26da13da795845a3f7daee65563420c0

[SaeedZhiany]

can also we cherry-pick this? https://github.com/facebook/react-native/commit/e5497ca8f6e3b240948fdbeef0ac2a710f25bb56

[sunnylqm]

@SaeedZhiany Already picked in 0.62.2

[SaeedZhiany]

are you sure? it seems not

[sunnylqm]

@SaeedZhiany Backport is not tagged on master branch.

[christianbach]

Could we pick this? https://github.com/facebook/react-native/commit/7deeec73966d84140492c2a767819977318c4d2d

For context: https://github.com/react-native-community/cli/pull/939 https://github.com/react-native-community/upgrade-support/issues/26#issuecomment-613291056

[naved971]

command : react-native run-android --variant=release App is crashing on version RN Version 0.62.x while running release variant Please check

[mikehardy]

@naved971 this is for release planning. Bug reports go in the main repository

[Bardiamist]

@naved971 I got same after update to 0.62. ./gradlew clean helped

[ahce]

Can pick this? https://github.com/facebook/react-native/commit/28dce3665d8a63e902c165c060400486fe6234f4 https://github.com/facebook/react-native/commit/7757ad05762284c059807d7d75fd03559e86f2b2

[Knjaz89]

Hello. how to set ref to Animated.ScrollView and call scrollTo by ref ?

[levibuzolic]

@Knjaz89 Hello. how to set ref to Animated.ScrollView and call scrollTo by ref ?

This isn't the correct place for support, this thread is for discussing issues in the v0.62.2 release of React Native.

However to answer your question:

function SomeComponent() {
  const scrollView = React.useRef();

  function someCallback() {
    scrollView.current.getNode().scrollTo({x: 0, y: 0});
  }

  return <Animated.ScrollView ref={scrollView} />
}

[Knjaz89]

@Knjaz89 Hello. how to set ref to Animated.ScrollView and call scrollTo by ref ?

This isn't the correct place for support, this thread is for discussing issues in the v0.62.2 release of React Native.

However to answer your question:

function SomeComponent() {
  const scrollView = React.useRef();

  function someCallback() {
    scrollView.current.getNode().scrollTo({x: 0, y: 0});
  }

  return <Animated.ScrollView ref={scrollView} />
}

TS2322: Type '{ ref: MutableRefObject; }' is not assignable to type 'IntrinsicAttributes & AnimatedProps & { children?: ReactNode; }'.   Property 'ref' does not exist on type 'IntrinsicAttributes & AnimatedProps & { children?: ReactNode; }'.

[Bardiamist]

@Knjaz89 Animated.ScrollView type is wrong.

My temp solution for ignore error:

export interface AnimatedComponent<T extends (
  React.ComponentType<Animated.ComponentProps<T>>
  | React.Component<Animated.ComponentProps<T>>
)> extends React.FC<Animated.AnimatedProps<Animated.ComponentProps<T>> & { ref?: any }> {
  getNode: () => T;
}

export const AnimatedScrollView = (Animated.ScrollView as AnimatedComponent<ScrollView>);

Would nice if somebody fix it.

[zhongwuzw]

Could we pick this https://github.com/facebook/react-native/commit/9cdc19a93669b37c0518bd32263e156ffc9193c7?

[AnOptimistSeePessimist]

crash in android 4.x with react-native 0.62.2

[mikehardy]

@AnOptimistSeePessimist this is for discussion of cherry-picks to any potential 0.62.3 only, not for bug reports. That said I have react-native 0.62.2 working successfully down to 4.4.4 / API19 personally tested with (old terrible) hardware. This is likely an upgrade issue that may be solved by investigating the 'upgrade-helper' site to see where the DevManager stuff is implemented and if you forward-ported your project correctly to it.

[chris-griffin]

Can we pick https://github.com/facebook/react-native/commit/a2f8b9c36e5eba6bc354a2f53bf8d3ca11297d00 which fixes an incorrect white text color being applied on TextInputs when an iOS device is set to dark mode even if the background of the input is white as well?

[glibenko]

Important info if you use Hermes I updated from 61.5 to 62.2 and got a crash on android: couldn't find DSO to load: libhermes-executor-debug.so

I fixed it by adding following string to android/app/build.gradle: implementation "org.webkit:android-jsc:+"

[JLucasCAmorim]

Can we pick facebook/react-native@e5a6655 which fixes the Animated image crash when CADisplayLink target in RCTWeakProxy is nil?

[jakobvase]

Can we pick https://github.com/facebook/react-native/commit/33b3a1a1453ca51690e59b758eeb61a4fa8f35bc? Changes the launch screen from .xib to .storyboard, as required by Apple before June 30th (https://developer.apple.com/news/?id=03262020b).

[SaeedZhiany]

@alloy Are all the requested cherry-picks in this issue included in 0.63.x? If yes, we can close this issue right? otherwise, I'm wondering which version will include those cherry picks?

Thanks.

[chris-griffin]

I would definitely love to see these cherry-picks added to a new 62.2.3 release. This seems necessary especially given https://github.com/react-native-community/releases/issues/188#issuecomment-639382202 (which will break things starting tomorrow). But in general, we would be very grateful to see additional stability in releases by backporting fixes to the previous major/minor patch.

[radko93]

@chris-griffin this only affects new projects, if you have an existing project you need to migrate to a storyboard manually anyway. But it has to be included in 0.63.

[kelset]

echoing what @radko93 just said, cherry picking the commit won't autofix/autoupdate any already existing app. That change needs to be done manually anyway, so in all fairness since we are releasing 0.63.0 very soon I don't think it's necessary to release 0.62.3 (since it won't come out before 0.63 anyway and react-native init will use 0.63).

[sunnylqm]

Any chance for https://github.com/facebook/react-native/commit/0a6f058b6bd0493f7eece972b1f73be3606ca8d5#diff-5df8978d901ea853da66f065feee64ab which fixes https://github.com/facebook/react-native/issues/25923#issuecomment-594047945

[alloy]

Thanks for bearing with us and reporting issues/requests for picks 🙏 Due to available bandwidth, we decided to focus on getting a v0.63.0 release out rather than another v0.62.x patch release. I’ve gone through all the requested picks and have added those that are not yet slated for v0.63.0 to be picked for v0.63.1: https://github.com/react-native-community/releases/issues/199