Closed jeremy-deutsch closed 4 years ago
cc @kmelmon
Do you want to mark this as ready for review and get it out of draft?
Do you want to mark this as ready for review and get it out of draft?
Sure, I'll just drop the React syncs and mark the PR as ready
It looks like there are a fair amount of deprecations spread out throughout the changelog. Those should probably get hoisted up to the top near the breaking changes.
I also want to flag that https://github.com/facebook/react-native/commit/fb2900e1851e9b12fbcfaf0c047302fb1ca6ae54 was reverted but the original commit showed up in the changelog. Seems like a bug in the generator that it didn't catch that. cc @alloy
It looks like there are a fair amount of deprecations spread out throughout the changelog. Those should probably get hoisted up to the top near the breaking changes.
I think it would be good to list them under the Deprecated
section. I will borrow them and put them in the article.
It looks like there are a fair amount of deprecations spread out throughout the changelog. Those should probably get hoisted up to the top near the breaking changes.
@TheSavior Could you leave comments on some of those deprecations? I couldn't find them by eyeballing the changes.
I have moved the deprecation message that wasn't under the section. The rest is broken down by platform. Waiting for the final approval before we merge it.
This is basically a duplicate of #192, but I found it easier to start from scratch. I sorted some of the entries, and removed anything I don't think could affect OSS RN users, e.g. any testing fixes/improvements. All of those changes are in the second commit; the first one has the pure generated changelog for reference.
There are still a few TODOs and maybes that I'll look at again with fresh eyes tomorrow:
I generated the changelog off of rc-1, so I still need to manually add entries for the last round of cherry-picked commits.Since LogBox was technically part of the last release (albeit unstable), I left the LogBox commits as they were without grouping them.(This one seems fine to keep unless someone thinks otherwise)There's a couple other TODOs I put in there I'll come back to.The commits for the React syncs and the internal repo syncs were a bit TMI, so I don't know whether to include any of them or not. We haven't included them in the last few changelogs, so I'll probably just remove them unless someone one of them turns out to have something important (in which case it'll get a useful label). I've grouped all those syncs in the "Unknown" section - they're the only thing keeping this a draft for now.Any other thoughts/corrections would be welcome, of course! cc @alloy @rickhanlonii @grabbou