Closed grabbou closed 4 years ago
mikehardy
commented
4 years ago Campeon @grabbou! This one just landed and makes it so the default new app template doesn't crash everything Android<API21 https://github.com/facebook/react-native/commit/7694b32a88078278457dd8721eb61da9c4ac0f5a
kelset
commented
4 years ago Based on this comment by @JoshuaGross here are 3 more commits:
Bardiamist
commented
4 years ago 0.63.x introduced couple unplesant bugs:
Would be good to find reasons/solutions and fix/revert asap. Very don't want rollback to 0.62.2.
todorone
commented
4 years ago Unfortunately, 0.63.x is not compatible with babel-plugin-module-resolver it'd be great to have it fixed - https://github.com/facebook/react-native/issues/29351 https://github.com/facebook/react-native/issues/29356
vikasg603
commented
4 years ago The Network API not working when uploading any file. You can see my issue here https://github.com/facebook/react-native/issues/29389
It's a major bug if possible resolve it as soon as possible.
mikehardy
commented
4 years ago This issue is to track cherry-pick requests - a valid request is the commit hash of a change that has landed on master. It is not for tracking open issues.
If you can point to the commit hash in the react-native repo of a landed commit, it can be requested here
saihaj
commented
4 years ago Can we do this, it will help fix this -> TypeError: null is not an object (evaluating 'Object.keys(styles[name])')
https://github.com/facebook/react-native/commit/e75557b48fbee1d136b8b7d1a78ea8f9b9467479
lorenzoangelini
commented
4 years ago @grabbou I found an issue on android. We use the flavors to differentiate our app version, and we generate the appBundle (.aab) once a migrated our react native project to 0.63 and also upgraded to https\://services.gradle.org/distributions/gradle-6.2-all.zip and com.android.tools.build:gradle:3.5.3 we cannot find the index.android.bundle into .aab if I run the command ./gradlew bundleDevRelease i have this issue. If i run ./gradlew bundleRelease, i build every flavors and in the first app-dev.aab is missing, into the others (app-test.aab , app-prod.aab) is present. This problem is present when is upgraded the gradle
kelset
commented
4 years ago @lorenzoangelini as explained by @mikehardy a few comments above:
This issue is to track cherry-pick requests - a valid request is the commit hash of a change that has landed on master. It is not for tracking open issues.
Please open an issue to report the issue in the main repo. This conversation is for requesting commits that can be cherry picked.
Ashoat
commented
4 years ago Can we cherry-pick https://github.com/facebook/react-native/commit/23036b38bc4443c8db4865e5c2b21aca7ab4f92f? This fixes https://github.com/facebook/react-native/issues/29397. tl;dr is that without this, Android apps that specify windowTranslucentNavigation are unable to dismiss LogBox, because the buttons appear below the navigation bar.
smacgregor
commented
4 years ago Can we cherry pick https://github.com/facebook/react-native/commit/123423c2a9258c9af25ca9bffe1f10c42a176bf3? This fixes showing images on IOS 14.
djschilling
commented
4 years ago Can we cherry pick facebook/react-native@123423c? This fixes showing images on IOS 14.
That would be great. We are also experiencing this.
grabbou
commented
4 years ago All commits cherry-picked. No more requests for this release. We're doing tests right now.
Conversations on this thread are limited to 0.63 releases major issues and backport (cherry-pick) requests from commits that are already on master.
An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.63.1 cut.
In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.