search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 404 forks source link

Upcoming v0.63.3 cherrypicks discussion #203

Closed grabbou closed 4 years ago

grabbou commented 4 years ago

Conversations on this thread are limited to 0.63 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.63.2 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

grabbou commented 4 years ago

(I am always scared I will skip one minor version)

nhuson269 commented 4 years ago

My application needs to solve this problem, I have had an issue with iOS since upgrading to version 0.63.x

https://github.com/facebook/react-native/issues/29021

1awaleed commented 4 years ago

My application needs to solve this problem, I have had an issue with iOS since upgrading to version 0.63.x

facebook/react-native#29021

This issue is breaking our apps.

kelset commented 4 years ago

@nhuson269 @1awaleed this issue is only for commits to cherry pick

daveols commented 4 years ago

@grabbou just a heads up that there's a typo in the title, assuming this is the thread for v0.63.3

sunnylqm commented 4 years ago

The title is always confusing. Can we name it more clear like "V0.63.2(released/upcoming on MMDD) Cherry Picks Discussion" @grabbou

makarkotlov commented 4 years ago

@grabbou it seems like we need to fix this asap commit: 2ecd79e431d16c696b486b828b322035e7ce6862 pr: https://github.com/facebook/react-native/pull/29477

SaeedZhiany commented 4 years ago

@grabbou it seems like we need to fix this asap commit: 2ecd79e431d16c696b486b828b322035e7ce6862 pr: facebook/react-native#29477

@kelset, It seems even changing the issue title has not the proper effect 😄

@makarkotlov in such issues, you should only request the commits to cherry-pick that have been merged on the branch master. not the open PRs.

alloy commented 4 years ago

@TheSavior Can we get this merged so we can pick it here? https://github.com/facebook/react-native/pull/29074.

Landed commit https://github.com/facebook/react-native/commit/dc2df754267df3909631d81c22b9fcab58dfa241

makarkotlov commented 4 years ago

@SaeedZhiany how silly of me(( I came from here https://github.com/facebook/react-native/releases/tag/v0.63.2 and there's a statement "You can participate in the conversation for the next patch release in the dedicated issue." and I thought that I can propose there to merge my pr quicker. I think we should disambiguate the intention of this issue by making it more simple like "DO NOT propose unmerged commits" or "We ONLY pick commits already merged in master"

sammy-SC commented 4 years ago

@grabbou could I please get https://github.com/facebook/react-native/commit/ffc90c7f92e63e1a53ed107833e3deed492ab435 picked ?

it resolves https://github.com/facebook/react-native/issues/29364

is there any other information I need to provide?

Thank you

cristianoccazinsp commented 4 years ago

This issue https://github.com/facebook/react-native/issues/29451 needs some urgent attention. RN 0.63 is pretty much unusable on android when the bug happens.

trcoffman commented 4 years ago

Please get both of these released in tandem!

https://github.com/facebook/react-native/commit/e566c7ec7b0015e4e5e6ad92247a6357eb861d4f https://github.com/facebook/hermes/commit/d188b722bae7664db4a14898c9fde189353034ef

caiangums commented 4 years ago

@grabbou could I please get facebook/react-native@ffc90c7 picked ?

it resolves facebook/react-native#29364

is there any other information I need to provide?

Thank you

I think if this really solves the issue for iOS, it would be nice to have! 👍 for this one!

alphasp commented 4 years ago

Image api getSizeWithHeaders on iOS is currently broken. This commit fixed it: https://github.com/facebook/react-native/commit/0bcc686c1cc90fd44de7a28e2f56ea20fe2f5123

kelset commented 4 years ago

friendly reminder folks: it's August. Expect things to slow down.

There are currently only 3 commits requested that are cherry pickable:

The rest of the links are not actionables currently (one is an open PR and the other requires an Hermes releases AFAIK so not doable for a patch release).

oleksandr-dziuban commented 4 years ago

Hello guys, this PR is critical, as we can't use babel-plugin-module-resolver plugin with react-native 0.63.0+ on iOS Production mode: https://github.com/facebook/react-native/pull/29477

This issue is raised here: https://github.com/tleunen/babel-plugin-module-resolver/issues/403

oleksandr-dziuban commented 4 years ago

Additionally raised this issue: https://github.com/facebook/react-native/issues/29636

It is critical issue for projects with this babel plugin

oleksandr-dziuban commented 4 years ago

Yes, I can confirm, this PR fixes the issue: https://github.com/facebook/react-native/pull/29477

I have assembled release iOS build locally with this change and it works!

mikehardy commented 4 years ago

@oleksandr-dziuban we need commit hashes here, not PRs - please post the commit hashes of things to cherry-pick for release once they are merged

lorenzoangelini commented 4 years ago

@oleksandr-dziuban https://github.com/facebook/react-native/commit/2ecd79e431d16c696b486b828b322035e7ce6862

kelset commented 4 years ago

@lorenzoangelini that commit hash is not coming from master - until the PR is merged to master it can't be cherry picked.

lorenzoangelini commented 4 years ago

@kelset is it possible to merge it? For a lot of developers and company this issues are blocking the upgrade to 0.63.2

kelset commented 4 years ago

@lorenzoangelini I can't merge it, it needs to be reviewed and tested and then imported in the FB codebase. I know that the author of the commit being reverted will be looking into this probably next week.

Manouli commented 4 years ago

friendly reminder folks: it's August. Expect things to slow down.

There are currently only 3 commits requested that are cherry pickable:

The rest of the links are not actionables currently (one is an open PR and the other requires an Hermes releases AFAIK so not doable for a patch release).

Yep please 🙏 Our app is broken right now in production due the token issue it would be great if you could kickstart this. Thanks again.

gaodeng commented 4 years ago

Please revert https://github.com/facebook/react-native/commit/a8e85026cfa60056b1bcbcd39cde789e4d65f9cb , this PR https://github.com/facebook/react-native/pull/28354 break xcode archive release process more info https://github.com/facebook/react-native/pull/29477

heroic commented 4 years ago

Can we merge https://github.com/facebook/react-native/commit/07a597ad185c8c31ac38bdd4d022b0b880d02859

inuyashaaa commented 4 years ago

Is there any update on the version?

MartinInAction commented 4 years ago

Would be awesome to get this cherry-picked now ⭐

kelset commented 4 years ago

hey folks, currently no updates. We are still waiting on https://github.com/facebook/react-native/pull/29477 to be merged since that should also be related to helping us move closer to be able to cut 0.64. What is likely to happen is 0.64rc0 first, then probably 0.63.3 (unless upgrading to 0.64 looks trivial in which case we'll focus on getting to 0.64.0 directly). Sorry for the delays, summer/end of summer are always complicated.

yungsters commented 4 years ago

Can we merge https://github.com/facebook/react-native/commit/86ffb9c41e033f59599e01b7ad016706b5f62fc8 for https://github.com/facebook/react-native/issues/29376?

safaiyeh commented 4 years ago

Can we cherrypick https://github.com/facebook/react-native/commit/d8b70b19b39ead4dd41895d666d116a43c56474e issue: https://github.com/facebook/react-native/issues/28551

and make sure https://github.com/react-native-community/releases/issues/203#issuecomment-665754860 as well makes it in. issue: https://github.com/facebook/react-native/issues/29364

Both resolves image issues on Android & iOS that has had 100+ comments on each of their issues.

SandroMachado commented 4 years ago

Can we cherry-pick https://github.com/facebook/react-native/commit/45954ac5dccdfe05de7553a0f08c4f0e66e3d62e?

alloy commented 4 years ago

While not yet merged, I expect it to be merged soon. https://github.com/facebook/react-native/pull/29995

cristeahub commented 4 years ago

Can we cherry pick https://github.com/facebook/react-native/commit/123423c2a9258c9af25ca9bffe1f10c42a176bf3 ? Building with iOS 14 SDK leaves invisible images without it.

sunnylqm commented 4 years ago

@cristeahub it's already been merged into 0.63.2 https://github.com/facebook/react-native/commit/b6ded7261544c703e82e8dbfa442dad4b201d428

cristeahub commented 4 years ago

@cristeahub it's already been merged into 0.63.2 facebook/react-native@b6ded72

Great! Thanks for letting me know 👍 From the commit on master I couldn't see that it was a part of a release.

pokey commented 4 years ago

hey folks, currently no updates. We are still waiting on facebook/react-native#29477 to be merged since that should also be related to helping us move closer to be able to cut 0.64. What is likely to happen is 0.64rc0 first, then probably 0.63.3 (unless upgrading to 0.64 looks trivial in which case we'll focus on getting to 0.64.0 directly). Sorry for the delays, summer/end of summer are always complicated.

Hi @kelset; looks like facebook/react-native#29477 is merged. Any updates on release? Would be great to have that bundler working in staging and release again 😅

alloy commented 4 years ago

@kelset is currently on vacation, so I’ll try to find some time later this week or Monday to cut a release.

a-eid commented 4 years ago

Does any one having issues with core IOS Modal component in 0.63.2 or is it just me, am also wondering if has changed from 0.62.2 version ?

I've made an issue here but I'm not sure if it's always reproducable so I closed it & reverted my projects back to 0.62.2 ( mainly because of the ios release builds. ).

https://github.com/facebook/react-native/issues/29973

alloy commented 4 years ago

@a-eid As per the OP, this issue is only to discuss cherry-picking fixes that have landed in the master branch.

kelset commented 4 years ago

Let's try to sum up the current status of things:

Commits requested related to fixes:

This commit https://github.com/facebook/react-native/commit/d8b70b19b39ead4dd41895d666d116a43c56474e has been requested but since it changes the version of Flipper, I have reservations of making this happen in a patch release, but happy to consider it if it's that important.

Aside from the above, there are 2 more things to keep an eye on:

a-eid commented 4 years ago

@kelset would be nice to have this as well: https://github.com/facebook/react-native/pull/29787

pokey commented 4 years ago

@kelset thanks for the update! didn't realize facebook/react-native#29477 was merged so shortly before my comment 😅. I stumbled across that PR while in the midst of a furious debugging session , then saw this thread, and figured I'd bump, without seeing the timeline.

Thanks again for your responsiveness!

jinshin1013 commented 4 years ago

Is it too late to add a commit for this version?

Fixes the iOS Gif not animating when TurboModule is enabled: https://github.com/facebook/react-native/commit/663b5a878be9faafd13b41c222a1bc2ac7bb3a65.

piashcse commented 4 years ago

is there any plan of releasing 0.64-rc.0 ?

kelset commented 4 years ago

@piashcse there's a dedicated issue for that #207

kelset commented 4 years ago

Here's the list of commits we'll attempt to cherry pick for 0.63.3, in chrono order (oldest -> newest):

In the changelog we should also still mention/redirect people to this issue https://github.com/facebook/react-native/issues/29984 in case they have problems with Xcode12

ravirajn22 commented 4 years ago

@grabbou could I please get facebook/react-native@ffc90c7 picked ?

it resolves facebook/react-native#29364

is there any other information I need to provide?

Thank you

Request RN team to at least pick this commit and release a version. It's a real deal breaker to upgrade. Sorry if I am sounding harsh, but it is not fair to take more than 2 months to release a vital bug fix in fact it was a regression.

I think there is nothing wrong in having many patch releases, instead of waiting for one big patch release which has caused this delay.

I would be happy to help in my capacity, thanks.

diegolmello commented 4 years ago

@grabbou could I please get facebook/react-native@ffc90c7 picked ? it resolves facebook/react-native#29364 is there any other information I need to provide? Thank you

Request RN team to at least pick this commit and release a version. It's a real deal breaker to upgrade. Sorry if I am sounding harsh, but it is not fair to take more than 2 months to release a vital bug fix in fact it was a regression.

I think there is nothing wrong in having many patch releases, instead of waiting for one big patch release which has caused this delay.

I would be happy to help in my capacity, thanks.

@ravirajn22 IMO, in cases like these, you should do a patch-package picking the fix to your local RN. It's not hard and demands a small effort. These are dark times to blame the community for things you could fix easily.