Upcoming v0.63.5 cherrypicks discussion

[kelset]

Conversations on this thread are limited to 0.63 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.63.4 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: https://github.com/facebook/react-native/commit/bd2b7d6c0366b5f19de56b71cb706a0af4b0be43

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

---

Note: we don't know yet if we will work on a 0.63.5 release, it's basically based on how things shape up with 0.64.

---

Update: it's unlikely we'll do a 0.63 patch, but in case here's the list of commits requested/wanted/needed:

• [ ] https://github.com/facebook/react-native/commit/fdcacd7f76ea8ca6dafda32ac431c8adc7bdad00
• [ ] https://github.com/facebook/react-native/commit/42dde12aac81208c4e69da991f4e08b9e62d18f6
• [ ] https://github.com/facebook/react-native/commit/3399896ae756719b238e837001077a46508849be
• [ ] https://github.com/facebook/react-native/commit/0e9296b95da06789121f052e6cd6d7cac808464c

Stretch goals:

• [ ] https://github.com/facebook/react-native/pull/30688

[grabbou]

When https://github.com/facebook/react-native/pull/30543 lands, we will need to cherry-pick it to this branch too. It is affecting users on older React Native versions as well that upgraded to latest Xcode.

Edit: there it is: https://github.com/facebook/react-native/commit/fdcacd7f76ea8ca6dafda32ac431c8adc7bdad00

[grabbou]

I am going to cherry-pick the aforementioned commit and test whether it fixes the issue on this branch as well, as a part of my testing of the same commit for the 0.64 branch!

[grabbou]

This should also be cherry-picked https://github.com/facebook/react-native/pull/30592 to avoid adding a whole new post install hook to a Podfile.

[retyui]

Really wait for these changes https://github.com/facebook/react-native/commit/b7b0e232028723794af4c79fc6366c483ae2350b

To have an opportunity to get tap location on the <TextInput/> component

[kelset]

@retyui that commit adds new functionality so it's not a candidate for a patch release.

[sandfox]

Could we backport in https://github.com/facebook/react-native/commit/d85d5d2e1974b463318e4c86da29a5ccdd60a977 from https://github.com/facebook/react-native/pull/29882 It's a fix for Modal onDismiss behaviour. It's already in 0.64

[kelset]

@sandfox I've already attempted cherry-picking it during the last round, but it's really complicated because the files involved changed a lot - so it's not achievable. The only option would be for someone to do a PR against the 0.63 branch with the fix "repurposed" to work on it.

[sandfox]

@kelset I'll see if I can do that then: https://github.com/facebook/react-native/pull/30688 So far it's working properly on our internal test case

[priteshrnandgaonkar]

Just a reminder, please use the latest Flipper pod, as we have solved the issues related to Apple M1 machines and arm compatibilities. Latest Flipper pod is 0.75.1

[mrousavy]

@priteshrnandgaonkar a bit off-topic, but does the latest Flipper pod also fix https://github.com/facebook/react-native/issues/30836?

[kelset]

@mrousavy from the comments in the issue seems like it did. In my experience, you can just change your podfile to

use_flipper!('Flipper' => '0.75.1')

To change the Flipper version

[kelset]

potential cherry pick: https://github.com/facebook/react-native/commit/3399896ae756719b238e837001077a46508849be

[retyui]

p.s. @kelset seem you recommend a legacy ruby syntax

-use_flipper!('Flipper' => '0.75.1')
+use_flipper!({ 'Flipper' => '0.75.1' })

[retyui]

Still waiting for a fix for Modal::onDismiss on iOS https://github.com/facebook/react-native/commit/d85d5d2e1974b463318e4c86da29a5ccdd60a977

[kelset]

We are getting closer to 0.64.0 so atm we are fully focused on that - no ETA for a new patch for 0.63.x.

[sandfox]

@retyui - there's an open (mine) PR for it https://github.com/facebook/react-native/pull/30688 that can be used if 0.63.5 gets the go ahead (assuming poeple are ok with merging it of course).

[kelset]

potentially useful to consider: https://github.com/facebook/react-native/commit/0e9296b95da06789121f052e6cd6d7cac808464c

[anchi20]

here, facebook/react-native#29070

[tido64]

@anchi20: Please read the first post:

Conversations on this thread are limited to 0.64 releases major issues and backport (cherry-pick) requests from commits that are already on master.

Please let us know when your PR has landed on master.

[kelset]

update: it's not likely we'll do a 0.63.5 patch, but since the Xcode 12.5 issue is fairly big it could be the case. We are still waiting for a commit to land in master, but I've started to update the top post with the list of commits we should cherry pick.

[todorone]

@kelset Not everybody can migrate to 0.64 yet, so releasing a fix to XCode 12.5 will be a lifesaver... 🥺

[kelset]

@todorone if you are on 0.63 you only need to tweak your podfile to address the Xcode 12.5 issue, see details here: https://github.com/facebook/react-native/issues/31480

[kelset]

Given how the update for Xcode 12.5 didn't require an update for 0.63, I'm going to close this off. We are currently focused on 0.64 and 0.65 so there won't be new 0.63 releases for the time being.