search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 407 forks source link

Upcoming v0.64.1 cherrypicks discussion #221

Closed grabbou closed 3 years ago

grabbou commented 3 years ago

Conversations on this thread are limited to 0.64 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.64.0 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: https://github.com/facebook/react-native/commit/bd2b7d6c0366b5f19de56b71cb706a0af4b0be43

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

PRs to merge:

Ready for cherry-pick:

Issues to resolve:

Edit by @kelset to update the status of PRs/commits/issues.

pvinis commented 3 years ago

this should be there: https://github.com/react-native-community/cli/pull/1374

TheSavior commented 3 years ago

@grabbou, can you help make a list of all the PRs we need to merge that were already cherry picked into 0.64?

thymikee commented 3 years ago

https://github.com/facebook/react-native/pull/30637 – making RN compatible with upcoming Jest 27, otherwise folks will need to use yarn resolutions

kelset commented 3 years ago

+1 on what @TheSavior says; I tried looking through the comments and I think this is the list, but please @grabbou verify it:

(there were more I think but got merged in the meantime)

kelset commented 3 years ago

We should try to get this PR merged & cherry picked: https://github.com/facebook/react-native/pull/31141 - context: https://stackoverflow.com/questions/66627590/phasescriptexecution-error-in-react-native-app

kelset commented 3 years ago

worth considering too: https://github.com/facebook/react-native/commit/0e9296b95da06789121f052e6cd6d7cac808464c

myckhel commented 3 years ago

Please when will TurboModule be integrated?

kelset commented 3 years ago

@myckhel please refer to https://github.com/react-native-community/discussions-and-proposals/issues/40

anchi20 commented 3 years ago

here, https://github.com/facebook/react-native/pull/29070

tido64 commented 3 years ago

@anchi20: Please read the first post:

Conversations on this thread are limited to 0.64 releases major issues and backport (cherry-pick) requests from commits that are already on master.

Please let us know when your PR has landed on master.

Bardiamist commented 3 years ago

Regression detected, font-family is not apply when secureTextEntry is true Looks we need this PR again: https://github.com/facebook/react-native/pull/30164 (that was cherrypicked in 0.63.4)

Details: https://github.com/facebook/react-native/issues/30123#issuecomment-802670151 super.setTypeface(tf); line at the wrong place again: https://github.com/facebook/react-native/blob/0.64-stable/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java#L423

kelset commented 3 years ago

Thanks for reporting @Bardiamist, looks like we need to cherry-pick again the commit from master: https://github.com/facebook/react-native/commit/00d9deaf6ba26c605694d303bb0cb072fceae5a1 (probably landed after 0.64 was cut)

DanielMarkiel commented 3 years ago

Hi, I'm not sure if it's the correct discussion to bring this up, so I apologize in advance if not.

A bunch of people is facing the issue described here -> https://github.com/software-mansion/react-native-gesture-handler/issues/1284 In short, we all are getting the java.lang.IllegalArgumentException: Unable to find JSIModule for class UIManager error on Android from different packages after upgrading to RN 0.64.

1) Is this a known issue? 2) If not, is someone able to tell if this is something on the RN side, or it's some kind of incompatibility issue in each of mentioned packages with RN 0.64?

The list of packages that were mentioned in discussions:

grabbou commented 3 years ago

@grabbou, can you help make a list of all the PRs we need to merge that were already cherry picked into 0.64?

@TheSavior, here is the list of commits I have applied on 0.64-stable that were not merged to master at that time:

mikehardy commented 3 years ago

@DanielMarkiel looks like that crash on Android for UIManager needs an issue in the react-native repo - I was not able to find anything that looked exactly on target for Unable to find JSIModule for class UIManager (broad search attempted) though @Bardiamist was active in a maybe-related issue - any issue opened is probably going to really need a minimal reproducible example to eliminate differences between hermes or not etc etc.

Bardiamist commented 3 years ago

Unable to find JSIModule for class UIManager

I created minimal reproducible example: https://github.com/Bardiamist/jsimodule I'm not sure where should be issue, but just in case I created on React native repo: https://github.com/facebook/react-native/issues/31245 Also I left link to minimal reproducible example link on existing issue in react-native-gesture-handler repo: https://github.com/software-mansion/react-native-gesture-handler/issues/1284

Johan-dutoit commented 3 years ago

I believe there is a regression in the build script for iOS in 64, see: https://github.com/facebook/react-native/issues/31282

mikehardy commented 3 years ago

@Johan-dutoit more than one I think, use_frameworks is busted right now for iOS+RN64, no PR yet because it needs thought on where to put the spec generation step but there's a functioning workaround posted here https://github.com/facebook/react-native/issues/31149#issuecomment-800841668 and I put up a reproducible example.

mayconline commented 3 years ago

i'm problem with text input , when focusing on text input, it opens the keyboard the first time, but if you close the keyboard, and try to click on the text input again, the keyboard does not open again.

exists one issue open, but not resolution yet - https://github.com/facebook/react-native/issues/30746

alexco2 commented 3 years ago

Hello, Would it be possible to cherrypick this? facebook/react-native#30737 This is a fix that would enable support for section list for the library react-native-collapsible-tab-view.

mikehardy commented 3 years ago

@alexco2 the commit hash is the important bit: https://github.com/facebook/react-native/commit/310a6bcf4ba7ca162d3ba1c03e0ab07ff41f9ead

alexco2 commented 3 years ago

Thank you! I'm new to this whole process :)

mikehardy commented 3 years ago

If this is not already in the list, I think https://github.com/facebook/react-native/pull/31010 (update Flipper) is important, because Flipper was not published to mavenCentral until 0.75.x and jcenter is going away meaning builds will break by default with react-native 0.64 unless it's updated (or 0.65 is released) - commit https://github.com/facebook/react-native/commit/3399896ae756719b238e837001077a46508849be

mikehardy commented 3 years ago

This is just context but I did a deep dive on "jcenter/bintray is going away" to see if I could purge react-native-device-info module of jcenter uses - including the example app and it appears yoga's 'proguard-annotations' artifact is the key to it all. There are 3 items total

1- flipper itself (requested above) 2- flipper dependency on fbjni-android-only (fixed in flipper 0.79+, so we actually need a newer one than is even on main dev branch but wait...) 3- flipper dependency on yoga progaurd-annotations which is still published on jcenter only but tracked here and will require a still-newer flipper unless they publish old artifacts on jitpack or mavenCentral

kelset commented 3 years ago

@mikehardy good info, would you mind also mentioning those here? https://github.com/react-native-community/discussions-and-proposals/issues/331

stigi commented 3 years ago

I'd like to nominate this PR that fixes dimensions after rotation on Android and that didn't make it into 0.64.0 yet:

kbrandwijk commented 3 years ago

I would love to see this one make its way into 0.64.1, as there really is no good workaround: https://github.com/facebook/react-native/pull/30164 A (low risk?) fix to Android fontstyling of placeholder texts for secureEntry TextInput fields.

myckhel commented 3 years ago

Please what are the plans for RN 0.64.1? Could it be the version of TurboModule support?

Can't really wait to have turbomodule enabled.

pvinis commented 3 years ago

This seems useful, as the issue happened with 64.0. https://github.com/facebook/react-native/pull/30027

eliw00d commented 3 years ago

PRs to merge:

This PR was closed in favor of https://github.com/facebook/react-native/commit/bdfe2a51791046c4e6836576e08655431373ed67. So, that should make it into 0.64.1, right? This is holding us back at the moment.

Ashoat commented 3 years ago

Would be great to include https://github.com/facebook/react-native/commit/291cc95cc9e3c8e37fc7f2160d4eacd91b1c72be. Without this, Hermes crashes on Android don't log the error that causes the crash, which makes debugging really difficult.

Additional context:

kelset commented 3 years ago

updated top post with the commits/issues/PRs mentioned so far. The Xcode 12.5 fix commit is still in the works so we'll have to wait for that before proceeding.

TheSavior commented 3 years ago

We need to get this security related fix into the next patch release for 0.64: https://github.com/facebook/react-native/commit/33ef82ce6dfd31e1f990d438c925a0e52723e16b

I'll add it to the list in the OP.

robertying commented 3 years ago

Could we have this PR https://github.com/facebook/react-native/pull/31062 looked at, merged and picked? It fixes a regression issue that prevents Hermes from building on Mac Catalyst.

kelset commented 3 years ago

Hey folks, we did a small patch release to address the Xcode 12.5 issue plus the security fix; so now we can go back to "standard" and discuss 0.64.2 over here -> https://github.com/react-native-community/releases/issues/224