search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 404 forks source link

Road to v0.65.0 - RC2 phase #235

Closed kelset closed 3 years ago

kelset commented 3 years ago

This issue serves to track the status of work to reach 0.65.0.

Current latest: 0.65.0-rc.2 Changelog draft PR: https://github.com/react-native-community/releases/pull/234

Known issues

Commits (and PRs) to cherry pick

Non-blocking for RC release

Local commits to backport to main

Please limit your comments to reports of issues encountered with the RC and cherry pick suggestions. No ETA currently for when 0.65.0 will be released.

a-eid commented 3 years ago

RC0:

janicduplessis commented 3 years ago

Could the android crash be https://github.com/facebook/hermes/issues/513?

Titozzz commented 3 years ago

@janicduplessis No it happens on non hermes builds too

kelset commented 3 years ago

@a-eid thanks for reporting - I guess you tested npx react-native init generated projects?

@janicduplessis as pointed out by @Titozzz this happens even in non-hermes builds too, it seems to be caused by some lib.so not getting created/generated so when the App tries to open it looks for them and goes kaboom instead. That said, it could very well be that once we fix this one, the issue you are linking might happen so thanks for surfacing it 😅

a-eid commented 3 years ago

@kelset yes that's correct, shortly after it was released.

android studio logs 

2021-06-09 17:17:46.426 4659-4686/? E/SoLoader: couldn't find DSO to load: libfbjni.so
        SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
        SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/~~hDUiJasd5BMTagPArbh6aQ==/com.rn065-rJuDeCMgpLIn0bRJrxunkA==/lib/arm64 flags = 0]
        SoSource 2: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
        SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
        Native lib dir: /data/app/~~hDUiJasd5BMTagPArbh6aQ==/com.rn065-rJuDeCMgpLIn0bRJrxunkA==/lib/arm64
     result: 0

    --------- beginning of crash
2021-06-09 17:17:46.426 4659-4686/? E/AndroidRuntime: FATAL EXCEPTION: FlipperConnectionThread
    Process: com.rn065, PID: 4659
    java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libfbjni.so
        SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
        SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/~~hDUiJasd5BMTagPArbh6aQ==/com.rn065-rJuDeCMgpLIn0bRJrxunkA==/lib/arm64 flags = 0]
        SoSource 2: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
        SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
        Native lib dir: /data/app/~~hDUiJasd5BMTagPArbh6aQ==/com.rn065-rJuDeCMgpLIn0bRJrxunkA==/lib/arm64
     result: 0
        at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java:918)
        at com.facebook.soloader.SoLoader.loadLibraryBySoNameImpl(SoLoader.java:740)
        at com.facebook.soloader.SoLoader.loadLibraryBySoName(SoLoader.java:654)
        at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:634)
        at com.facebook.soloader.NativeLoaderToSoLoaderDelegate.loadLibrary(NativeLoaderToSoLoaderDelegate.java:29)
        at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:51)
        at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:30)
        at com.facebook.jni.HybridData.<clinit>(HybridData.java:34)
        at com.facebook.flipper.android.FlipperThread.run(FlipperThread.java:25)

seems to be related to flipper, but I'm not sure.

kelset commented 3 years ago

My hope is that it will be fixed by https://github.com/facebook/react-native/pull/31675 but until it's merged and tested we can't be sure

robertying commented 3 years ago

Could this PR https://github.com/facebook/react-native/pull/31062 get looked at and merged? It was in v0.64.2 need-to-merge list but has not been looked at by a maintainer. It unblocks build for Mac Catalyst.

robertying commented 3 years ago

https://github.com/facebook/react-native/commit/b496a531e0b4b5d828077b0e7dff43dd28fed5eb Catalyst PR was merged! Hopefully the commit can go into this release. With the incoming Hermes's build for Mac Catalyst, Catalyst will become very much usable now.

kelset commented 3 years ago

Update on the Android crash problem. Basically, this is rooted in the fact that some build steps for Android during CI don't fail properly so the script thinks that all the artifacts are being generated, and proceeds. With the result that the "react native library" is missing said files -> a generated Android apk crashes on startup because of those files not being there.

Currently, we are not sure of why this happens, but if the script to generate those files gets run twice on the 2nd pass it seems to always generate them properly. Because of this "proven workaround", @Titozzz created this: https://github.com/facebook/react-native/pull/31707/files for the 0.65-stable branch.

That said, I've investigated this problem a bit deeper and here's what I found: the script not generating the artifacts is ./gradlew :ReactAndroid:installArchives. This task was changed by this commit by @dulmandakh https://github.com/facebook/react-native/commit/fc6fc637bb0db9dca07bc25a13e600c93140cf9e to basically be a "backward compatibility" alias for the new way of generating artifacts/publishing dictated by Gradle (before it was a task defined in the ReactAndroid/release.gradle file that the commit removes). In particular, it has become an alias for publishReleasePublicationToNpmRepository which is one of the available tasks for the new Maven Publish Plugin; in particular, it's publishPubNamePublicationToRepoNameRepository.

By reading that documentation, it seems that we could potentially replace all the places where we invoke ./gradlew :ReactAndroid:installArchives with ./gradlew :ReactAndroid:publish, and remove the alias in the ReactAndroid/build.gradle file. My current assumption is that because of that aliasing some errors are not being bubbled up correctly hence the (small) level of checks that we have in place for the command/artifact generation is not picking up the files not being generated.

Anecdotally, I tried to run ./gradlew :ReactAndroid:publish once locally to see if it worked, and it seems to have created all the necessary artifacts on first pass. More testing would help verify if that's the case.

Titozzz commented 3 years ago

The culprit is https://github.com/facebook/react-native/commit/7599593b307b71aebe3184233bd9a5f4478b4c88

What I've noticed before: if you run ./gradlew clean it ends up building many things after:

> Configure project :react-native-gradle-plugin
> Task :react-native-gradle-plugin:compileKotlin
> Task :ReactAndroid:cleanReactNdkLib
(everything below doesn't happend after the update)
> Task :ReactAndroid:downloadBoost
> Task :packages:react-native-codegen:android:buildCodegenCLI
> Task :packages:rn-tester:android:app:generateCodegenSchemaFromJavaScript
> Task :packages:rn-tester:android:app:generateCodegenArtifactsFromSchema
> Task :ReactAndroid:generateCodegenSchemaFromJavaScript
> Task :ReactAndroid:generateCodegenArtifactsFromSchema
> Task :ReactAndroid:downloadDoubleConversion
> Task :ReactAndroid:downloadFolly
> Task :ReactAndroid:downloadGlog
> Task :ReactAndroid:buildReactNdkLib

So when running ./gradlew installArchives it doesn't even re-do the ReactAndroid:buildReactNdkLib step and jni is correctly included

However after the update./gradlew clean only cleans and doesn't rebuild everything so when we run./gradlew installArchives it runs ReactAndroid:buildReactNdkLib but sadly doesn't include jni (on the first run, running it twice fixes it as we saw)

My guess is that:ReactAndroid:buildReactNdkLib or something else need to run before installArchives and before it happened as a side effect (during clean but maybe some other times too) and new gradle broke it.

EDIT: FYI we will revert the PR for now

a-eid commented 3 years ago

there is already a PR for bumping flipper to 0.93 on IOS

https://github.com/facebook/react-native/pull/31708

swrobel commented 3 years ago

I'm unable to build my app on iOS using Xcode 12.5 (intel macOS 11.4). It built fine on 0.64.2. I've used react-native-clean-project and the result is still the same after reinstalling everything.

CompileC Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.o Pods/RCT-Folly/folly/Singleton.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'RCT-Folly' from project 'Pods')
    cd Pods
    export LANG\=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -target x86_64-apple-ios9.0-simulator -fmessage-length\=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit\=0 -std\=c++14 -stdlib\=libc++ -fmodules -fmodules-cache-path\=/Users/ag78784/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -fmodules-prune-interval\=86400 -fmodules-prune-after\=345600 -fbuild-session-file\=/Users/ag78784/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror\=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror\=return-type -Wdocumentation -Wunreachable-code -Werror\=deprecated-objc-isa-usage -Werror\=objc-root-class -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DPOD_CONFIGURATION_DEBUG\=1 -DDEBUG\=1 -DCOCOAPODS\=1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -g -Wno-sign-conversion -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body -Wunguarded-availability -index-store-path Index/DataStore -IBuild/Products/Debug-iphonesimulator/RCT-Folly/include -IPods/Headers/Private -IPods/Headers/Private/RCT-Folly -IPods/Headers/Public -IPods/Headers/Public/DoubleConversion -IPods/Headers/Public/RCT-Folly -IPods/Headers/Public/fmt -IPods/Headers/Public/glog -IPods/Headers/Public/libevent -IPods/RCT-Folly -IPods/boost-for-react-native -IPods/DoubleConversion -IPods/libevent/include -IPods/RCT-Folly -IPods/boost-for-react-native -IPods/DoubleConversion -IPods/libevent/include -IPods/Headers/Public/libevent/event -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources-normal/x86_64 -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources/x86_64 -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources -FBuild/Products/Debug-iphonesimulator/RCT-Folly -DFOLLY_NO_CONFIG -DFOLLY_MOBILE\=1 -DFOLLY_USE_LIBCPP\=1 -DFOLLY_HAVE_PTHREAD\=1 -Wno-comma -Wno-shorten-64-to-32 -Wno-documentation -w -Xanalyzer -analyzer-disable-all-checks -include Pods/Target\ Support\ Files/RCT-Folly/RCT-Folly-prefix.pch -MMD -MT dependencies -MF Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.d --serialize-diagnostics Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.dia -c Pods/RCT-Folly/folly/Singleton.cpp -o Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.o
In file included from Pods/RCT-Folly/folly/Singleton.cpp:35:
In file included from Pods/Headers/Private/RCT-Folly/folly/portability/FmtCompile.h:19:
Pods/Headers/Public/fmt/fmt/compile.h:648:29: error: no matching function for call to 'compile'
  constexpr auto compiled = detail::compile<Args...>(S());
                            ^~~~~~~~~~~~~~~~~~~~~~~~
Pods/RCT-Folly/folly/Singleton.cpp:161:25: note: in instantiation of function template specialization 'fmt::v7::format<FMT_COMPILE_STRING, folly::Range<const char *>, 0>' requested here
  auto const msg = fmt::format(FOLLY_FMT_COMPILE(
                        ^
In file included from Pods/RCT-Folly/folly/Singleton.cpp:35:
In file included from Pods/Headers/Private/RCT-Folly/folly/portability/FmtCompile.h:19:
Pods/Headers/Public/fmt/fmt/compile.h:582:16: note: candidate template ignored: requirement 'is_compile_string<FMT_COMPILE_STRING>::value' was not satisfied [with Args = <folly::Range<const char *>>, S = FMT_COMPILE_STRING]
constexpr auto compile(S format_str) -> detail::compiled_format<S, Args...> {
               ^
Pods/Headers/Public/fmt/fmt/compile.h:589:6: note: candidate template ignored: could not match 'const Char [N]' against 'FMT_COMPILE_STRING'
auto compile(const Char (&format_str)[N])
     ^
1 error generated.
mikehardy commented 3 years ago

On 0.64.3 two new pick requests came in, I suppose since 0.65 branch is already cut they are relevant here?

https://github.com/facebook/react-native/commit/3827ca61714b699c866e17d58b4697dde86e3d00 https://github.com/facebook/react-native/commit/4b9d9dd

When I click through I see one was committed 10 days ago, one 6 days ago so they'll be after the branch cut.

fabOnReact commented 3 years ago

Commit https://github.com/facebook/react-native/commit/3827ca61714b699c866e17d58b4697dde86e3d00 fixes numeric font weights only from Android API 28, and I believe it can wait for the next release. Thanks a lot for the interest! :pray:

kelset commented 3 years ago

quick update: commits so far have been reverted/cherry-picked according to top post (which should include all suggestions from the comments so far) and it will be tested for a bit, if testing shows that we have fixed the Android problem we'll likely to do an RC1 before end of the week.

janicduplessis commented 3 years ago

I'm unable to build my app on iOS using Xcode 12.5 (intel macOS 11.4). It built fine on 0.64.2. I've used react-native-clean-project and the result is still the same after reinstalling everything.

CompileC Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.o Pods/RCT-Folly/folly/Singleton.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (in target 'RCT-Folly' from project 'Pods')
    cd Pods
    export LANG\=en_US.US-ASCII
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x c++ -target x86_64-apple-ios9.0-simulator -fmessage-length\=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit\=0 -std\=c++14 -stdlib\=libc++ -fmodules -fmodules-cache-path\=/Users/ag78784/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -fmodules-prune-interval\=86400 -fmodules-prune-after\=345600 -fbuild-session-file\=/Users/ag78784/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror\=non-modular-include-in-framework-module -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror\=return-type -Wdocumentation -Wunreachable-code -Werror\=deprecated-objc-isa-usage -Werror\=objc-root-class -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wno-newline-eof -Wno-c++11-extensions -DPOD_CONFIGURATION_DEBUG\=1 -DDEBUG\=1 -DCOCOAPODS\=1 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator14.5.sdk -fasm-blocks -fstrict-aliasing -Wdeprecated-declarations -Winvalid-offsetof -g -Wno-sign-conversion -Winfinite-recursion -Wmove -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wrange-loop-analysis -Wno-semicolon-before-method-body -Wunguarded-availability -index-store-path Index/DataStore -IBuild/Products/Debug-iphonesimulator/RCT-Folly/include -IPods/Headers/Private -IPods/Headers/Private/RCT-Folly -IPods/Headers/Public -IPods/Headers/Public/DoubleConversion -IPods/Headers/Public/RCT-Folly -IPods/Headers/Public/fmt -IPods/Headers/Public/glog -IPods/Headers/Public/libevent -IPods/RCT-Folly -IPods/boost-for-react-native -IPods/DoubleConversion -IPods/libevent/include -IPods/RCT-Folly -IPods/boost-for-react-native -IPods/DoubleConversion -IPods/libevent/include -IPods/Headers/Public/libevent/event -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources-normal/x86_64 -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources/x86_64 -IBuild/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/DerivedSources -FBuild/Products/Debug-iphonesimulator/RCT-Folly -DFOLLY_NO_CONFIG -DFOLLY_MOBILE\=1 -DFOLLY_USE_LIBCPP\=1 -DFOLLY_HAVE_PTHREAD\=1 -Wno-comma -Wno-shorten-64-to-32 -Wno-documentation -w -Xanalyzer -analyzer-disable-all-checks -include Pods/Target\ Support\ Files/RCT-Folly/RCT-Folly-prefix.pch -MMD -MT dependencies -MF Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.d --serialize-diagnostics Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.dia -c Pods/RCT-Folly/folly/Singleton.cpp -o Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/RCT-Folly.build/Objects-normal/x86_64/Singleton.o
In file included from Pods/RCT-Folly/folly/Singleton.cpp:35:
In file included from Pods/Headers/Private/RCT-Folly/folly/portability/FmtCompile.h:19:
Pods/Headers/Public/fmt/fmt/compile.h:648:29: error: no matching function for call to 'compile'
  constexpr auto compiled = detail::compile<Args...>(S());
                            ^~~~~~~~~~~~~~~~~~~~~~~~
Pods/RCT-Folly/folly/Singleton.cpp:161:25: note: in instantiation of function template specialization 'fmt::v7::format<FMT_COMPILE_STRING, folly::Range<const char *>, 0>' requested here
  auto const msg = fmt::format(FOLLY_FMT_COMPILE(
                        ^
In file included from Pods/RCT-Folly/folly/Singleton.cpp:35:
In file included from Pods/Headers/Private/RCT-Folly/folly/portability/FmtCompile.h:19:
Pods/Headers/Public/fmt/fmt/compile.h:582:16: note: candidate template ignored: requirement 'is_compile_string<FMT_COMPILE_STRING>::value' was not satisfied [with Args = <folly::Range<const char *>>, S = FMT_COMPILE_STRING]
constexpr auto compile(S format_str) -> detail::compiled_format<S, Args...> {
               ^
Pods/Headers/Public/fmt/fmt/compile.h:589:6: note: candidate template ignored: could not match 'const Char [N]' against 'FMT_COMPILE_STRING'
auto compile(const Char (&format_str)[N])
     ^
1 error generated.

You can add pod "fmt", "~> 6.2.1" temporarily to your podfile and it should fix that build issue. Looks like https://github.com/facebook/react-native/commit/d208e7d6ad4738bc85a0ab78a50c59bddac07174#diff-5de3520951eb222bc3b5b734cc1003e84a53fb42220159fedc58768bda2e2cf3 fixes it on master. We should cherry-pick that.

kelset commented 3 years ago

@janicduplessis thanks for the pointer Janic! I saw @PeteTheHeat's commit but when I read in the PR body that it was fixing an issue for CircleCI I assumed it wasn't needed - but I guess cherry picking it wouldn't harm anyway?

Update: cherry picked

kelset commented 3 years ago

hey folks - we did testing and because we had a double ✅ (two different machines doing the full suite of local e2e tests successfully) we proceeded with RC1. I've updated the top post to reflect the status.

post-release update: it seems that the Android startup crash is still there, at least on my machine. So the investigation is still open for that... 😓 It could be that it's just some caching on my machine for now, so if anyone can test 

npx react-native init RN065 --version 0.65.0-rc.1

And let us know if they still hit the Android startup crash would be great to get some more data points

a-eid commented 3 years ago

@kelset yes the android startup crash is still there IOS is building fine for me on a none M1 machine. ( with / without heremes ).

beetlebum commented 3 years ago

I'm experiencing an error on 0.65.0-rc.1 building for iOS

IPHONEOS_DEPLOYMENT_TARGET = 12.3

duplicate symbol 'folly::detail::str_to_bool(folly::Range<char const*>*)' in:
    /...Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(Conv.o)
    /...Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(Conv.o)
duplicate symbol 'folly::makeConversionError(folly::ConversionCode, folly::Range<char const*>)' in:
    /...Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(Conv.o)
    /...Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(Conv.o)
ld: 2 duplicate symbols for architecture x86_64

From the Podfile.lock:

    - RCT-Folly (= 2021.04.26.00)
  - Flipper (0.93.0):
    - Flipper-Folly (~> 2.6)
    - Flipper-RSocket (~> 1.4)
  - Flipper-Boost-iOSX (1.76.0.1.11)
  - Flipper-DoubleConversion (3.1.7)
  - Flipper-Fmt (7.1.7)
  - Flipper-Folly (2.6.7):
    - Flipper-Boost-iOSX
    - Flipper-DoubleConversion
    - Flipper-Fmt (= 7.1.7)
    - Flipper-Glog
    - libevent (~> 2.1.12)
    - OpenSSL-Universal (= 1.1.180)

I have cleaned the project, reinstalled pods etc.

Any ideas? Thanks

janicduplessis commented 3 years ago

@beetlebum Also noticed this error, seems to be related with the updated Flipper-DoubleConvertion pod. Setting back the version to what it was before fixes it for me.

use_flipper!("Flipper" => "0.93.0", "Flipper-DoubleConversion" => "1.1.7")

I think the problem is because the double conversion version that we use in react native and the one in flipper is different now and clang can’t dedupe de symbols properly anymore. Cc @PeteTheHeat

diego-paired commented 3 years ago

@beetlebum Also noticed this error, seems to be related with the updated Flipper-DoubleConvertion pod. Setting back the version to what it was before fixes it for me.

use_flipper!("Flipper" => "0.93.0", "Flipper-DoubleConversion" => "1.1.7")

I think the problem is because the double conversion version that we use in react native and the one in flipper is different now and clang can’t dedupe de symbols properly anymore. Cc @PeteTheHeat

thanks so much, I'll give it a go

wfern commented 3 years ago

@kelset I tried to run and the RC release continues to crash on Android.

When I ran it for the first time, it appeared in the build logs: 

> Task :app:stripReleaseDebugSymbols
Unable to strip the following libraries, packaging them as they are: libevent-2.1.so, libevent_core-2.1.so, libevent_extra-2.1.so, libflipper.so, libhermes.so, libimagepipeline.so, libnative-filters.so, libnative-imagetranscoder.so.

And when I opened the app and it crashed: 

2021-06-17 16:22:01.372 4551-4551/? I/com.rn065: Not late-enabling -Xcheck:jni (already on)
2021-06-17 16:22:01.392 4551-4551/? E/com.rn065: Unknown bits set in runtime_flags: 0x8000
2021-06-17 16:22:01.394 4551-4551/? W/com.rn065: Unexpected CPU variant for X86 using defaults: x86_64
2021-06-17 16:22:01.811 4551-4551/com.rn065 D/SoLoader: init start
2021-06-17 16:22:01.812 4551-4551/com.rn065 D/SoLoader: adding system library source: /vendor/lib64
2021-06-17 16:22:01.814 4551-4551/com.rn065 D/SoLoader: adding system library source: /system/lib64
2021-06-17 16:22:01.815 4551-4551/com.rn065 D/SoLoader: adding application source: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: adding backup source from : com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: Preparing SO source: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
2021-06-17 16:22:01.820 4551-4551/com.rn065 D/SoLoader: Preparing SO source: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
2021-06-17 16:22:01.821 4551-4551/com.rn065 V/fb-UnpackingSoSource: locked dso store /data/user/0/com.rn065/lib-main
2021-06-17 16:22:01.823 4551-4551/com.rn065 I/fb-UnpackingSoSource: dso store is up-to-date: /data/user/0/com.rn065/lib-main
2021-06-17 16:22:01.824 4551-4551/com.rn065 V/fb-UnpackingSoSource: releasing dso store lock for /data/user/0/com.rn065/lib-main
2021-06-17 16:22:01.824 4551-4551/com.rn065 D/SoLoader: init finish: 4 SO sources prepared
2021-06-17 16:22:01.824 4551-4551/com.rn065 D/SoLoader: init exiting
2021-06-17 16:22:01.845 4551-4551/com.rn065 D/SoLoader: init exiting
2021-06-17 16:22:01.845 4551-4551/com.rn065 D/SoLoader: About to load: libjscexecutor.so
2021-06-17 16:22:01.846 4551-4551/com.rn065 D/SoLoader: libjscexecutor.so not found on /data/data/com.rn065/lib-main
2021-06-17 16:22:01.847 4551-4551/com.rn065 D/SoLoader: libjscexecutor.so not found on /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
2021-06-17 16:22:01.848 4551-4551/com.rn065 D/SoLoader: libjscexecutor.so not found on /vendor/lib64
2021-06-17 16:22:01.848 4551-4551/com.rn065 D/SoLoader: libjscexecutor.so not found on /system/lib64
2021-06-17 16:22:01.850 4551-4551/com.rn065 E/SoLoader: couldn't find DSO to load: libjscexecutor.so
        SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
        SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
        SoSource 2: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
        SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
        Native lib dir: /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
     result: 0
2021-06-17 16:22:01.860 4551-4551/com.rn065 D/SoLoader: init exiting
2021-06-17 16:22:02.166 4551-4551/com.rn065 D/NetworkSecurityConfig: No Network Security Config specified, using platform default
2021-06-17 16:22:02.206 4551-4588/com.rn065 D/SoLoader: About to load: libfbjni.so
2021-06-17 16:22:02.212 4551-4588/com.rn065 D/SoLoader: libfbjni.so not found on /data/data/com.rn065/lib-main
2021-06-17 16:22:02.213 4551-4588/com.rn065 D/SoLoader: libfbjni.so not found on /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
2021-06-17 16:22:02.213 4551-4588/com.rn065 D/SoLoader: libfbjni.so not found on /vendor/lib64
2021-06-17 16:22:02.213 4551-4588/com.rn065 D/SoLoader: libfbjni.so not found on /system/lib64
2021-06-17 16:22:02.216 4551-4588/com.rn065 E/SoLoader: couldn't find DSO to load: libfbjni.so
        SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
        SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
        SoSource 2: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
        SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
        Native lib dir: /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
     result: 0
2021-06-17 16:22:02.218 4551-4589/com.rn065 E/AndroidRuntime: FATAL EXCEPTION: FlipperConnectionThread
    Process: com.rn065, PID: 4551
    java.lang.NoClassDefFoundError: <clinit> failed for class com.facebook.flipper.android.EventBase; see exception in other thread
        at com.facebook.flipper.android.FlipperThread.run(FlipperThread.java:25)
2021-06-17 16:22:02.221 4551-4588/com.rn065 E/AndroidRuntime: FATAL EXCEPTION: FlipperEventBaseThread
    Process: com.rn065, PID: 4551
    java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libfbjni.so
        SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/com.rn065/lib-main flags = 1]
        SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64 flags = 0]
        SoSource 2: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2]
        SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2]
        Native lib dir: /data/app/com.rn065-DSoWq7RqN-espDYKSZsemg==/lib/x86_64
     result: 0
        at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java:918)
        at com.facebook.soloader.SoLoader.loadLibraryBySoNameImpl(SoLoader.java:740)
        at com.facebook.soloader.SoLoader.loadLibraryBySoName(SoLoader.java:654)
        at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java:634)
        at com.facebook.soloader.NativeLoaderToSoLoaderDelegate.loadLibrary(NativeLoaderToSoLoaderDelegate.java:29)
        at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:51)
        at com.facebook.soloader.nativeloader.NativeLoader.loadLibrary(NativeLoader.java:30)
        at com.facebook.jni.HybridData.<clinit>(HybridData.java:34)
        at com.facebook.flipper.android.FlipperThread.run(FlipperThread.java:25)
2021-06-17 16:22:02.221 4551-4588/com.rn065 I/Process: Sending signal. PID: 4551 SIG: 9

I hope I have helped in something.

Titozzz commented 3 years ago

RC1 still has issue with android!

Cherry picking this will hopefully definitely solve it : https://github.com/facebook/react-native/commit/6be4f2b2c8c66c4f5eb47717353f59c768c0889f

Also we can revert both reverts as they are not needed for the fix to work. Here is a tarball if anyone want to try locally and don't want to wait the next RC: react-native-0.65.0-rc.1.tgz.zip

YaoHuiJi commented 3 years ago

hi, I am confused after I read the change log of v0.65.0, since DatePicker was deprecated and removed from react-native, why these changes are committed to react-native not @react-native-datetimepicker/datetimepicker ? should I use DatePicker back again ?

  • Expose UIDatePickerStyles as a prop for DatePickerIOS (266b21baf3)

  • Expose UIDatePickerStyles as a prop for DatePickerIOS (2b62e19a78)

kelset commented 3 years ago

Hey folks, thanks to @Titozzz and @ShikaSD we managed to find a way to correctly fix the Android artifacts not being generated on CI, so we did a couple of re-reverts and added the fix on top and now RC2 is out and Android works 🚀 (or well at least it doesn't crash on startup which is nice 😅)

I've updated the top post to reflect the status.

@janicduplessis @beetlebum can either of you setup some repro steps for the issue you are reporting? @mweststrate has this PR up https://github.com/facebook/react-native/pull/31708 so if the issue is around Flipper 0.93 on iOS that'd be the place to fix it.

I've naively thought that these steps would repro:

But at least on my machine iOS builds successfully anyway.

@YaoHuiJi I think I can understand your confusion, and while I don't have the correct answer I'm going to assume that FB internally still uses DatePickerIOS. I think that you should ask the maintainers of datetimepicker if they will make sure to "repeat" those changes in their repo, and keep using their library.

mweststrate commented 3 years ago

@janicduplessis @beetlebum I recommend to stick to the defaults (use_flipper!()) for now, that is on 0.91.x. Version 0.93 doesn't introduce anything new for iOS, but has some build conflicts due to (unrelated) issues in fmt + RTC-folly which need to be solved first before we can even attempt to update Flipper. The overrides are only meant to be used in case the default settings don't suffice (anymore) for some reason. Does removing the version specifier remove the issue?

ahmetbicer commented 3 years ago

Flipper version bump for iOS merged to master. https://github.com/facebook/react-native/commit/848d59947c4c31b35fcd66459afc0068e767ecae

swrobel commented 3 years ago

I would actually recommend bumping Flipper to 0.94.x (current release is 0.94.1) as it includes a fix for incorrect timestamps in the Network viewer on iOS

janicduplessis commented 3 years ago

I think one blocking issue is update hermes to 0.8.1 as there is a pretty bad crash with the new Intl implmentation. See https://github.com/facebook/hermes/issues/528. Just need a new release on hermes side.

kelset commented 3 years ago

@janicduplessis yes that's pretty much my understanding too - the main thing separating us from a .0 currently is Hermes 0.8.1

myckhel commented 3 years ago

Please will v0.65 enable turbomodules support?

kelset commented 3 years ago

@myckhel https://github.com/react-native-community/discussions-and-proposals/issues/40#issuecomment-801472114

birkir commented 3 years ago

Im having a hard time knowing what was cherry picked and what not, so just for clarity as it’s not in the latest RC:

These two for DynamicColorIOS

beetlebum commented 3 years ago

We've been testing 0.65rc-2 but have had to go back to 0.64 due to a few blocking issues, that I'm listing here as they might affect other people:

geraintwhite commented 3 years ago

facebook/react-native@2f477b1 allows jest 27 to work with react-native. Please can we include this?

SConaway commented 3 years ago

Really hope this hasn't been mentioned here, and I'm sorry if it has been. Just thought it should get fixed for when 0.65.0 is released

On a brand-new 0.65.0-rc.2 app, without Hermes, I am unable to create a release build for the iOS Simulator when building from an Intel Mac either in XCode or the CLI (in case it matters, I'm running Monterey dev beta 2 with XCode 13.0 beta 1, but it doesn't work on release XCode 12.5 either).

Output from react-native doctor:

``` $ yarn react-native doctor yarn run v1.22.10 $ /Users/steven/AwesomeProject/node_modules/.bin/react-native doctor Common ✓ Node.js ✓ yarn ✖ Watchman - Used for watching changes in the filesystem when in development mode [seems not to have any effect on anything, still works] - Version found: 2021.06.07.00 - Version supported: 4.x Android ✓ JDK ✓ Android Studio - Required for building and installing your app on Android ✖ Android SDK - Required for building and installing your app on Android [seems not to have any effect on anything, still works] - Versions found: N/A - Version supported: 30.0.2 ✓ ANDROID_HOME iOS ✓ Xcode - Required for building and installing your app on iOS ✓ CocoaPods - Required for installing iOS dependencies ✓ ios-deploy - Required for installing your app on a physical device with the CLI Errors: 2 Warnings: 0 ```

Additionally, see this issue / comment for more details: https://github.com/facebook/react-native/issues/31179#issuecomment-831872601

dulmandakh commented 3 years ago

[edited by @mikehardy to add...] merged as https://github.com/facebook/react-native/commit/6caec9d91fe71bcd80d670218d752c4f251bde81

mikehardy commented 3 years ago

@kelset just a note that I edited the actual description way up at the top to re-point the Hermes + iOS + Apple Silicon build PR to point to the current one with activity just today. Looks like it will land shortly, appears to me it is in final-fixups mode with main contributors all collaborating + pushing it through - PR landed!! Just needs a Hermes release I suppose? Commit reference noted at the top for release tag inspection when+if. Nice, hermes team.

teniii commented 3 years ago

Hello. I've upgraded to RN 0.65.0-rc.2 and after removing completely the RN Reanimated and all the libraries depending on it, I've managed to build on Android, but when launching, the app crashes (both with and without Hermes). Seems there is something wrong with the MMKV module installing. I don't know if here is the right place to write, but I don't know where else i can ask this question. Hope this is on the topic, helping for releasing.

The log in Flipper contains:

Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x2 in tid 8277 (create_react_co), pid 8159
Build fingerprint: 'google/sdk_gphone_x86_arm/generic_x86_arm:9/PSR1.180720.122/6736742:userdebug/dev-keys'
Revision: '0'
ABI: 'x86'
Cause: null pointer dereference 
   eax 00000002  ebx c94ea784  ecx 00000002  edx be978244
   edi be9782c8  esi c94bd2c0
   ebp be9781a8  esp be978180  eip c94bf56b

And then the backtrace:

19:48:00.256
8295
DEBUG
    #00 pc 0002856b  /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/lib/x86/libjscexecutor.so (facebook::jsc::JSCRuntime::valueRef(facebook::jsi::Value const&)+27)
19:48:00.256
8295
DEBUG
    #01 pc 00029165  /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/lib/x86/libjscexecutor.so (facebook::jsc::JSCRuntime::setValueAtIndexImpl(facebook::jsi::Array&, unsigned int, facebook::jsi::Value const&)+69)
19:48:00.256
8295
DEBUG
    #02 pc 00021372  /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/lib/x86/libmmkvnative.so (install(facebook::jsi::Runtime&)+178)
19:48:00.256
8295
DEBUG
    #03 pc 00022252  /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/lib/x86/libmmkvnative.so (Java_com_reactnativemmkv_MmkvModule_nativeInstall+114)
19:48:00.256
8295
DEBUG
    #04 pc 005f6a17  /system/lib/libart.so (art_quick_generic_jni_trampoline+71)
19:48:00.256
8295
DEBUG
    #05 pc 005f0bd2  /system/lib/libart.so (art_quick_invoke_static_stub+418)
19:48:00.256
8295
DEBUG
    #06 pc 000a2f5f  /system/lib/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+239)
19:48:00.256
8295
DEBUG
    #07 pc 0029bb22  /system/lib/libart.so (art::interpreter::ArtInterpreterToCompiledCodeBridge(art::Thread*, art::ArtMethod*, art::ShadowFrame*, unsigned short, art::JValue*)+338)
19:48:00.256
8295
DEBUG
    #08 pc 00293cc8  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1048)
19:48:00.256
8295
DEBUG
    #09 pc 005bdb1f  /system/lib/libart.so (MterpInvokeStatic+207)
19:48:00.256
8295
DEBUG
    #10 pc 005e2d21  /system/lib/libart.so (ExecuteMterpImpl+14625)
19:48:00.256
8295
DEBUG
    #11 pc 000773cc  /dev/ashmem/dalvik-classes2.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk!classes2.dex (deleted) (com.reactnativemmkv.MmkvModule.install+8)
19:48:00.256
8295
DEBUG
    #12 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.256
8295
DEBUG
    #13 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.256
8295
DEBUG
    #14 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.256
8295
DEBUG
    #15 pc 005bdb1f  /system/lib/libart.so (MterpInvokeStatic+207)
19:48:00.256
8295
DEBUG
    #16 pc 005e2d21  /system/lib/libart.so (ExecuteMterpImpl+14625)
19:48:00.256
8295
DEBUG
    #17 pc 00000eea  /dev/ashmem/dalvik-classes4.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk!classes4.dex (deleted) (com.app.AppJSIPackage.getJSIModules+50)
19:48:00.256
8295
DEBUG
    #18 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.256
8295
DEBUG
    #19 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.256
8295
DEBUG
    #20 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.256
8295
DEBUG
    #21 pc 005bd434  /system/lib/libart.so (MterpInvokeInterface+1444)
19:48:00.256
8295
DEBUG
    #22 pc 005e2da1  /system/lib/libart.so (ExecuteMterpImpl+14753)
19:48:00.256
8295
DEBUG
    #23 pc 0041cb3e  /dev/ashmem/dalvik-classes.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk (deleted) (com.facebook.react.ReactInstanceManager.createReactContext+346)
19:48:00.256
8295
DEBUG
    #24 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.256
8295
DEBUG
    #25 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.257
8295
DEBUG
    #26 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.257
8295
DEBUG
    #27 pc 005bd926  /system/lib/libart.so (MterpInvokeDirect+342)
19:48:00.257
8295
DEBUG
    #28 pc 005e2ca1  /system/lib/libart.so (ExecuteMterpImpl+14497)
19:48:00.257
8295
DEBUG
    #29 pc 0041c9c8  /dev/ashmem/dalvik-classes.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk (deleted) (com.facebook.react.ReactInstanceManager.access$1100)
19:48:00.257
8295
DEBUG
    #30 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.257
8295
DEBUG
    #31 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.257
8295
DEBUG
    #32 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.257
8295
DEBUG
    #33 pc 005bdb1f  /system/lib/libart.so (MterpInvokeStatic+207)
19:48:00.257
8295
DEBUG
    #34 pc 005e2d21  /system/lib/libart.so (ExecuteMterpImpl+14625)
19:48:00.257
8295
DEBUG
    #35 pc 0041c0c8  /dev/ashmem/dalvik-classes.dex extracted in memory from /data/app/com.app-PPMsosoGbf6XrYvexaMjWg==/base.apk (deleted) (com.facebook.react.ReactInstanceManager$5.run+140)
19:48:00.257
8295
DEBUG
    #36 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.257
8295
DEBUG
    #37 pc 0026c61c  /system/lib/libart.so (art::interpreter::ArtInterpreterToInterpreterBridge(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*, art::JValue*)+220)
19:48:00.257
8295
DEBUG
    #38 pc 00293cab  /system/lib/libart.so (bool art::interpreter::DoCall<false, false>(art::ArtMethod*, art::Thread*, art::ShadowFrame&, art::Instruction const*, unsigned short, art::JValue*)+1019)
19:48:00.257
8295
DEBUG
    #39 pc 005bd434  /system/lib/libart.so (MterpInvokeInterface+1444)
19:48:00.257
8295
DEBUG
    #40 pc 005e2da1  /system/lib/libart.so (ExecuteMterpImpl+14753)
19:48:00.257
8295
DEBUG
    #41 pc 000ca806  /system/framework/boot.vdex (java.lang.Thread.run+12)
19:48:00.257
8295
DEBUG
    #42 pc 00266096  /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadERKNS_20CodeItemDataAccessorERNS_11ShadowFrameENS_6JValueEb.llvm.3007865774+598)
19:48:00.257
8295
DEBUG
    #43 pc 0026c50e  /system/lib/libart.so (art::interpreter::EnterInterpreterFromEntryPoint(art::Thread*, art::CodeItemDataAccessor const&, art::ShadowFrame*)+126)
19:48:00.257
8295
DEBUG
    #44 pc 005a93fd  /system/lib/libart.so (artQuickToInterpreterBridge+1277)
19:48:00.257
8295
DEBUG
    #45 pc 005f6aed  /system/lib/libart.so (art_quick_to_interpreter_bridge+77)
19:48:00.257
8295
DEBUG
    #46 pc 005f0a02  /system/lib/libart.so (art_quick_invoke_stub+338)
19:48:00.257
8295
DEBUG
    #47 pc 000a2f4e  /system/lib/libart.so (art::ArtMethod::Invoke(art::Thread*, unsigned int*, unsigned int, art::JValue*, char const*)+222)
19:48:00.257
8295
DEBUG
    #48 pc 004d3209  /system/lib/libart.so (art::(anonymous namespace)::InvokeWithArgArray(art::ScopedObjectAccessAlreadyRunnable const&, art::ArtMethod*, art::(anonymous namespace)::ArgArray*, art::JValue*, char const*)+89)
19:48:00.257
8295
DEBUG
    #49 pc 004d44b7  /system/lib/libart.so (art::InvokeVirtualOrInterfaceWithJValues(art::ScopedObjectAccessAlreadyRunnable const&, _jobject*, _jmethodID*, jvalue*)+471)
19:48:00.257
8295
DEBUG
    #50 pc 0050944c  /system/lib/libart.so (art::Thread::CreateCallback(void*)+1484)
19:48:00.257
8295
DEBUG
    #51 pc 0008f065  /system/lib/libc.so (__pthread_start(void*)+53)
19:48:00.257
8295
DEBUG
    #52 pc 0002485b  /system/lib/libc.so (__start_thread+75)
sertony commented 3 years ago

Hey, we’d like to have the following PR code in the upcoming release: https://github.com/facebook/react-native/pull/31789

It fixes the support for blobs larger than 64 KB on Android (check the issue: https://github.com/facebook/react-native/issues/31774)

How can we accomplish it? Apparently it requires to trigger Facebook team to start reviewing it.

teniii commented 3 years ago

Hello. I've upgraded to RN 0.65.0-rc.2 and after removing completely the RN Reanimated and all the libraries depending on it, I've managed to build on Android, but when launching, the app crashes (both with and without Hermes). Seems there is something wrong with the MMKV module installing. I don't know if here is the right place to write, but I don't know where else i can ask this question. Hope this is on the topic, helping for releasing.

Hello. I come with an update. After removing the MMKV library, I've launched the app and immediately the bundle crashed with the following message: 

/RN065RC2/node_modules/metro-hermes-compiler/src/emhermesc.js:77
          throw ex;
          ^

RuntimeError: abort(TypeError: Cannot read property 'toUpperCase' of undefined). Build with -s ASSERTIONS=1 for more info.
    at process.abort (/RN065RC2/node_modules/metro-hermes-compiler/src/emhermesc.js:440:13)
    at process.emit (node:events:406:35)
    at emit (node:internal/process/promises:136:22)
    at processPromiseRejections (node:internal/process/promises:242:25)
    at processTicksAndRejections (node:internal/process/task_queues:97:32)
Process terminated. Press <enter> to close the window

At this point, not being able to find other similar issues with this error, I've decided to test a new dummy React-Native project, to see if the issues is in my existing setup. I've followed the instructions presented in the releases page https://github.com/facebook/react-native/releases and the error is still occurring (with and without hermes) inside the newly created project. Is this a known issue?

kelset commented 3 years ago

@teniii if the error still occurs in a freshly generated project:

npx react-native init RN065RC2 --version 0.65.0-rc.2

Then it's likely that it's something with your existing setup.

a-eid commented 3 years ago

@kelset issue happens with a freshly generated project.

kelset commented 3 years ago

Understood - looks like we have a x3 confirmation (tenii, a-eid, tido64) of this metro-hermes-compiler/src/emhermesc error being thrown - so it's something we'll have to pay attention to when preparing the next RC. We are still waiting on Hermes for that.

mweststrate commented 3 years ago

I think I experienced this once, because I had either an old version of node, or an old version of ws package locked in my lockfile / resolutions. Might be totally unrelated, just sounded familiar.

On Wed, 14 Jul 2021, 09:16 Lorenzo Sciandra, @.***> wrote:

Understood - looks like we have a x3 confirmation (tenii, a-eid, tido64) of this metro-hermes-compiler/src/emhermesc error being thrown - so it's something we'll have to pay attention to when preparing the next RC. We are still waiting on Hermes for that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/react-native-community/releases/issues/235#issuecomment-879693698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4NBDAJFVBBWSIUROZX3TTXVBXTANCNFSM46MHDFRQ .

a-eid commented 3 years ago

@mweststrate could be the issue, I'm using v12.16.3, will try to update to >= LTS 14.17.13, test and report back.

sertony commented 3 years ago

@kelset Hi! We've managed to successfully merge this blob fix for Android into the master: https://github.com/facebook/react-native/commit/f00e348ca7f031c3577b1335a3163bc3e4eb4b41

Can we cherry-pick it to the upcoming 0.65.0 release now? Thanks.

myckhel commented 3 years ago

*Opinion

I feel react-native development is too slow. i expected more given the fact that it has more users.

sometimes it could be only just one commit pushed to the repo for an entire day.

i've always been waiting for the re-architecture for a while but its almost taking forever for at least 3 years now.

i feel the community should not have allowed the slow development and ginger the contributors in one way or the other.

due to the frustration of not getting glimpse of when the re-architecture will be rolled out, i've already started eyeing flutter.

i hope the react-native community will turbo the development and give us all hope that will prevent us from eyeing another framework.

teniii commented 3 years ago

I think I experienced this once, because I had either an old version of node, or an old version of ws package locked in my lockfile / resolutions. Might be totally unrelated, just sounded familiar. … On Wed, 14 Jul 2021, 09:16 Lorenzo Sciandra, @.***> wrote: Understood - looks like we have a x3 confirmation (tenii, a-eid, tido64) of this metro-hermes-compiler/src/emhermesc error being thrown - so it's something we'll have to pay attention to when preparing the next RC. We are still waiting on Hermes for that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#235 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAN4NBDAJFVBBWSIUROZX3TTXVBXTANCNFSM46MHDFRQ .

I've checked and I use v16.3.0 for Node. I don't know if this is the cause, but I can say that on this version it doesn't work.