search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 407 forks source link

Upcoming v0.65.1 cherrypicks discussion #244

Closed kelset closed 2 years ago

kelset commented 2 years ago

Conversations on this thread are limited to 0.65 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.65.0 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: https://github.com/facebook/react-native/commit/bd2b7d6c0366b5f19de56b71cb706a0af4b0be43

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

List of PRs & cherry picks requested

Local commits to backport to main

Theofilos-Chamalis commented 2 years ago

First of all thank you very much for the release of v0.65! I 've tested it on an existing app and with Hermes enabled it feels even snappier on Android :)

What I'd like to request for v0.65.1 if possible is a bugfix that was mentioned on the v0.65 discussion about the taps on views outside parent bounds that are not working on Android. The PR link (if I am correct) is the following: https://github.com/facebook/react-native/commit/e35a963bfb93bbbdd92f4dd74d14e2ad6df5e14a and hopefully we could see this in the next release!

Cheers and thanks again for your work!

TheSavior commented 2 years ago

First of all thank you very much for the release of v0.65! I 've tested it on an existing app and with Hermes enabled it feels even snappier on Android :)

What I'd like to request for v0.65.1 if possible is a bugfix that was mentioned on the v0.65 discussion about the taps on views outside parent bounds that are not working on Android. The PR link (if I am correct) is the following: facebook/react-native@e35a963 and hopefully we could see this in the next release!

Cheers and thanks again for your work!

That change is pretty major, and while it makes sense that people want it in a release, it might make sense to bake it longer at Facebook in case it needs to be reverted or tweaked to be stable at scale in the Facebook app.

truongngodang commented 2 years ago

I got a issue when start app build release on ios rn 0.65 'RCTFatalException: Could not get BatchedBridge, make sure your bundle is packaged correctly', reason: 'Could not get BatchedBridge, make sure your bundle is packaged correctly'

mrousavy commented 2 years ago

@truongngodang does that happen in the bare React Native template or in your own app? If it's happening in your own app, please check if it's also happening in the template. If not, you might have missed something while upgrading.

Bardiamist commented 2 years ago

I noticed that react-test-renderer still 17.0.1 in RN 0.65.0. But react is up to 17.0.2. Should I use 17.0.1 or 17.0.2? Maybe need to cherry pick https://github.com/facebook/react-native/commit/d27288044e94a248982f596e9885d55d066bc72e

kelset commented 2 years ago

@Bardiamist good catch, I'll add it to the list

taylorkline commented 2 years ago

facebook/react-native@842bcb902ed27928255b60cb20524e9318d9bf70 should fix a regression on Android where suddenly some components are transparent. Would be nice to have cherry-picked if it applies cleanly.

vskavgaci commented 2 years ago

log keypress events from numeric keys on android fix https://github.com/facebook/react-native/commit/bd52916a0ecaad5d3ce2aa4691b3426abd7930c2

kelset commented 2 years ago

@vskavgaci I don't know where you've found that commit but is not in the repo:

Screenshot 2021-08-19 at 11 11 52

So it can't be cherry picked

matt-oakes commented 2 years ago

@kelset It looks to be from this unmerged PR. So yes, it can't be cherry picked until it's merged in

kelset commented 2 years ago

gotcha, thanks @matt-oakes 👍

Bardiamist commented 2 years ago

facebook/react-native@842bcb9 should fix a regression on Android where suddenly some components are transparent. Would be nice to have cherry-picked if it applies cleanly.

Yea, seems I waiting this fix because after update to React native 0.65.0 a transparent headers (react-navigation headerTransparent: true) on Android is untouchable (even back button).

kelset commented 2 years ago

the 4 commits listed in the top post are cherry picked cleanly - already on the 0.65 branch. Local testing looks ✅ just waiting for a couple feedbacks then probably we'll do a quick 0.65.1 before end of the week

gaodeng commented 2 years ago

https://github.com/facebook/react-native/issues/31461 RefreshControl causes an unwanted visual jump in the list content when the refreshing prop goes from true to false

The commit causing the problem is this one https://github.com/facebook/react-native/commit/1b0fb9bead4d158d14df5a994423d06716b5e377, PR is this one https://github.com/facebook/react-native/pull/28236 Can you revert this commit?

@dandre-hound it is safe to rollback this commit if you don't use navigation large headers. Will work on a fix asap.

Originally posted by the PR author @yogevbd in https://github.com/facebook/react-native/issues/28236#issuecomment-891730388

dandre-hound commented 2 years ago

Yeah, the team @tradehounds is surprised that this pull to refresh issue mentioned above has been present in the last two minor react-native releases. It's pretty disruptive to the user experience when using lists. It's also very easily reproducible and could be cleanly reverted. We've been waiting to upgrade until this is either reverted or a fix from the original PR author is merged in. Would love to see this commit reverted until then :)

nextlevelbeard commented 2 years ago

I believe the test automation community would highly appreciate these: facebook/react-native@efb359f (facebook/react-native#31865) facebook/react-native@91cac20 (facebook/react-native#31942)

Small but important fixes to the testID prop on Android builds. It is currently not working with certain important components like TextInput and ScrollView.

kelset commented 2 years ago

hey folks, we wanted to make sure to do a quick patch with the few important fixes right away so we have already released a 0.65.1 release.

Let's move the conversation here for 0.65.2 -> https://github.com/react-native-community/releases/issues/245 (which won't come out as fast)