search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 404 forks source link

Upcoming v0.65.2 cherrypicks discussion #245

Closed kelset closed 3 years ago

kelset commented 3 years ago

Conversations on this thread are limited to 0.65 releases major issues and backport (cherry-pick) requests from commits that are already on master.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.65.1 cut, with a link to the specific commit hash on master with the commit to cherry-pick, like this example link: https://github.com/facebook/react-native/commit/bd2b7d6c0366b5f19de56b71cb706a0af4b0be43

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

List of cherry picks

Local commits to backport to main

danielgindi commented 3 years ago

https://github.com/facebook/react-native/commit/e35a963bfb93bbbdd92f4dd74d14e2ad6df5e14a

This is a fix for a bug that has been waiting for years, with a 2 year old PR by me and the one actually merged by @hsource. It's a weird it was not merged into this release.

nextlevelbeard commented 3 years ago

I believe the test automation community would highly appreciate these: facebook/react-native@efb359f (facebook/react-native#31865) facebook/react-native@91cac20 (facebook/react-native#31942)

Small but important fixes to the testID prop on Android builds. It is currently not working with certain important components like TextInput and ScrollView.

liamjones commented 3 years ago

@danielgindi that was commented on in the last thread: https://github.com/react-native-community/releases/issues/244#issuecomment-900823137

That change is pretty major, and while it makes sense that people want it in a release, it might make sense to bake it longer at Facebook in case it needs to be reverted or tweaked to be stable at scale in the Facebook app.

Bardiamist commented 3 years ago

facebook/react-native@e35a963

This is a fix for a bug that has been waiting for years, with a 2 year old PR by me and the one actually merged by @hsource. It's a weird it was not merged into this release.

By some reason after update React native from 0.64.2 to 0.65.0 (and 0.65.1) a transparent headers (react-navigation headerTransparent: true) on Android is untouchable (even back button). It's strange because worked fine in react-native@0.64.2. Looks critical for many users. Interesting why it's broken and will it help or no https://github.com/facebook/react-native/commit/e35a963bfb93bbbdd92f4dd74d14e2ad6df5e14a

danielgindi commented 3 years ago

facebook/react-native@e35a963

This is a fix for a bug that has been waiting for years, with a 2 year old PR by me and the one actually merged by @hsource. It's a weird it was not merged into this release.

By some reason after update React native from 0.64.2 to 0.65.0 (and 0.65.1) a transparent headers (react-navigation headerTransparent: true) on Android is untouchable (even back button). It's strange because worked fine in react-native@0.64.2. Looks critical for many users. Interesting why it's broken and will it help or no https://github.com/facebook/react-native/commit/e35a963bfb93bbbdd92f4dd74d14e2ad6df5e14a

I do not believe that it has anything to do with overflows, so no, the fix for overflow touches won't help you with that.

ghost commented 3 years ago

Hello, on version 0.65.1 we are facing some EventEmitter related warning. image

Searching for it it seems that all of them are inside ReactNative. What are the chances of fixing it for the next version?

Is there any workaround?

elicwhite commented 3 years ago

@emilioheinz, what is the callsite for that? I'd expect the warning to come from RN, but I thought we migrated all the internal callsites. Are you sure that isn't being called in your product or a 3rd party module? If it is called from core can you link to the line?

jonnyandrew commented 3 years ago

https://github.com/facebook/react-native/commit/c18a492858e94b31e632560ad17499012e688158 would be much appreciated! 😊

ghost commented 3 years ago

Sorry about that, what I didn't see is that the actual call is inside React Navigation and not React Native. Thank you @TheSavior

mikehardy commented 3 years ago

The event emitter comments were marked off-topic, and this may be as well but it's my experience that all the EventEmitter warnings are 3rd party modules, and as a maintainer we're working through them as fast as possible, but there are a lot. You'll just have to watch your modules and post PRs as you can, e.g. https://github.com/software-mansion/react-native-reanimated/issues/2297 https://github.com/react-native-netinfo/react-native-netinfo/pull/487 https://github.com/invertase/react-native-firebase/pull/5616 https://github.com/notifee/react-native-notifee/pull/368 https://github.com/react-native-device-info/react-native-device-info/pull/1289

etc etc etc :-). Please help with PRs if you can!

efstathiosntonas commented 3 years ago

I believe this should be fixed too: https://github.com/facebook/react-native/issues/32054, not a cherry pick but...

tido64 commented 3 years ago

I believe this should be fixed too: facebook/react-native#32054, not a cherry pick but...

Please leave a comment in the PR where the types are being updated: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/55354

dandre-hound commented 3 years ago

Just resurfacing this 0.65.1 cherry pick discussion topic: https://github.com/react-native-community/releases/issues/244#issuecomment-901905945

facebook/react-native#31461 RefreshControl causes an unwanted visual jump in the list content when the refreshing prop goes from true to false

The commit causing the problem is this one facebook/react-native@1b0fb9b, PR is this one facebook/react-native#28236

Originally posted by the PR author @yogevbd in facebook/react-native#28236 (comment)

We believe this commit should be reverted until a proper fix is put in place. For the last two minor releases, pull to refresh on any type of list results in a visual jump that makes the refresh experience awkward and not smooth. The intent of the original PR was to fix this issue on large header styles, but the issue now appears on all non-large header styles. The issue is also easily reproducible and could be reverted cleanly.

llr101 commented 3 years ago

There maybe something error, Can you help me? Thank you very much~~~ https://github.com/facebook/react-native/issues/32105

mikehardy commented 3 years ago

I recognize 0.65.2 may or may not happen, but if it does this is important for anyone using javascript debugging (which is a lot of people...) to avoid a redbox facebook/react-native@49b3b31

RigottiG commented 3 years ago

facebook/react-native@e35a963

This is a fix for a bug that has been waiting for years, with a 2 year old PR by me and the one actually merged by @hsource. It's a weird it was not merged into this release.

By some reason after update React native from 0.64.2 to 0.65.0 (and 0.65.1) a transparent headers (react-navigation headerTransparent: true) on Android is untouchable (even back button). It's strange because worked fine in react-native@0.64.2. Looks critical for many users. Interesting why it's broken and will it help or no facebook/react-native@e35a963

I do not believe that it has anything to do with overflows, so no, the fix for overflow touches won't help you with that.

Actually, I tested it with version v0.66.0-rc.0 which has these fixes https://github.com/facebook/react-native/commit/e35a963bfb93bbbdd92f4dd74d14e2ad6df5e14a and apparently it fixes the react-navigation problem too.

U can see more details about react-navigation's issue here

It would be very important to cherry-pick these fixes in version 0.65.2.

ghost commented 3 years ago

Do we have any expectations to release this version? I'm just asking because the https://github.com/facebook/react-native/commit/e35a963bfb93bbbdd92f4dd74d14e2ad6df5e14a fix is really important for us.

Thank you for the hard work!

danielgindi commented 3 years ago

Actually, I tested it with version v0.66.0-rc.0 which has these fixes https://github.com/facebook/react-native/commit/e35a963bfb93bbbdd92f4dd74d14e2ad6df5e14a and apparently it fixes the react-navigation problem too.

Although this may work with the overflow fix- it would only be a workaround. The reason for the regression in behavior is not lack of overflow touches, as this has always been the case. It is probably some dimensions issue with react-navigation. It should better be fixed at source before the bug comes later and bites you in the behind.

r0b0t3d commented 3 years ago

https://github.com/facebook/react-native/commit/7edf9274cf6d3398075c19cd1cb020a5d6a346a2

Fix keyboardDismissMode="on-drag" on Android

mikehardy commented 3 years ago

@r0b0t3d you will definitely want to propose this on #246 as well - 0.66 is closing in on release and 0.65.2 may never hapepn

kelset commented 3 years ago

hey folks, it's likely that at least one more patch for 0.65 will happen; I've updated the top post with the commits that have been requested so far that I feel confident we could (at least try to) cherry pick.

This leaves out (unless I missed something):

I won't be working on this today but wanted to check the status here and provide an update.

christianbach commented 3 years ago

Would be great if you could consider picking: https://github.com/facebook/react-native/commit/29249e1

Summary: This change allows native activities and fragments to also handle onActivityResult callbacks, in addition to sending the result to React Native.

ghost commented 3 years ago

@kelset Any updates? I Saw that there are plans to release 0.66.4 next week...

kelset commented 3 years ago

Yes the current focus is all on 0.66 (rc4 was just released). I haven't had time to work on a patch release for 0.65, so it's likely that we'll just ask folks to update to 0.66 since it's basically the first release that will still be "pretty close" to main branch and will make things easier looking ahead.

ghost commented 3 years ago

Nice! Thank you.

ghost commented 3 years ago

@kelset I think this issue can be closed since there is already a stable 0.66.0 version.

kelset commented 3 years ago

yeah, sorry was off sick these past few days. Let's close this. Hopefully migration to 0.66 will be smooth for y'all 🤞