search

react-native-community / releases

React Native releases
https://github.com/facebook/react-native/
1.5k stars 407 forks source link

Road to 0.66.0 #246

Closed lunaleaps closed 2 years ago

lunaleaps commented 2 years ago

The branch cut has happened.

Notice

Release Process

Checklist

Retrospective Topics

Release Status

0.66.0 (shipped!)

0.66.0-rc.4

Picks for 0.66.0-rc.4

Picks for 0.66.0-rc.3

mikehardy commented 2 years ago

Just a quick :crossed_fingers: that the necessary iOS codegen / FBReactNativeSpec etc files are committed on the branch - I think they are still necessary after branch cut. Cheers

NickGerleman commented 2 years ago

We will news to cherry pick https://github.com/facebook/react-native/pull/32074 once merged to fix the ability for apps to run jest tests.

kuasha420 commented 2 years ago

RC is already out !!! https://npmjs.com/package/react-native/v/0.66.0-rc.0

fkgozali commented 2 years ago

[Pick Request] https://github.com/facebook/react-native/commit/49b3b31d8e706338dac4ced1b372424d7d1d133f

This is to address error logbox when connecting to Chrome debugger.

heroic commented 2 years ago

Any specific reason for this to be 66 and not 65.2?

NickGerleman commented 2 years ago

@heroic 0.66 is coming soon after 0.65, but the jump from 0.65 to 0.66 has four months of commits! Some of these are breaking changes that we are working on documenting, like the removal of some deprecated components like Picker.

heroic commented 2 years ago

@NickGerleman Got it! Is this also the version that will include Fabric feature flag? I remember somewhere that it was planned for 66.

fkgozali commented 2 years ago

Is this also the version that will include Fabric feature flag? I remember somewhere that it was planned for 66.

@heroic if you meant whether 0.66 will have Fabric opt-in enabled in the app template, no it will not. We're still working out the details for the playbook to enable it. Meanwhile, RNTester in main/0.65 already has some setup for Fabric enabled, which you can take a look as a reference.

fkgozali commented 2 years ago

[Pick Request] https://github.com/facebook/react-native/commit/945c5f714d9b3a75f0be02b3a408f865c9021aa7

Solved index.js discovery Release build failure, see https://github.com/react-native-community/releases/issues/249

fkgozali commented 2 years ago

[Pick Request] https://github.com/facebook/react-native/commit/ac4ddec542febda744de218dae3a3d34edc7da84

Added the existing post_install workaround explained here to be part of the new app template (until all remaining issues are resolved).

fkgozali commented 2 years ago

[Pick Request] https://github.com/facebook/react-native/commit/329b026f3a48a4228a89696540ba459276f9a2c2

Resolved Swift library path lookup issue so that we no longer needs a workaround in the app's Podfile post_install() hook.

Huxpro commented 2 years ago

[Pick Request] https://github.com/facebook/react-native/commit/1bc885b8b856c7a050f0df68d9a09ca7581d0220

We need this libjsi change to be able to link with Hermes 0.9.0.

r0b0t3d commented 2 years ago

Please pick https://github.com/facebook/react-native/commit/7edf9274cf6d3398075c19cd1cb020a5d6a346a2

Fix keyboardDismissMode="on-drag" on Android

tushar-singhal commented 2 years ago

folks, thank you for your continued hardwork 🙏 Can we please include the android font weights fix in this release?

Font weights have been broken on Android since forever, and this finally fixes them. It's been merged recently:

facebook/react-native#29117 (facebook/react-native@3827ca6)

https://github.com/react-native-community/releases/issues/232#issuecomment-860787470

danilobuerger commented 2 years ago

folks, thank you for your continued hardwork 🙏 Can we please include the android font weights fix in this release?

Font weights have been broken on Android since forever, and this finally fixes them. It's been merged recently:

facebook/react-native#29117 (facebook/react-native@3827ca6)

#232 (comment)

As you can see by clicking on the commit link you provided, the commit is already part of the 0.66 cut.

lubomyr commented 2 years ago

I have error with 0.66.0-rc.1 on ios build

sed: Pods/RCT-Folly/folly/portability/Time.h: No such file or directory

I think it caused that i run pod install not from ios folder, i run it from project folder via

pod install --project-directory=ios

is it possible to check path in script something like ?

    if [[ -f ios/Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' ios/Pods/RCT-Folly/folly/portability/Time.h
    fi
    if [[ -f Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' Pods/RCT-Folly/folly/portability/Time.h
    fi
mikehardy commented 2 years ago

Very interesting @lubomyr -

I think it caused that i run pod install not from ios folder

Can you share the exact commands you used to run this? I'm sympathetic to the problem but I fear your solution is maybe not general enough, if directory location is an issue...

lubomyr commented 2 years ago

@mikehardy I just always use

pod install --project-directory=ios

from react-native project folder (not from ios folder via pod install) then

npx react-native run-ios

I also stuck with other new problem started from rn-0.65 (also still exist in 0.66), when i try to run ios release build via x-code i have error ../node_modules/react-native/scripts/react-native-xcode.sh: line 85: /scripts/find-node.sh: No such file or directory its related with line source "$RN_DIR/scripts/find-node.sh" in scripts/react-native-xcode.sh for example when i replace in this line $RN_DIR to $REACT_NATIVE_DIR then it fixed the problem and i able to run project in release-mode via x-code

swrobel commented 2 years ago

Hermes 0.9.0 has been released. Is there anything else blocking rc2?

a7medev commented 2 years ago

Can this release include fixes to the npx react-native run-android and run-ios on Ubuntu? as it doesn't open a terminal window for the packager?

lunaleaps commented 2 years ago

Hermes 0.9.0 has been released. Is there anything else blocking rc2?

Nope! Sorry been busy, will get rc2 out hopefully later today or tomorrow

lunaleaps commented 2 years ago

Please pick facebook/react-native@7edf927

Fix keyboardDismissMode="on-drag" on Android

Can you provide more information about why this would be a release blocker?

lunaleaps commented 2 years ago

Can this release include fixes to the npx react-native run-android and run-ios on Ubuntu? as it doesn't open a terminal window for the packager?

Can you be more specific about what fixes you mean? And how are they release blockers?

fabOnReact commented 2 years ago

I think @a7med-mahmoud refers to issue https://github.com/facebook/react-native/issues/28807. The issue seems to not be in react-native, but the react-native-community/cli https://github.com/react-native-community/cli/issues/1223 and does not have an open pr. I don't think that we can cherry-pick a fix in this release.

hsavit1 commented 2 years ago

anyone else seeing problems with boost?

something like

ios/Pods/Headers/Public/RCT-Folly/folly/dynamic.h:63:10: 'boost/operators.hpp' file not found
#include <boost/operators.hpp>
kelset commented 2 years ago

@hsavit1 repro steps? 😅

hsavit1 commented 2 years ago

@kelset sorry for the lack of coherent details

upgrading a ios project from 0.63.4 -> 0.66-rc.1

hermes disabled, same results with flipper included and not included in pods

ive done everything suggested in these 2 stack overflow posts: (clear pods cache, remove and reinstall pods, etc)

building on an m1 mac, xcode 12.5.1

building through xcode, not the react native cli. ive followed all steps in upgrade-helper

lunaleaps commented 2 years ago

@hsavit1 For M1, perhaps try this post_install hook listed here: https://github.com/facebook/react-native/issues/31480#issuecomment-902912841. I would also follow up discussion there as this is not relevant to the release of 0.66

lunaleaps commented 2 years ago

0.66.0-rc2 is out: https://github.com/facebook/react-native/releases/tag/v0.66.0-rc.2

swrobel commented 2 years ago

0.66.0-rc2 is the first I've attempted upgrading my 0.64.2 project to, and I am consistently getting this error when building for Release with Hermes enabled on my Intel Mac:

Undefined symbols for architecture arm64:
  "___cxa_increment_exception_refcount", referenced from:
      folly::exception_ptr_get_type(std::exception_ptr const&) in libRCT-Folly.a(Exception.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

As an aside, rc2 still isn't available on the upgrade helper.

miinos commented 2 years ago

0.66.0-rc2 is the first I've attempted upgrading my 0.64.2 project to, and I am consistently getting this error when building for Release on my Intel Mac:

Undefined symbols for architecture arm64:
  "___cxa_increment_exception_refcount", referenced from:
      folly::exception_ptr_get_type(std::exception_ptr const&) in libRCT-Folly.a(Exception.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

As an aside, rc2 still isn't available on the upgrade helper.

same for me. with hermes enabled

lunaleaps commented 2 years ago

0.66.0-rc2 is the first I've attempted upgrading my 0.64.2 project to, and I am consistently getting this error when building for Release with Hermes enabled on my Intel Mac:

Undefined symbols for architecture arm64:
  "___cxa_increment_exception_refcount", referenced from:
      folly::exception_ptr_get_type(std::exception_ptr const&) in libRCT-Folly.a(Exception.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

As an aside, rc2 still isn't available on the upgrade helper.

@swrobel Ah right, let me try updating the upgrade-helper. Thanks to @kelset upgrade helper is updated

Do you mind making a release blocker issue? Relatively new workflow -- trying to be clearer about outstanding issues.

swrobel commented 2 years ago

@lunaleaps https://github.com/react-native-community/releases/issues/251

Thanks for updating the upgrade helper!

fkgozali commented 2 years ago

[Pick Request] https://github.com/facebook/react-native/commit/b0c8a4eee821ca0b22e166a2a38f2bd2f22a1abe

Solved: Undefined symbols for architecture arm64 (https://github.com/react-native-community/releases/issues/251)

fkgozali commented 2 years ago

0.66.0-rc.3 has been published! We decided to publish the next RC 3 to help validate the arm64 fix. Please give it a try.

The Upgrade Helper has been updated as well via https://github.com/react-native-community/rn-diff-purge/commit/f8485914ee127d117c5d673a39fae17ff3b9e178

DmytroKovalskyi-voypost commented 2 years ago

I have error with 0.66.0-rc.1 on ios build

sed: Pods/RCT-Folly/folly/portability/Time.h: No such file or directory

I think it caused that i run pod install not from ios folder, i run it from project folder via

pod install --project-directory=ios

is it possible to check path in script something like ?

    if [[ -f ios/Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' ios/Pods/RCT-Folly/folly/portability/Time.h
    fi
    if [[ -f Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' Pods/RCT-Folly/folly/portability/Time.h
    fi

I had the similar issue during build after installing "0.66.0-rc.3" version : " 'boost/operators.hpp' file not found " . I believe boost pod wasn't completely installed due to large size, at least in my case. After that, i manually added used in previous versions pod 'boost-for-react-native' to Podfile . It's solved the build issue for now, but I think it could be a better solution for this .

KingAmo commented 2 years ago

I have error with 0.66.0-rc.1 on ios build

sed: Pods/RCT-Folly/folly/portability/Time.h: No such file or directory

I think it caused that i run pod install not from ios folder, i run it from project folder via pod install --project-directory=ios is it possible to check path in script something like ?

    if [[ -f ios/Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' ios/Pods/RCT-Folly/folly/portability/Time.h
    fi
    if [[ -f Pods/RCT-Folly/folly/portability/Time.h ]]; then
        sed -i -e  $'s/__IPHONE_10_0/__IPHONE_12_0/' Pods/RCT-Folly/folly/portability/Time.h
    fi

I had the similar issue during build after installing "0.66.0-rc.3" version : " 'boost/operators.hpp' file not found " . I believe boost pod wasn't completely installed due to large size, at least in my case. After that, i manually added used in previous versions pod 'boost-for-react-native' to Podfile . It's solved the build issue for now, but I think it could be a better solution for this .

i believe it is due to react-native-reanimated, i file a issue there https://github.com/software-mansion/react-native-reanimated/issues/2434

mikehardy commented 2 years ago

In the continuing saga of everyone doing everything they can to get this to build cleanly on iOS - this PR was just posted to mop up an issue with the workaround method in the Podfile that was committed between rc1 and rc2 if I am remembering everything correctly - it needs good hands to shepherd it home: https://github.com/facebook/react-native/pull/32243#issuecomment-924178290

fkgozali commented 2 years ago

[Pick Request] https://github.com/facebook/react-native/commit/ef5ff3e055482771cbe866d4961ee2d0a9e00e45

To solve https://github.com/facebook/react-native/pull/32243

roots-ai commented 2 years ago

This issue is open everywhere https://github.com/facebook/react-native/issues/32250

mikehardy commented 2 years ago

@roots-ai your comment does not appear to meet the criteria for this thread: Please carefully read the "Notice" section in the description for the thread. As a side note, I have no problem with hermes on android with 0.65.1 (irrelevant to this thread) or with 0.66 in all of it's release candidates (more relevant, and indicates you have some other issue)

fkgozali commented 2 years ago

@dmtrKovalenko @KingAmo I think https://github.com/facebook/react-native/pull/32243 would help with your build issue, it will be in RC4

numandev1 commented 2 years ago

Please pick https://github.com/facebook/react-native/commit/01856633a1d42ed3b26e7cc93a007d7948e1f76e

feat: add cancelButtonTintColor props in ActionSheetIOS for change cancel button tint color

fkgozali commented 2 years ago

Please pick facebook/react-native@0185663

feat: add cancelButtonTintColor props in ActionSheetIOS for change cancel button tint color

@nomi9995 at this point we're looking to stabilize v0.66, so we're only considering release blockers right now. See also our pick criteria linked in the issue summary: https://github.com/react-native-community/releases/blob/master/docs/definitions.md#what-is-a-qualified-pick-request

fkgozali commented 2 years ago

[Pick Request] https://github.com/facebook/react-native/commit/d3c7e201839f5d7c869c4c88ab2031ef7d16e158

This makes it easier to update RNTester Podfile.lock for the purpose of release publishing.

fkgozali commented 2 years ago

v0.66.0-rc.4 has been published as a stable release candidate! It solved all known remaining issues in v0.66.0, so if this is stable, we plan to promote it to a stable release next week. Please try it out!

joe-sam commented 2 years ago

Didn't see this make the list of cherry-pick request in the change log, so I'm guessing it was missed! fix: compare the LogBoxData ignorePatterns with the right code (#31977)

mikehardy commented 2 years ago

@joe-sam the commit is https://github.com/facebook/react-native/commit/a950634424cddf31c0adb6c9799adf1cc5f83bf0 - I'm guessing with rc4 already out for a few days and the RC process already having been quite long, that rc4 will ship and this will need a new notice on the 0.66.1 issue whenever that is created. Just a guess on my part, I am not a part of that process, just noting it so you keep on eye on things and re-post to 0.66.1 if needed. Cheers!

kelset commented 2 years ago

should we do an RC5 with this commit in? https://github.com/facebook/react-native/commit/a1c445a39c580037ada4a5d194a0d2daef15a25a it sounds like it's a fairly big improvement to the post-install patching (__apply_Xcode_12_5_M1_post_install_workaround) for pod installs

kelset commented 2 years ago

as per conversation here: https://github.com/facebook/react-native/pull/32284#issuecomment-929683854 there won't be an RC5 with that extra commit - I'll hide my comment