0.57.7 Discussion

[kelset]

Conversation on this thread are limited to 0.57.7 release's major issues and backport (cherry-pick) requests from commits that are already on master - so that we can then produce a 0.57.8 release in the near future.

An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.57.7 cut.

In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.

If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.57-stable branch yourself, in order to ensure that the process proceeds smoothly.

[miblanchard]

Could 53da585 be cherry-picked?

[ahce]

React sync

[radeno]

Some other possible fixing cherry-picks

• Switch: Improve Accessibility: https://github.com/facebook/react-native/commit/0c8db08f519fdf5162dff1d9a18b58885c4c7d2f
• Android: Fix TouchEvents on text after state changes: https://github.com/facebook/react-native/commit/00681c3660809887644c5abfaf018a5e46b06547
• iOS: Calling -[UIScrollView setContentOffset] with NaN values can cause a crash: https://github.com/facebook/react-native/commit/585f7b916d63b7b4d22a7347334765ffcd7945e9
• Android: fix possible NPE in StatusBarModule https://github.com/facebook/react-native/commit/0f3be77b7d4177c8f94d775bf8ef2a2b68f1e828
• iOS: Fixes animated gifs incorrectly looping/not stopping on last frame https://github.com/facebook/react-native/commit/de759b949e4aa4904fd60a2fcbb874a3c857b50c
• Make type of RefreshControl.onRefresh less strict https://github.com/facebook/react-native/commit/ff6a53de2a563d0be1edf726654ed881789ec00a
• Bump ws package to 1.1.5 due to vulnerability issues https://github.com/facebook/react-native/commit/96ce6f9538ed3559ffea6040a47b1d6a30546ab9
• Fix ListEmptyComponent is rendered upside down when using inverted flag https://github.com/facebook/react-native/commit/198eb0269781803cc16254916b0477916afbcb0e
• Fix bug in comparison logic of object property https://github.com/facebook/react-native/commit/c3b3eb7f73b0fb4035d4b2478bf9827caf746372
• iOS: Fixed for supporting mediaPlaybackRequiresUserAction under iOS 10 https://github.com/facebook/react-native/commit/c45d290b079f95466ad4054acf7b93c66cabc429

Maybe:

• Metro update: https://github.com/facebook/react-native/commit/8d68a3e9f1de4c2d52498d82357ab7031d246635
• iOS: Ensure RCTImageCache's DateFormatter is only allocated once https://github.com/facebook/react-native/commit/668341a294332f65135df48dc0954dfd8c8c42ca Blind fix, can't be reproduced. i don't wan't same issue like with TextInput focusing in 0.57.6
• Check for thread consistency in JSCRuntime https://github.com/facebook/react-native/commit/bdb084e8a8ce6af3f783bb717ca5dfe219f0b6a0
• Don't create the JSCRuntime until createJSExecutor() is called https://github.com/facebook/react-native/commit/99c370959aa03688689960ef88098f8301091d52

[dvicory]

:+1: on https://github.com/facebook/react-native/commit/8d68a3e9f1de4c2d52498d82357ab7031d246635. That metro upgrade contains the Yarn PnP resolver that I really want to make use of. :smile:

[radeno]

Another fixes:

• iOS: Animation duration on keyboard cannot be less then 10ms https://github.com/facebook/react-native/commit/87b65339379362f9db77ae3f5c9fa8934da34b25
• Android: Fix dispatch of OnLayout event for first render https://github.com/facebook/react-native/commit/844e11967d9292bd5cfe423d0fd57e34388f2337
• Use main.jsbundle in iOS template for production build https://github.com/facebook/react-native/commit/a2ef5b85d8c46cefd5873bf5fc6dddabf1d51d13
• Extend reason message for RCTFatalException https://github.com/facebook/react-native/commit/2831d9ef614280d08699f3134eeaeda84c30234e this is not bugfix, but better error messages are always welcome
• Remove trailing slash from origin header if no port is specified https://github.com/facebook/react-native/commit/cbe7d41f3f509aaa8b8b0819b0d8ad4996fd7296
• Touchable component: default hitSlop values to 0 https://github.com/facebook/react-native/commit/f6d3a6167730cc9253b796b859d8f1f33f821687

Maybe:

• Back out "Check for thread consistency in JSCRuntime" https://github.com/facebook/react-native/commit/3f0f25f73c5612cd9fc2a69e44183b7f06c7b6f5 Do you know about issue?

[kelset]

hey everyone, thanks for the suggestions, I am thinking of releasing 0.57.8 by end of the week as last release for 0.57 for this year.

I'll keep you updated.

---

EDIT: I won't upgrade Metro because it relies on an alpha of Jest. You are free to enforce it in your local project, but for this branch we are trying to keep things as stable as possible.

[levibuzolic]

~Any chance we could get https://github.com/facebook/react-native/commit/077386a233a9066ed0efab0e02cf0fd677c79915 into 0.57.8? Or would it be more appropriate for the 0.58.0 release?~

Oops never mind, got reverted. Will wait to find out what happened and get it back in. 🤦‍♂️

[radeno]

@levibuzolic that commit was reverted. So i don't think so.

[sunnylqm]

https://github.com/facebook/react-native/commit/0314fca63a035c95864e5b198e1fbd9a5ee1d2a7

[kelset]

Hey everyone, just cherry-picked the commits, tested locally all everything went smoothly - now pushed to repo to test CI. You can see the list of commits here.

Didn't cherry pick because created conflicts:

• Make type of RefreshControl.onRefresh less strict facebook/react-native@ff6a53d
• Android: Fix TouchEvents on text after state changes: facebook/react-native@00681c3

[kelset]

Release 0.57.8 is now on npm, I'll publish the changelog in a bit.

Thanks to everyone who got involved, you can follow up the conversation for 0.57.8 in its dedicated issue.