Closed kelset closed 5 years ago
nihar108
commented
5 years ago Would love to have https://github.com/facebook/react-native/commit/3b9604feda8f9e8fe3dd884912ec7d9be67d7f1d in the next 0.58.x release? Need to support a 3rd party module that extends AppCompatActivity.
mikehardy
commented
5 years ago @nihar108 that's a non backwards compatible / breaking change and is being noted as such in the 59 release notes if I recall correctly
nihar108
commented
5 years ago @mikehardy Sorry I missed that. Just so that I get it right next time, if the change is not a breaking one, can it be included in the next 0.58.x release even though it is present in the 0.59.0-rc versions?
mikehardy
commented
5 years ago @mikehardy Sorry I missed that. Just so that I get it right next time, if the change is not a breaking one, can it be included in the next 0.58.x release even though it is present in the 0.59.0-rc versions?
I'm not sure on policy (I'm just a random developer on the internet ;-) ), but I am fairly sure breaking changes don't go in patch releases, so I was just noting it in case you were on the fence of whether to start moving yourself to 0.59.x or not or wait for a patch release. As I'm not 100% sure I couldn't advise anyone but if I relied on that change I'd just move to 0.59-rcs now personally
Bardiamist
commented
5 years ago I updated from 0.58.4 to 0.58.5 today and now I have warning when call fetch with saga.
Warning: somthing about n.slice on next code: yield call(fetch, 'apiUrl', requestOprions). But it works properly.
Works wothout warning: await fetch('apiUrl', requestOprions)
May be in future will create issue when will understand what the right place for this.
Can't make to reproduce demo because expo snack not using react-native@0.58.5 now.
dmainas
commented
5 years ago Fix Inverted Horizontal ScrollView on Android https://github.com/facebook/react-native/commit/32cb9ec49c801fcebe61486149134ab542d9364b
thientnc-ibl
commented
5 years ago Map TextInput textContentType strings to Objective-C constants https://github.com/facebook/react-native/commit/a89fe4165c2a331a9d88636d89a5a48151ab8660
sunnylqm
commented
5 years ago 
lorenc-tomasz
commented
5 years ago Please add upgrade istructions from 0.58.4 if necessary.
Bardiamist
commented
5 years ago @lorenc-tomasz Yo can see changes here https://github.com/bardiamist/rn-diff/compare/rn-0.58.4...rn-0.58.5
grabbou
commented
5 years ago @mikehardy I wouldn't say it better!
It's not the first time the ReactActivity commit comes up @nihar108, but given it's breaking and not trivial to merge, we decided to keep it for the 0.59 RC.
@lorenc-tomasz there's nothing to do to upgrade in between patch releases rather than just bumping your package.json.
grabbou
commented
5 years ago I've been working on 0.59.0-rc.3 today and some fixes to the CLI. I am going to work on 0.58.6 tomorrow.
fungilation
commented
5 years ago Any rough estimate of when for 0.59.0 release?
grabbou
commented
5 years ago We want RC to stabilize for a week and then, we will cut stable. On Wed, 27 Feb 2019 at 23:25, Gary Fung notifications@github.com wrote:
Any rough estimate of when for 0.59.0 release?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/react-native-community/react-native-releases/issues/95#issuecomment-468055386, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWcxneSBNK1bciEDptwE4dMwwbDic9Dks5vRwXGgaJpZM4bEz6b .
PareshPatel721
commented
5 years ago Hello, I am naive in React-native.
I installed react-native through CLI command, all node and homebrew are also installed on. my MacMini. Created first application with react-native init MyFirstApp Below is the version of React-native set up on my mac machine. react-native --version react-native-cli: 2.0.1 react-native: 0.58.5
I am getting an error like 'glog/logging.h' file not found
C compiler cannot create executables See `config.log' for more details Command PhaseScriptExecution emitted errors but did not return a nonzero exit code to indicate failure
Can anyone help me to run my First Application on React-native?
Bardiamist
commented
5 years ago @PareshPatel721 maybe you have Sierra? Then you should update your OS.
kelset
commented
5 years ago @PareshPatel721 please refer to the issue section of the main repo.
grabbou
commented
5 years ago Cherry-picked commits, pushed to the CI to test if it's all green. I am half-way done with manual checks on RNTester and react-native init'ed app - will resume to this in few hours.
kelset
commented
5 years ago 0.58.6 is out - thanks everyone! New issue https://github.com/react-native-community/react-native-releases/issues/97
Conversation on this thread are limited to 0.58.5 release's major issues and backport (cherry-pick) requests from commits that are already on master.
An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.58.5 cut.
In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.
If the commit you request to cherry pick is a complicated port, you will be asked to create the PR to the 0.58-stable branch yourself, in order to ensure that the process proceeds smoothly.