Open fabioh8010 opened 1 year ago
Hey @pvinis , did you have a chance to take a look at my proposal? Thanks!
1, it runs automatically. by gh actions if I remember correctly. 3, we def should not add it on the list.
if there point of ain't nighties is to upgrade from a stable to nightly, feels not too useful. I don't know of many people that would do that. most would maybe go to rc, but probably not even there.
if it's to upgrade from a nightly to another nightly, then that's cool but we should hide them behind some settings checkbox to show them or not.
do you think that's useful? what do you think would be it's use?
Hi 👋 I'm coming from https://github.com/react-native-community/upgrade-helper/issues/325, I'm planning to implement support for nightly builds in the upgrade-helper tool. After studying the codebase for some time, I saw that it uses this repo to obtain the diffs between the versions.
From what I understood here:
new-release.sh
script manually (passing the version as a argument) to do all the work of creating the projects to create the diffs, creating a new branch here, updating version tables, etc.upgrade-helper
will use RELEASES file to list the versions on the website. Then, when selecting a version, it will fetch the corresponding diff file in thediff
branch to display it.So, first I'll have to add support for nightly releases in this repo in order to add the support in
upgrade-helper
tool. With that in mind, I have some questions:react-native
repo every day?0.73.0-nightly-20230701-eca0d1231
, and only the nightly versions of the next release are kept (when a new release is out, the older nightly versions are removed). So, I guess we'll need to take a similar approach here:diffs
branch as well?)Overall, wdyt about this support for nightly builds? Please let me know if you have any questions or feedback!