search

react-native-community / template

The React Native Community Template - getting started building RN apps for Android & iOS
MIT License
71 stars 16 forks source link

remove SafeAreaView which has no effect on the UI #85

Closed alanleedev closed 6 days ago

alanleedev commented 1 week ago

Summary:

Changelog:

[GENERAL][REMOVED] - Removed SafeAreaView usage in template app

Test Plan:

Manually editing generated template app.

iOS with SafeAreaView:

https://github.com/user-attachments/assets/0cf4aeb1-598a-4d10-b8cd-0cbb8a689fa3

iOS without SafeAreaView:

https://github.com/user-attachments/assets/2b53afa8-cfed-428b-aecf-127a8b5de406

They look the same with or without the SafeAreaView.

Note: It was not handled in the PR but leaving a note as future reference. Safe area seems to be handled in ScrollView with contentInsetAdjustmentBehavior="automatic" prop (code here). Removing this on iOS looks like this:

https://github.com/user-attachments/assets/803f8410-bcbe-4760-a8b4-49cf1a309bcb

liamjones commented 6 days ago

They look the same with or without the SafeAreaView.

Does this hold true for the device in landscape orientation too?

alanleedev commented 6 days ago

Does this hold true for the device in landscape orientation too?

That is good question. Landscape does become a bit of an issue.

Without SafeAreaView on iOS without

With SafeAreaView on iOS with

alanleedev commented 6 days ago

Closing for now due to landscape issue.