react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.

https://react-native-community.github.io/upgrade-helper

MIT License

3.67k stars 112 forks source link

Clean yarn.lock #187

Closed pvinis closed 4 years ago

pvinis commented 4 years ago

Summary

I removed yarn.lock and run yarn install, and this is what came out. Should we merge? 🤔

Test Plan

What are the steps to reproduce?

Checklist

[ ] I tested this thoroughly
[ ] I added the documentation in README.md (if needed)

lucasbento commented 4 years ago

@pvinis: can you check the deploy preview to see if everything is working?

pvinis commented 4 years ago

Seems to be alright.

pvinis commented 4 years ago

@lucasbento Could you checkout this PR, and remove the lockfile, then yarn install and check the diff? I'm curious if your computer will generate the same lock file or not.

For reference, I have node 13.9.0 and yarn 1.22.0.

lucasbento commented 4 years ago

@pvinis: I'll check that!

lucasbento commented 4 years ago

@pvinis: nope, got a different lockfile with yarnpkg.com instead of npmjs.org. I suggest not merging this.

pvinis commented 4 years ago

Hmmmm good to know. Strange. Let's close this then and I'll investigate why this happens.