search

react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

Keep original path with `appName` of `RnDiffApp` to View or Download files #206

Closed benomatis closed 4 years ago

benomatis commented 4 years ago

If you change the App Name on top, then click on View file or the download icon, you'll get redirected to a dead link because the app name is also replaced in the path to the one the user set.

I changed it so it reverts to the default RnDiffApp only for view and download to prevent the 404 error.

pvinis commented 4 years ago

Good catch. I think we should do some work there for actually supporting this better, but this is not for this PR.

lucasbento commented 4 years ago

@pvinis: Good catch. I think we should do some work there for actually supporting this better, but this is not for this PR.

Would be nice to create an issue for this if you already have ideas in mind 😄

pvinis commented 4 years ago

Let's merge this for now, because it's better to show the file than to show an error 😅

benomatis commented 4 years ago

@pvinis: Good catch. I think we should do some work there for actually supporting this better, but this is not for this PR.

Would be nice to create an issue for this if you already have ideas in mind 😄

I guess this will have to be done with apache mod_rewrite, to keep the URL with the custom app name in the path, but show the content of the file with the original path.

pvinis commented 4 years ago

My idea was to not show the original, basically #208.

elie222 commented 4 years ago

Possibly broke this: https://react-native-community.github.io/upgrade-helper/?from=0.60.6&to=0.61.5

benomatis commented 4 years ago

Possibly broke this: https://react-native-community.github.io/upgrade-helper/?from=0.60.6&to=0.61.5

Looks like it's broken by eeea806ed25e9e1cbca66f5c2f1dd0f1d907163a instead.

lucasbento commented 4 years ago

Thanks for notifying this issue @elie222 and thank you @benomatis for pinpoint where the problem was.

I just reverted the version bump in https://github.com/react-native-community/upgrade-helper/commit/eeea806ed25e9e1cbca66f5c2f1dd0f1d907163a so the latest build should be working.

benomatis commented 4 years ago

@lucasbento Yup, I can confirm, it works with the old version. @elie222 All good for you too?

elie222 commented 4 years ago

Yup, thanks! https://react-native-community.github.io/upgrade-helper/?from=0.60.6&to=0.61.5 works great