search

react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

View/Download file with changed app name #208

Closed pvinis closed 4 years ago

pvinis commented 4 years ago

Description

Let's take package.json as an example.

When I change the app name from the options popover, I can see that in the diff viewer the "name" is "myApp" for example, or whatever I put in the options.

When I click to view or download a file, the "name" in there is "RnAppDiff", which makes sense, since it's just the original file.

Discussion

I don't know if that is confusing or possibly causing trouble. I guess we could fix this by displaying the raw file after we have replaced the app name, like we do for the diff viewer, but is it worth it?

benomatis commented 4 years ago

Wouldn't you actually need to create the page with the app name in order to be able to display the contents of the original path? Alternatively we could do this with apache's mod_rewrite, then again that could become a quite complicated script.

And don't forget to think of not just the folder names in the path, but some file names have the app name as well, like many iOS files.

pvinis commented 4 years ago

Let's close this. This is not worth our time, not right now at least. There are more important things we can do in this repo and the upgrade story. :)

Maybe we can revisit in the future.