search

react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

Click the completed files counter to go to the Done section #216

Closed benomatis closed 4 years ago

benomatis commented 4 years ago

Click the completed files counter to go to the Done section, click again to go back to top

This is an implementation of engancement request https://github.com/react-native-community/upgrade-helper/issues/215

It's just one variant... ;)

benomatis commented 4 years ago

Sorry, I don't understand what that test error is supposed to mean and how I can fix it.

pvinis commented 4 years ago

I think it just needs to update the snapshot. I can do it.

pvinis commented 4 years ago

Done. Basically when running yarn test and that test fails, you can press u and it will update the snapshot.

pvinis commented 4 years ago

Hm, where did my commit go? 😆

I thought I could push on the same thing here, but apparently it went here. https://github.com/react-native-community/upgrade-helper/commit/f0992e074bc0d50ac923b47b8812b5c834fe00c5 You can just grab that change, or try to update it yourself. :D

benomatis commented 4 years ago

@pvinis I just merged your changes, and it looks like all tests went through (sorry, I'm not an experienced tester, not even close, apparently) ;) Thanks!