search

react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

Upgrade hints will be disappeared when setting project name in the setting menu #228

Closed SaeedZhiany closed 3 years ago

SaeedZhiany commented 4 years ago

Bug

I just noticed that upgrade hints will be disappeared when I set my project name in the setting menu

React Native versions

from RN 0.59.10 to RN 0.62.2

Steps to reproduce

  1. choose RN 0.59.10 and 0.62.2 for upgrading

  2. write your project name in the setting menu (for example, PROJECTNAME)

  3. click on show me how to upgrade!

  4. check ios/PROJECTNAME.xcodeproj/project.pbxproj

  5. you will see that the hints aren't shown on this file

image

Describe what you expected to happen:

we must see the hints on this file just like when we don't configure project name in the setting menu like below

Annotation 2020-04-10 135451

lucasbento commented 3 years ago

@SaeedZhiany thanks for reporting this issue, #264 fixes it.

Apologies for taking so long to fix it.

SaeedZhiany commented 3 years ago

Great!

Thanks, @lucasbento