react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.

https://react-native-community.github.io/upgrade-helper

MIT License

3.67k stars 112 forks source link

Link not found #285

Closed anasnmu closed 3 years ago

anasnmu commented 3 years ago

Bug

gradle-wrapper.jar link not found

React Native versions

updating from 0.63.4 to 0.65.1

Steps to reproduce

https://react-native-community.github.io/upgrade-helper/?from=0.63.4&to=0.65.1

then go to gradle-wrapper.jar section. click the download icon, here's the link: https://github.com/undefined/raw/release/0.65.1/RnDiffApp/android/gradle/wrapper/gradle-wrapper.jar

Describe what you expected to happen:

the link should be working

yfunk commented 3 years ago

Seems related to #280 (cc: @lucasbento).

Looks like pressing DownloadFileButton for any binary file links to a broken URL (https://github.com/undefined/[...]), because getBinaryFileURL() is called without packageName here.

Should be an easy fix 🙂