search

react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

Add react-native-macos support and UI to switch packageName/Language #294

Closed acoates-ms closed 3 years ago

acoates-ms commented 3 years ago

Summary

Adds UI to the settings popover to allows users to switch between react-native and react-native-windows, and to switch between C++ and C# within react-native-windows.

Here is what the new settings popover looks like: image

Test Plan

Ran through the site starting with various values of packageName and language in the URL. Try changing the package name back and forth in the settings. Try changing the language when packageName=react-native-windows. Try changing it when in packageName=react-native Try changing back to react-native after switching the language.

What are the steps to reproduce?

Just load the site and hit the settings icon in the top right.

Checklist

lucasbento commented 3 years ago

Hey @acoates-ms, this is an awesome addition to the Upgrade-Helper!

The initial load of the diff after the you change the package doesn't seem to work, it does work afterwards though:

https://user-images.githubusercontent.com/6207220/141144934-368796f3-7831-4906-be51-15790552e825.mp4

acoates-ms commented 3 years ago

The reason for this is the to/from versions not being valid for the new platform. So instead I'm going to reset the to/from versions and hide the diff rather than showing the broken diff. That way it doesn't look as broken. The user will still have to select the versions and hit Show me how to upgrade! button again to show the new diff.

acoates-ms commented 3 years ago

@lucasbento should be good for another look.

lucasbento commented 3 years ago

Looks great, thank you @acoates-ms!