react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

adding an alert about dep-check, plus some refactoring #311

Closed kelset closed 2 years ago

kelset commented 2 years ago

Summary

Started from this twitter thread with @lucasbento & @pvinis, I decided to add in the callout section the fact that dep-check is a thing and that should help you :)

Copy is still a WIP tbh, I'm going to ask @afoxman and @tido64 to give their 👍 (on top of Lucas' and Pavlos', ofc!)

While doing so I realised that I wanted to do a bit more 😇 so I did a bit of refactoring so that on all releases we show some information that are not strictly version-bound (see screenshots for more). This also sets the stage for extracting from the links part the changelog bit so that we can also always parse up the RN versions changelog to show in the callout... but I left that part for some future work (potentially some good first issue material?).

Let me know what you think! :)

Test Plan

Before/after for when there are no useful links

Screenshot 2022-05-06 at 12 46 02

Before/after for when there are useful links

Screenshot 2022-05-06 at 12 46 24

What are the steps to reproduce?

Just run the website on the branch :)

Checklist

cortinico commented 2 years ago

Great stuff :)

kelset commented 2 years ago

thanks y'all for the feedback, here's the new copy:

Screenshot 2022-05-09 at 14 17 32