Closed blakef closed 1 year ago
@blakef awesome contribution 🥳
I found one small issue, when checking a wider-range diff, it doesn't focus on the correct file, an example can be seen here which should go to the Android.mk
file upgrading from 0.69.7
to 0.71.3
.
@lucasbento looks like the animation hadn't completed. Fixed now.
https://user-images.githubusercontent.com/49578/223165705-5ef8008d-2914-4eef-8805-3b0864d403ed.mp4
@blakef I noticed that if you go to to an URL with a file (this one, for example) and change the version at the top, it immediately goes to the file again, is that intentional? I believe it would be better to stop triggering the scroll on URL changes after the file has been scrolled to.
Thanks for the patience and work you've put into reviewing. Hopefully the final set of changes:
https://user-images.githubusercontent.com/49578/223575320-82f0f52b-81ab-430c-be64-1c18cd8c78d9.mp4
Awesome contribution, thank you for working on this, @blakef!
Summary
This lets users copy and paste links directly to specific changes in the diff. This is pretty useful for sharing via chat. In the contributors discord I saw a link posted which would have benefited from this.
Screenshots
Anchor link
Anchor link clicked
Loading from link
https://user-images.githubusercontent.com/49578/223138105-f67c9b30-16a2-41ad-94ad-eb1e818beb0a.mp4
Test Plan
Ran unit test and on my localhost.
What are the steps to reproduce?
Checklist
README.md
(if needed)