search

react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

App name field reverts to placeholder each time "Show me how to upgrade" button pressed #366

Closed smallsaucepan closed 1 year ago

smallsaucepan commented 1 year ago

Bug

One great feature of the upgrade helper is the ability to enter your own app name instead of the default RnDiffApp and have the diffs customised to what you would expect to see. However, if you have entered a custom name and press the "Show me how to upgrade" button, the name field is cleared.

This then requires filling out the field again if wishing to regenerate the diffs based on other different criteria e.g. RN versions. This happens quietly meaning the user may generate a second set of diffs and start working through them, only to realise the app name in their diffs is now incorrect.

React Native versions

n/a

Steps to reproduce

Fill out the app name field with a custom name e.g. MyApp, press the "Show me how to upgrade" button

Describe what you expected to happen:

  1. Ideally, the name field should retain your custom app name (MyApp). Instead it quietly reverts to RnDiffApp
smallsaucepan commented 1 year ago

@lucasbento / @pvinis would one of you like to assign this to me? Have forked and will return with a PR.

pvinis commented 1 year ago

feel free to open up a PR about this too 👍

smallsaucepan commented 1 year ago

Thanks for merging @pvinis 👍