react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.64k stars 112 forks source link

Fix app name / package replacement #369

Closed zoontek closed 1 year ago

zoontek commented 1 year ago

Summary

Currently, app name / package replacement is kinda broken.

What are the steps to reproduce?

Screenshot 2023-09-08 at 19 03 25

Let's say we have this scenario: My app name is Swan, my app package is io.swan.id. With this config, on the current version of the upgrade helper, you will notice that the app name is append to the app package, making it io.swan.id.swan

This is visible in paths or if you copy file raw content:

Screenshot 2023-09-08 at 19 42 51 Screenshot 2023-09-08 at 19 45 22

This PR fixes all of this. It also:

Test Plan

Check both files content and paths with:

Checklist

pvinis commented 1 year ago

can you try on the netlify preview to see if it works as you expect?

zoontek commented 1 year ago

@pvinis Just checked it, works correctly ✅