search

react-native-community / upgrade-helper

⚛️ A web tool to support React Native developers in upgrading their apps.
https://react-native-community.github.io/upgrade-helper
MIT License
3.67k stars 112 forks source link

Diff of `MainActivity.kt` is wrongly displayed (3x concatenated) #377

Closed cortinico closed 9 months ago

cortinico commented 9 months ago

Bug

The diff of MainActivity.kt is wrong for 0.74: https://react-native-community.github.io/upgrade-helper/?from=0.73.4&to=0.74.0-rc.0

It seems like if the diff is calling cat on the file 3 times? Not sure what's going on: Screenshot_2024-02-23_at_17 29 49

React Native versions

0.73.4 to 0.74.0-rc.0

Steps to reproduce

Just go to https://react-native-community.github.io/upgrade-helper/?from=0.73.4&to=0.74.0-rc.0

Describe what you expected to happen:

  1. Ideally I'd like to see the correct diff for the file.
blakef commented 9 months ago

I think there's some funk going on with the way we're normalising hunks.

cortinico commented 9 months ago

Fixed by #378