react-native-community / upgrade-support

A central community-backed place to request and give help when upgrading your app.
MIT License
261 stars 2 forks source link

Redefinition of module 'React' in React-RCTWebSocket.modulemap #167

Open willyrabbits opened 3 years ago

willyrabbits commented 3 years ago

Environment

Environment info

```node System: OS: macOS 11.2.3 CPU: (4) x64 Intel(R) Core(TM) i7-6660U CPU @ 2.40GHz Memory: 493.81 MB / 16.00 GB Shell: 5.8 - /bin/zsh Binaries: Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node Yarn: 1.22.10 - ~/.nvm/versions/node/v14.16.0/bin/yarn npm: 7.10.0 - ~/.nvm/versions/node/v14.16.0/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman SDKs: iOS SDK: Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2 Android SDK: API Levels: 23, 25, 26, 27, 28, 29 Build Tools: 27.0.3, 28.0.3, 29.0.2, 30.0.3 System Images: android-30 | Google APIs Intel x86 Atom IDEs: Android Studio: 4.1 AI-201.8743.12.41.7042882 Xcode: 12.4/12D4e - /usr/bin/xcodebuild npmPackages: react: 16.8.6 => 16.8.6 react-native: 0.60.0 => 0.60.0 npmGlobalPackages: react-native-cli: 2.0.1 ```

Things I’ve done to figure out my issue

Upgrading version

0.60.0

Description

We have just upgraded react-native from 0.59.10 to 0.60.0. Mainly we have been following these guides:

https://react-native-community.github.io/upgrade-helper/?from=0.59.10&to=0.60.0

https://mattoakes.net/react-native-upgrade-guides/upgrade-to-react-native-0.60

When it comes to Android, the upgrade process was pretty straight-forward. But my team is struggling quite a bit when doing the iOS side.

After following those guides and solve some problems, we are facing one which we can not find any info about... We have been stuck in here for a while now.

So, the problem is: when we build the project, the next error appears. Screenshot 2021-06-02 at 15 50 10

Reading about some similar topics, other people of the community suggested that we may be adding the same package twice either in the Build Settings or the Build Phases in our target in the XCode project. But I can not find any of it :/

I am afraid that the error comes form our Podfile, but it looks good to me:

require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

# Uncomment the next line to define a global platform for your project
platform :ios, '10.0'

use_modular_headers!

def pods()
  pod 'React', :path => '../node_modules/react-native/'
  pod 'React-Core', :path => '../node_modules/react-native/React'
  pod 'React-DevSupport', :path => '../node_modules/react-native/React'
  pod 'React-fishhook', :path => '../node_modules/react-native/Libraries/fishhook'
  pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
  pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
  pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
  pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
  pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
  pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
  pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
  pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
  pod 'React-RCTWebSocket', :path => '../node_modules/react-native/Libraries/WebSocket'

  pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
  pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
  pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
  pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec', :modular_headers => false
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec', :modular_headers => false
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec', :modular_headers => false
end

target 'OneSignalNotificationServiceExtension' do
  # Pods for OneSignalNotificationServiceExtension
  use_native_modules!
end

target 'XXX' do
  # Pods for xxx
  pods()

  target 'XXXTests' do
    inherit! :search_paths
    # Pods for testing
  end

  use_native_modules!

  post_install do |installer|
    installer.pods_project.targets.each do |target|
      target.build_configurations.each do |config|
        config.build_settings['APPLICATION_EXTENSION_API_ONLY'] = 'No'
      end
    end
  end

end

If there is anything you want me to attach in order to have more info about the error, do not hesitate to ask.

Any advice is welcome :)

Reproducible demo