search

react-native-component / react-native-smart-sortable-sudoku-grid

A smart sortable sudoku grid for React Native apps
MIT License
107 stars 42 forks source link

fix NPE in componentWillReceiveProps on line 150 #21

Open rakeshgajula opened 7 years ago

rakeshgajula commented 7 years ago

The component was failing on line 150. The following line

newState.containerHeight= this.createHeight(nextProps)

was failing as newState was still unassigned. The fix is to check for validity of newState before assignment.

kala888 commented 6 years ago

@cyqresig could you merge this to your project and release a new version?

rakeshgajula commented 6 years ago

I have already fixed it in my project. I could release a new version but i don't think i can publish the release to NPM. It would be better if you can accept the pull request.