search

react-native-cookies / cookies

🍪 Cookie Manager for React Native
MIT License
480 stars 95 forks source link

Android Build issue with removeSessionCookies function #146

Open bennydu91 opened 2 years ago

bennydu91 commented 2 years ago

Hello ! I have update from last version (6.2.0) and I have an issue with removeSessionCookies function as you can see on this screenshot I didn't find any ticket about it, maybe you have a quick fix for this ?

Thank you !

kjurkovicafinitos commented 2 years ago

I have the same issue! EDIT: @bennydu91 you can quickly fix this by setting line 106 in CookieManagerModule.java like this: public void removeSessionCookies(Promise promise) .. -> public void removeSessionCookies(final Promise promise) ..

mmathewsTableau commented 2 years ago

Running into it as well. Workaround is great but would definitely appreciate a permanent fix so a local patch is not necessary.

bennydu91 commented 2 years ago

@kjurkovicafinitos Yep I've tried it but still not working unfortunately

kjurkovicafinitos commented 2 years ago

@bennydu91 what error are you seeing? Problem with workaround is that after every npm install, final will be removed and you need to add it again. Might that be the issue?

bennydu91 commented 2 years ago

After add final, without doing npm install, I try to build, gradle doesn't pop any error but after Metro generate bundle I have a blank screen on my emulator (Update package is my only change on this branch and I can build on main branch)