react-native-datetimepicker / datetimepicker

React Native date & time picker component for iOS, Android and Windows
MIT License
2.48k stars 402 forks source link

[iOS] Wrong weekdays translation #281

Closed egor-sorokin closed 2 years ago

egor-sorokin commented 4 years ago

Bug report

Summary

Language on a device is "Dutch" and region is "Netherlands". The app is fully translated in Dutch based on language settings of the device. However the weekdays stay in English.

Environment info

"react-native": "^0.61.5"
"@react-native-community/datetimepicker": "^3.0.2"

Library version: 3.0.2 iOS version: 14.0

Steps to reproduce

  1. Install the datetimepicker library in react-native app
  2. Init datetimepicker in the app
    <DateTimePicker
        mode="date"
        locale={'nl-NL'}
        value={new Date()}
      />
  3. Use device or set an emulator iPhone 11, iOS 14.0
  4. Set device language to Dutch (optional set region Netherlands)
  5. Run the app
  6. Click on datetimepicker
  7. Check (short/long) names of weekdays

Describe what you expected to happen: (short/long) names of weekdays are translated based on the device language

daniel commented 3 years ago

Same problem with other locales, the week days are not translated. The "Time" label is also not translated.

ahzahri commented 2 years ago

Hello, any info on this issue please ? Did anybody find or implement a work around please ? thx

christophemenager commented 2 years ago

I have the same issue, did not find a workaround yet

SirAddam commented 2 years ago

Same problem here

ahzahri commented 2 years ago

For info, i could fix the issue using this PR : #522 Suboptimal and temporary solution but my customer was glad that we didn't rollback into the spinners...

vonovak commented 2 years ago

closed by https://github.com/react-native-datetimepicker/datetimepicker/pull/540 (v5 release)