react-native-datetimepicker / datetimepicker

React Native date & time picker component for iOS, Android and Windows

MIT License

2.54k stars 413 forks source link

fix(android): Re-enable setting max date #908

Closed bogdanorzea closed 5 months ago

bogdanorzea commented 5 months ago

Summary

This is a regression in 8.1.0 caused by the removal of a condition that sets the max date in Android: https://github.com/react-native-datetimepicker/datetimepicker/commit/3b635633844864cdfd7a109ffe927e271872213e#diff-c69fee0670676f78b9b27aeb6fbadc9c9edf486510166dc8194c5c8232f626ecL119-L121

Test Plan

What's required for testing (prerequisites)?

Run the example app using the command: yarn start:android

What are the steps to reproduce (after prerequisites)?

Tap TOGGLEMINMAXDATE button to open the DatePicker dialog. One should only be able to tap the available dates.

Compatibility

OS	Implemented
iOS	❌
Android	✅

Checklist

[x] I have tested this on a device and a simulator
[ ] ~I added the documentation in README.md~
[ ] ~I updated the typed files (TS and Flow)~
[ ] ~I added a sample use of the API in the example project (example/App.js)~
[ ] ~I have added automated tests, either in JS or e2e tests, as applicable~

vonovak commented 5 months ago

Hello, and thank you for the PR! Sorry for missing this. If you have the bandwidth, adding an e2e test for this would be nice :) Thank you 👍

vonovak commented 5 months ago

:tada: This issue has been resolved in version 8.1.1 :tada:

If this package helps you, consider sponsoring us! :rocket: