react-native-documents / document-picker

Document Picker for React Native
https://react-native-documents.github.io/
MIT License
1.35k stars 440 forks source link

Android API level update, requiring new apps to target API level 30 (Android 11) (Android SDK 30) #446

Closed IhorFedorkiv94 closed 2 years ago

IhorFedorkiv94 commented 3 years ago

Question

In 2021, we are continuing with our annual target API level update, requiring new apps to target API level 30 (Android 11) in August and in November for all app updates. https://android-developers.googleblog.com/2020/11/new-android-app-bundle-and-target-api.html

Should expect to update react-native-document-picker lib ? current version react-native-document-picker lib:

image

vonovak commented 3 years ago

Hello, thanks for asking.

The document picker will be compiled using the same settings as your app, I do not believe we need to change anything although updating the repository's example app might be nice.

Thanks! 🙂

avorona commented 2 years ago

@vonovak Hi! I encounter that in my project with sdk version 30.0.2 document-picker installs 29.0.2 version. I'm not sure what version does it use, but may be it's better to change build.gradle settings to use target SDK ?

p.s. and also I'll be thankful if you tell me how for ex. DocumentPicker_buildToolsVersion prop's names resolve? I can't understand where it could be set.

vonovak commented 2 years ago

@avorona hello, it indeed seems like the document picker does not use the project build sdk.

Please try specifying DocumentPicker_buildToolsVersion in you project's file same as it's done here: https://github.com/rnmods/react-native-document-picker/blob/4074be8850c11a68337a8ae0baeab2897be2c669/example/android/build.gradle#L4

ultimately we probably want to get rid of the DocumentPicker_ prefix from DocumentPicker_buildToolsVersion from the library sources, can you please try if that fixes your issue and confirm that?

Thank you! :)

avorona commented 2 years ago

yeap, it's works fine now!