react-native-documents / document-picker

Document Picker for React Native

https://react-native-documents.github.io/

MIT License

1.35k stars 441 forks source link

feat: fileCopyUri to be null if copyTo not provided #481

Closed vonovak closed 3 years ago

vonovak commented 3 years ago

Summary

motivation: fileCopyUri is now same as uri if no copyTo option was provided. This PR makes is so that fileCopyUri is specified only if copyTo is passed, otherwise is null. This makes the api a little cleaner.

Also made some other minor improvements to code.

Test Plan

tested on ios emulator and android device using the example app

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS	Implemented
iOS	✅
Android	✅

Checklist

[x] I have tested this on a device and a simulator
[x] I added the documentation in README.md
[x] I updated the typed files (TS and Flow)

tomgreco commented 2 years ago

I'm getting null sometimes when selecting +250 items and providing copyTo: 'cachesDirectory'. Latest version of the library and latest version of iOS.

vonovak commented 2 years ago

I'm getting null sometimes when selecting +250 items and providing copyTo: 'cachesDirectory'. Latest version of the library and latest version of iOS.

is something present in the error field then?

tomgreco commented 2 years ago

Disregard, it was an error in my side. Not this awesome library :)

On Mar 3, 2022, at 7:11 PM, Vojtech Novak @.***> wrote:

I'm getting null sometimes when selecting +250 items and providing copyTo: 'cachesDirectory'. Latest version of the library and latest version of iOS.

is something present in the error field then?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you commented.