react-native-documents / document-picker

Document Picker for React Native

https://react-native-documents.github.io/

MIT License

1.35k stars 437 forks source link

Add vcard support #563

Closed cancit closed 2 years ago

cancit commented 2 years ago

Summary

Adds support for picking vCard files, also known as Virtual Contact File (.vcf). It is useful for sending contact data.

Test Plan

What's required for testing (prerequisites)?

a .vcf file - can be exported from iOS Contacts app by Share Contact > Save to Files
What are the steps to reproduce (after prerequisites)?
add types.vcard type to pick, pickSingle or pickMultiple requests:
```
DocumentPicker.pickSingle({
 type: types.vcard,
})
```
confirm that vcf file can be selected
Compatibility

OS	Implemented
iOS	✅
Android	✅

Checklist

[X] I have tested this on a device and a simulator
[X] I added the documentation in README.md
[X] I updated the typed files (TS and Flow)

vonovak commented 2 years ago

Hello, thank you for the PR! There are many different file types out there, and the document picker only has "shortcuts" for the most common ones like word / zip and similar. It's hard to draw the line on what should and should not be included, but I believe the list of shortcuts we have is, at this point, final.

Therefore I will not be merging this PR.

Thank you for you effort though! 🙂