react-native-documents / document-picker

Document Picker for React Native
https://react-native-documents.github.io/
MIT License
1.35k stars 437 forks source link

Feat/new arch #588

Closed vonovak closed 1 year ago

vonovak commented 2 years ago

Issues:

clone this PR

run npx react-native run-android --active-arch-only and you'll probably be met with 2 errors which can be fixed as follows:

1) patch https://github.com/facebook/react-native/blob/49dd38f1338ab8fb37144f03980bb7f122a8f04e/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/PathUtils.kt#L202

to also look for "../../package.json"

2) copy contents of packages/react-native-codegen/lib from react-native repo to the <document-picker>/node_modules/react-native-codegen/lib

then, when I rebuild, I get more complicated errors: https://gist.github.com/vonovak/7dcef431731a5e175a84f1767ba6ccfe

Would appreciate pointers to move forward 🙂

edit: I have this pretty much done locally but need one more push to bring it over the line 👍