Closed 307499815 closed 1 year ago
Hello and thanks for the PR, I prefer to use the String.join method because it's part of the language.
Thank you
On old Android(7), crashed at 'no static method join of String'
---Original--- From: "Vojtech @.> Date: Sat, Oct 15, 2022 22:00 PM To: @.>; Cc: @.**@.>; Subject: Re: [rnmods/react-native-document-picker] UpdateDocumentPickerModule.java for String.join (PR #595)
Hello and thanks for the PR, I prefer to use the String.join method because it's part of the language.
Thank you
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>
@vonovak the plugin crash on android 7, can you merge this PR?
@vonovak if you want your plugin works with Android <= 7 you have to approve this PR see https://developer.android.com/reference/java/lang/String#join(java.lang.CharSequence,%20java.lang.CharSequence...)
let us know
I'm sorry but the PR contains changes I cannot merge. I'll look at it in 2 weeks as I get back from vacation. Thank you
Summary
Test Plan
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md