chore: add Loading Component in fallbacks

react-native-elements / playground

Exploring Possibilities with React Native Elements

https://react-native-elements.js.org

MIT License

19 stars 43 forks source link

chore: add Loading Component in fallbacks #103

Closed jugshaurya closed 2 years ago

jugshaurya commented 3 years ago

Adding Loading Spinner(Material UI) to fallbacks @ all places.
Also added MaterialUI snippents recommendation in .vscode/extension.json

@pranshuchittora please review.

netlify[bot] commented 3 years ago

👷 Deploy Preview for rne-playground processing.

🔨 Explore the source changes: 1d541cd8aeb2a8ca2e6e3704042128213474471c

🔍 Inspect the deploy log: https://app.netlify.com/sites/rne-playground/deploys/61c42b1b8be63a0007ecfb4a

pranshuchittora commented 3 years ago

LGTM. Pls fix the CI

jugshaurya commented 3 years ago

LGTM. Pls fix the CI

Build is failing because of missing package v8 https://www.npmjs.com/package/v8 , I don't get it why it needs now, till the last commit it was fine. should I add V8 to the project!. @pranshuchittora
Tested: Build is running fine on terminal, (ran npm build script)

ppp

jugshaurya commented 3 years ago

Solution: Adding a browser env preset into .babelrc file or in config-overrides file @pranshuchittora please review :)

jugshaurya commented 2 years ago

@flyingcircle, please review