react-native-elements / playground

Exploring Possibilities with React Native Elements
https://react-native-elements.js.org
MIT License
19 stars 43 forks source link

Build is currently failing #121

Closed flyingcircle closed 2 years ago

flyingcircle commented 2 years ago

https://github.com/react-native-elements/playground/actions/runs/1616009494

I think this is likely due to some of the props changes that we've made in RNE.

@jugshaurya perhaps you have some insight to this?

jugshaurya commented 2 years ago

@flyingcircle, I will look into it soon. Btw, I solved this problem earlier via https://github.com/react-native-elements/playground/pull/97. But after the latest merges during GSoC 2021. Something else pushed and made my PRs, conflicting with master branch code, I will look into it.

jugshaurya commented 2 years ago

@flyingcircle , I think the build is failing because file names are changed inside in website/docs/main folder of the react-native-elements repository, and react components of the playground are using the older filenames that were in the props/ folder.Will try to fix them all soon.

flyingcircle commented 2 years ago

awesome thanks!

jugshaurya commented 2 years ago

@flyingcircle, I figured out the problem. Actually, the playground needed Props of every component only, and the folder ./react-native-elements/website/docs/main contains them, but the MDX files contain the <Usage/> component which uses @theme/* components from react-native-elements, and since we don't have access to them in the playground we are getting the error. 3

Solution

endResult

flyingcircle commented 2 years ago

@arpitBhalla Might be relevant with the moving the packages around.

arpitBhalla commented 2 years ago

component which uses @theme/* components from react-native-elements,

No, actually these are being imported from docusaurus.

I have implemented playground editor in docusaurus docs, do we need this playground website separately now?

E.g. https://reactnativeelements.com/docs/next/avatar

arpitBhalla commented 2 years ago

moving content to props folder (in react-native-elements repository)

Yupp, we can do it. I will make changes in another PR.

arpitBhalla commented 2 years ago

@flyingcircle build is working now https://github.com/react-native-elements/playground/runs/4669222233?check_suite_focus=true

jugshaurya commented 2 years ago

moving content to props folder (in react-native-elements repository)

Yupp, we can do it. I will make changes in another PR.

@flyingcircle @arpitBhalla , I have done this moving part. Will make a PR soon.

jugshaurya commented 2 years ago

@flyingcircle @arpitBhalla, I have moved content to the props folder and added the respective Props component to each file. please review.